RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
51,149 Commits 3 Branches 658 Tags 382 MiB
Commit Graph

728 Commits

Author SHA1 Message Date
Dan Balasescu 494955aff1 Resolve inspection issues 2022-04-14 13:11:11 +09:00
Dean Herbert ea672745b0 Add ability to switch between most common tournament scenes using key bindings 2022-04-01 12:44:49 +09:00
Dean Herbert a06b0a4966 Fix tournament bracket parsing's ruleset refetch logic not working correctly 
Due to equality being based on `ShortName`, it was feasible that the
re-fetch exited early (in bindable shortcutting logic) causing the
ruleset's `OnlineID` to remain `-1` or something equally wrong.

Resolves issue pointed out at
https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.
 2022-03-31 18:41:00 +09:00
Dean Herbert a7a7584d3e Add test coverage ensuring ruleset ID is correct after bracket read 
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
 2022-03-31 18:39:58 +09:00
Dean Herbert 2938f44e6c Update `PresentExternally` usages in line with framework changes 2022-03-24 23:41:07 +09:00
Dean Herbert df4170b939 Display star ratings in tournament mode using two decimal places 2022-02-27 23:17:04 +09:00
Dean Herbert 297e5ec62e Remove unused constants 2022-02-27 23:16:04 +09:00
Shivam 4c56458173 Change button location to the right side of dropdown 2022-02-25 15:15:40 +01:00
Shivam 333c0cd4f9 Add open folder button to open currently selected tournament 2022-02-25 14:31:46 +01:00
Dean Herbert 44f2d8a448 Allow game folder migration to fail gracefully when cleanup cannot completely succeed 2022-02-10 19:30:26 +09:00
Bartłomiej Dach 9deeaee404
Fix tournament client not loading 
Caused by a `LoadComponentsAsync()` call being fired from a worker
thread, which will throw exceptions since the recent addition of safety
checks around that method.
 2022-01-27 17:31:12 +01:00
Dean Herbert 5288eedd31 Update all usages of `RulesetID` and `Ruleset.ID` to use `Ruleset.OnlineID` 2022-01-27 15:38:03 +09:00
Salman Ahmed b2d1bd029d Turn on high poll rate when tournament chat is expanded 2022-01-22 16:34:57 +03:00
Bartłomiej Dach 03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
Susko3 19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Dean Herbert b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
Dean Herbert 51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
Joseph Madamba 5082b0e63f Fix some identifiers using shortened naming 2021-12-27 20:26:28 -08:00
Joseph Madamba 7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Bartłomiej Dach 38702beabf
Merge branch 'master' into i-ruleset-store 2021-12-04 15:05:39 +01:00
Dean Herbert 1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert e75e209053 Cache and consume `IRulesetStore` where feasible 2021-12-03 18:16:01 +09:00
Dean Herbert 5158736839 Avoid saving bracket if parsing failed, at all costs 2021-12-03 16:06:38 +09:00
Dean Herbert ba05a0a383 Centralise specification of bracket.json filename 2021-12-03 16:04:11 +09:00
Bartłomiej Dach 87d6a743dd
Migrate custom tournament client assets to uppercased directories 
It has transpired that on filename-case-sensitive filesystems, the
tournament client does not consistently handle custom asset paths.
Videos and mods could only be looked up from `videos` and `mods`
directories (lowercase), while flags could only be looked up from the
`Flags` directory (uppercase).

A complicating circumstance is that default country flags, coming from
osu-resources, also depend on the flag lookup being uppercased.

To attempt to clean up the handling as much as it appears to be
possible, automatically move user-supplied lowercase directories to
uppercase.
 2021-11-28 16:36:19 +01:00
Dean Herbert bbd3ea5b77 Update all actual usages of `RulesetInfo.ID` to use `OnlineID` instead 2021-11-24 15:50:26 +09:00
Dean Herbert 86540d1fb6 Update existing usages of `Author` as `string` to access `Username` directly 2021-11-04 18:57:54 +09:00
Dean Herbert b9983add15 Rename `User` to `APIUser` and move to correct namespace 2021-11-04 18:21:31 +09:00
Dean Herbert 10a9266956 Fix beatmap creator showing twice in tournament map pool panels 2021-11-01 14:33:24 +09:00
Dean Herbert 6f5040722a Merge branch 'master' into beatmap-refactor/uncontested 2021-10-28 16:37:26 +09:00
Dan Balasescu f9ca7f5df1
Merge pull request #15319 from peppy/beatmap-refactor/tournament 
Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode
 2021-10-28 16:26:06 +09:00
smoogipoo 313f78cbfb Fix non-null inspection 2021-10-28 15:24:44 +09:00
Dean Herbert a6669a3892 Add mention of why the serialisation happens outside stream usage 2021-10-28 15:04:09 +09:00
Dean Herbert ef26b0ba8a Fix serlialisation failure during ladder saving causing all existing file content to be deleted 2021-10-28 15:00:30 +09:00
Dean Herbert f3d208fecf Remove TODO (tested to work correctly) 2021-10-28 14:48:36 +09:00
Dean Herbert 7245baba69 Remove `IBeatmapSetOnlineInfo` implementation from `BeatmapSetInfo` to avoid null cases 2021-10-28 00:50:45 +09:00
Dean Herbert f1499641f3 Rename all usages of `APIBeatmap` to `beatmap` in tournament namespace 2021-10-27 18:42:48 +09:00
Dean Herbert 5448b94039 Change repopulation rules to cover the fact that the serisalisation model has changed 
This also adds a progress display to show how repopulation is going. It
can take a while on a large bracket.
 2021-10-27 18:42:48 +09:00
Dean Herbert 35168948fe Fix `PopulateUser` not populating immediately when `immediate` is specified (due to scheduling) 2021-10-27 18:26:44 +09:00
Dean Herbert 3130616300 Update tournament components to use `APIBeatmap` directly 2021-10-27 18:26:44 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
Dean Herbert 7111f58bfe Fix tournament client silently failing on error during parsing 2021-10-25 16:49:33 +09:00
Dean Herbert 7c99193ada Add tournament `LadderInfo` serialisation tests 2021-10-25 16:49:33 +09:00
Dean Herbert 32d01f022f Rename usages which rely on online backing 2021-10-21 16:58:42 +09:00
Dean Herbert 0706ad70fb Move `BeatmapSetOnlineInfo` to an interface type 2021-10-21 16:58:42 +09:00
Dean Herbert 794b4c46cf Split score counter class into two distinct classes to simplify usages 2021-10-10 17:56:32 +09:00
Dean Herbert 446f091d32 Use comma separator for tournament score displays 2021-10-10 16:06:12 +09:00
Dean Herbert 672664dce7 Fix all remaining cases of incorrect `Bindable<string>` defaults 2021-10-08 13:55:22 +09:00
Dean Herbert 42d3fe8f02 Merge branch 'master' into fix-SettingsTextBox-using-null-as-default 2021-10-08 13:37:28 +09:00
Dan Balasescu 4bbff2ebf7
Merge branch 'master' into new-interfaces 2021-10-06 11:38:17 +09:00