Commit Graph

51149 Commits

Author SHA1 Message Date
Bartłomiej Dach a915b7333c
Remove unused using directive 2022-05-06 13:08:54 +02:00
Dean Herbert 88c190f3e3 Change colour denoting expanded state to be gray rather than yellow
I always found the yellow colour very non-descript in this case. Gray
seems to work better?
2022-05-06 19:45:17 +09:00
Dean Herbert b432885e5f Tidy up ordering of `SettingsToolboxGroup` 2022-05-06 19:39:09 +09:00
Dean Herbert 59add66632 Remove unnecessary autosize workaround (was fixed long ago) 2022-05-06 19:39:00 +09:00
Dean Herbert 949e30c4b4 Remove auto-expansion of individual toolbox groups when parent expanding container expands 2022-05-06 19:36:41 +09:00
Dan Balasescu 09139ef9f4
Merge pull request #18116 from peppy/guest-is-system-user
Mark `GuestUser` as system user via `Id` for now
2022-05-06 18:13:03 +09:00
Dean Herbert 319867f73c Mark `GuestUser` as system user via `Id` for now
Should resolve https://github.com/ppy/osu/issues/18105.

Checking through usages, it doesn't immediately look like this will
regress any other scenarios.
2022-05-06 17:37:46 +09:00
Dean Herbert 35e307672b
Merge pull request #18110 from jai-x/new-chat-min-max-height
Clamp maximum and minimum height the chat overlay can be resized to
2022-05-06 12:43:58 +09:00
Jai Sharma 7ffe3b132f Use `BindableFloat` in chat height tests 2022-05-05 23:13:43 +01:00
Jai Sharma 0974de8fb0 Use `BindableFloat` for chat height 2022-05-05 23:13:32 +01:00
Jai Sharma 16a6c11bc8 Clamp maximum and minimum height the chat overlay can be resized to 2022-05-05 21:40:37 +01:00
Dean Herbert e2895ea145
Merge pull request #18108 from bdach/mod-overlay/customisation-auto-show-bug
Close new design's mod customisation area on escape press before exiting
2022-05-06 04:21:08 +09:00
Bartłomiej Dach 79e1b93b30
Close customisation area on escape press before exiting 2022-05-05 19:17:36 +02:00
Bartłomiej Dach 8002726c9c
Add test coverage for dismissing customisation area with Escape 2022-05-05 19:17:36 +02:00
Bartłomiej Dach 2cc56a4b19
Fix hidden issue with automatic customisation panel show logic
Doesn't cause tests to fail headless, but they do fail in the test
browser.
2022-05-05 19:17:36 +02:00
Dean Herbert 14d2159b8c
Merge pull request #18033 from jai-x/new-chat-overlay
Implement basic layout and behaviour of new chat overlay
2022-05-06 00:10:46 +09:00
Dean Herbert 9d48bb41c9
Merge branch 'master' into new-chat-overlay 2022-05-05 23:12:31 +09:00
Jai Sharma 5657e7f11e Fix chat height saving/loading test 2022-05-05 14:52:03 +01:00
Jai Sharma 9cb52f8879 Add tests for chat height saving/loading 2022-05-05 14:21:26 +01:00
Bartłomiej Dach b9d8d1b4f6
Merge pull request #18090 from peppy/playlist-keyboard-traversal
Add support for traversing playlist items using next/previous bindings
2022-05-05 15:21:02 +02:00
Jai Sharma 5ea6f62951 Ensure `RelativePositionAxes` is set in BDL for animations to work 2022-05-05 14:20:33 +01:00
Bartłomiej Dach a859ca0b89
Merge branch 'master' into playlist-keyboard-traversal 2022-05-05 14:45:58 +02:00
Dan Balasescu 8ac4d72dc8
Merge pull request #18093 from peppy/dialog-overlay-thread-woes
Fix dialogs pushed to `DialogOverlay` too early potentially doing cross-thread transforms
2022-05-05 21:44:52 +09:00
Dan Balasescu e46f99bdba
Merge branch 'master' into dialog-overlay-thread-woes 2022-05-05 20:57:51 +09:00
Salman Ahmed 8a1f63e50e
Merge pull request #18100 from peppy/snapping-tidy-distance
Add xmldoc for `IDistanceSnapProvider` and related properties
2022-05-05 14:56:24 +03:00
Bartłomiej Dach a9eae3a544
Merge branch 'master' into snapping-tidy-distance 2022-05-05 13:15:24 +02:00
Dean Herbert 85dd49cdb0
Merge pull request #18082 from frenzibyte/beatmap-selection-keybinding
Add key binding for beatmap selection in song select
2022-05-05 20:14:16 +09:00
Dan Balasescu 39d10487b9
Merge branch 'master' into snapping-tidy-distance 2022-05-05 19:55:55 +09:00
Salman Ahmed 542bb54ba0
Merge branch 'master' into beatmap-selection-keybinding 2022-05-05 13:44:08 +03:00
Dean Herbert 684db27bb8 Reword binding text to read better 2022-05-05 19:40:44 +09:00
Dan Balasescu ab2e30d625
Merge pull request #18101 from peppy/cache-at-interface
Move caching specification to interface for several editor interfaces
2022-05-05 19:36:08 +09:00
Dean Herbert 97221d2ef1 Tidy up initialisation 2022-05-05 19:24:18 +09:00
Dean Herbert e54f5e2d92 Adjust value change variables to avoid `e` usage 2022-05-05 19:22:20 +09:00
Dean Herbert 74505ba166 Remove `!` usage (also seems to fix height saving/loading) 2022-05-05 19:22:12 +09:00
Dean Herbert 25ea660b0b Replace `HandlePositionalInput` override with simple hover effect 2022-05-05 19:13:48 +09:00
Dean Herbert e7205d8593 Reset all test data before each test method to avoid channels stuck in joined state 2022-05-05 19:09:56 +09:00
Dean Herbert 2ff900fd22
Merge pull request #18102 from frenzibyte/fix-inspection
Wrap `BeatmapOnlineLookupQueue` cache request in a task
2022-05-05 19:06:58 +09:00
Dean Herbert 4efaa41670
Merge branch 'master' into new-chat-overlay 2022-05-05 18:57:00 +09:00
Dean Herbert e83604a1fc Merge branch 'master' into cache-at-interface 2022-05-05 18:54:24 +09:00
Salman Ahmed 67341db0e7 Wrap `BeatmapOnlineLookupQueue` cache request in a task 2022-05-05 12:40:02 +03:00
Bartłomiej Dach 2822ae0981
Merge pull request #18099 from peppy/snapping-tidy
Add xmldoc and rename methods in `IPositionSnapProvider` for legibility
2022-05-05 10:39:32 +02:00
Bartłomiej Dach 5e4d07760d
Merge branch 'master' into snapping-tidy 2022-05-05 10:17:48 +02:00
Dean Herbert c3d2648f85
Reword weird xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-05 17:07:05 +09:00
Dean Herbert 5a1ac71d90 Remove unnecessary type specification in `HitObjectComposer`'s caching 2022-05-05 16:44:37 +09:00
Dean Herbert 1c6a233cc0 Move snap provider caching to interfaces 2022-05-05 16:44:37 +09:00
Dean Herbert b411b59006 Move `IPlacementHandler` caching to interface 2022-05-05 16:43:02 +09:00
Dean Herbert 977e6d8a80 Add xmldoc for `IDistanceSnapProvider` and related properties 2022-05-05 16:25:45 +09:00
Dean Herbert 6227e3f876 Add comprehensive documentation of `BeatmapInfo.DistanceSpacing` 2022-05-05 16:25:45 +09:00
Salman Ahmed ac6342ff8d Add workaround for item scrolling issue 2022-05-05 10:16:16 +03:00
Dean Herbert 1fce0da331 Reword slightly, to allow better conformity with `IDistanceSnapProvider` 2022-05-05 16:04:34 +09:00