Commit Graph

69810 Commits

Author SHA1 Message Date
Bartłomiej Dach 4fa101d935
Merge pull request #26303 from OliBomby/grids
Add keybind for cycling grid type
2024-10-16 13:12:23 +02:00
Bartłomiej Dach 882df6b828
Remove unused field
Not sure why inspectcode is quiet about this?
2024-10-16 09:59:05 +02:00
Bartłomiej Dach dcf78a6e2c
Merge branch 'master' into grids 2024-10-16 09:55:27 +02:00
Bartłomiej Dach 8ed0554b91
Merge pull request #30245 from 424ever/group-slider-ends
Group `HitResult`s with the same name into one column in beatmap ranking
2024-10-16 09:40:45 +02:00
Dean Herbert c9519dc90b
Merge pull request #30264 from LBlend/change-fps-toggle-keybind
Remove default keybind for "Toggle FPS counter"
2024-10-16 16:35:02 +09:00
Bartłomiej Dach 5fff632c9f
Merge pull request #30231 from SchiavoAnto/skin-editor-ui-localisation
Allow more localisation in skin editor
2024-10-16 09:17:45 +02:00
Bartłomiej Dach f8a13b0beb
Fix migration not checking combination properly 2024-10-16 08:17:22 +02:00
Dean Herbert 8e76dd553e
Merge pull request #30219 from bdach/scale-with-no-axes-should-do-nothing
Ensure at least one scale popover axis is active at any time
2024-10-16 04:31:45 +09:00
Bartłomiej Dach b92cbff81d
Merge branch 'master' into scale-with-no-axes-should-do-nothing 2024-10-15 14:20:24 +02:00
Bartłomiej Dach 634f20e8de
Ensure at least scale popover axis toggle is active at any time
As in, toggling off an axis if it is the only one enabled will enable
the other one in turn.

Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-10-15 14:12:17 +02:00
Jonas Brandstötter a007a81fe8
Only keep track of the names of hit results to display in a `ScoreTable` 2024-10-14 16:55:07 +02:00
Jonas Brandstötter 285756802c
Sum up totals for hit results with the same name 2024-10-14 16:33:30 +02:00
Jonas Brandstötter 511f0e99b3
Correct typo 2024-10-14 16:16:00 +02:00
Jonas Brandstötter 25c0ff4168
Correct reference to hit result and link to them 2024-10-14 16:14:29 +02:00
schiavoanto d7021f989b Revert 9cd7f2b and fc1ebfd 2024-10-14 16:14:23 +02:00
Jonas Brandstötter 750e0b29ca
Use `ChildrenOfType<>` to get ScoreTable to test 2024-10-14 16:11:58 +02:00
Dean Herbert 790f863e06
Merge pull request #30277 from bdach/fix-shuffle-more
Fix shuffle not actually changing the track sometimes
2024-10-14 23:09:13 +09:00
Leander Furumo 035e5a9613
migrate clearance of conflicting ToggleFPSDisplay keybind 2024-10-14 16:03:29 +02:00
Bartłomiej Dach 8cec318c1f
Loop track even if shuffling if there is only one available
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-10-14 15:28:32 +02:00
Bartłomiej Dach 17aed26f85
Fix shuffle not actually changing the track sometimes
See https://github.com/ppy/osu/pull/30215#issuecomment-2407775408 for
context.

Turns out the test failures were more correct than I'd thought. The
long-and-short of it is that both in "pure random" mode and in
"permutation" mode, when running out of track history to fall
back on, it was possible for the random algorithm to pick the same song
twice in a row - which is probably not desired, and which this explicit
exclude should make impossible.
2024-10-14 13:18:45 +02:00
Bartłomiej Dach 639eb7ae4a
Merge pull request #30274 from shinmorisawa/master
Respect "Prefer metadata in original language" toggle in beatmap deletion dialog
2024-10-14 12:02:03 +02:00
Shin Morisawa 8ff86d560f
Merge branch 'master' into master 2024-10-14 17:48:04 +09:00
Bartłomiej Dach 120eb9adea
Merge pull request #30261 from peppy/faster-quick-retry
Decrease the time it takes to quick retry by ~650 ms
2024-10-14 10:24:35 +02:00
Shin Morisawa 0664b185c3
Merge branch 'master' into master 2024-10-14 16:46:44 +09:00
Bartłomiej Dach 74675c8c78
Merge pull request #30080 from OliBomby/clamp-scale2
Clamp scale with lower and upper bounds
2024-10-14 08:17:22 +02:00
Shin Morisawa 90a08b8a68 Fix Beatmap Delete Dialog 2024-10-14 09:55:28 +09:00
Leander Furumo 379794c462
replace empty keybinding array with input key type of None 2024-10-14 00:00:45 +02:00
Leander Furumo 0e768cc517
remove default keybind for toggling fps counter 2024-10-13 22:50:58 +02:00
Dean Herbert f8bce706fa
Merge pull request #30239 from rozukke/reset-offsets
Add functionality to mass reset offsets
2024-10-14 01:56:14 +09:00
Leander Furumo 8f1fbb44c4
change fps toggle keybind 2024-10-13 17:36:06 +02:00
Dean Herbert 53671ad11e
Only update beatmaps which actually had offsets
Without this every beatmap gets a write and it reloads the whole of song
select, basically.
2024-10-14 00:35:18 +09:00
Dean Herbert 868a7db9e9
Start preparing player earlier when quick retrying
Should help with https://github.com/ppy/osu/issues/9039.
2024-10-13 22:29:00 +09:00
Dan Balasescu 9681e3ac46
Overwrite downloaded data packages
In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002, I cancelled the run during the download from `data.ppy.sh`.

In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857, `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download.

The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process.

Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...
2024-10-13 18:43:02 +09:00
Dan Balasescu 9abca53829
Merge pull request #30246 from Joehuu/recommend-csdevkit-instead
Recommend C# Dev Kit extension on VSCode
2024-10-13 15:02:03 +09:00
Jonas Brandstötter dcd3e5194e
Group `HitResult`s with the same name into one column in beatmap ranking
Closes #29911
2024-10-12 22:53:08 +02:00
Joseph Madamba e1e8e39a89
Recommend C# Dev Kit extension on VSCode 2024-10-12 12:12:40 -07:00
Artemis Rosman e4f9c861ba Add functionality to mass reset offsets 2024-10-13 00:50:45 +11:00
Dan Balasescu 2de1955892
Merge pull request #30218 from bdach/daily-challenge-conclusion-offline
Do not show daily challenge conclusion notification on disconnection
2024-10-12 18:14:22 +09:00
Joseph Madamba 71b08b54c1 Make `TernaryStateRadioMenuItem` localisable 2024-10-11 18:48:04 -07:00
schiavoanto fc1ebfdf64 Fix layers dropdown localised entries 2024-10-12 02:00:51 +02:00
schiavoanto 9cd7f2b5d4 Use `LocalisableDescription` for skin editor layers dropdown 2024-10-12 01:38:52 +02:00
schiavoanto 1e7e2e0b1c Add more localisation in skin editor 2024-10-12 00:55:33 +02:00
OliBomby 9f73a45580 Explicitly assert specific grid type 2024-10-11 23:57:26 +02:00
Dean Herbert 8b046f60f0
Update test 2024-10-12 02:23:43 +09:00
Dean Herbert b62d9f8696
Fix bindings being clobbered 2024-10-12 02:19:02 +09:00
Dean Herbert 05c8b3cbce
Simplify cycle logic 2024-10-12 02:18:36 +09:00
Dean Herbert d07a2fbb57
Change shortcut to `Shift`+`G` 2024-10-12 02:18:08 +09:00
Dean Herbert 3a8ed889b5
Merge pull request #30215 from bdach/fix-music-controller
Fix track restarting when trying to switch track change direction with shuffle active
2024-10-12 01:41:44 +09:00
Bartłomiej Dach 4e8e4a34bd
Fix scale popover doing things when both scale axes are turned off
Spotted in passing when reviewing https://github.com/ppy/osu/pull/30080.
The popover would very arbitrarily revert to scaling by Y axis if both
checkboxes were checked off.

Not sure how this passed review.
2024-10-11 15:18:43 +02:00
Bartłomiej Dach 5db1f05953
Merge branch 'master' into clamp-scale2 2024-10-11 15:13:54 +02:00