d1da1d4079
Rename methods to fit new changes better
2024-10-11 15:03:30 +02:00
07d15cc35a
Add positive assertion for conclusion notification being present too
2024-10-11 14:31:30 +02:00
968835bb44
Do not show daily challenge conclusion notification on disconnection
...
Closes https://github.com/ppy/osu/issues/30194 .
2024-10-11 14:18:19 +02:00
9d1eb842a7
Add failing test
2024-10-11 14:16:24 +02:00
550e575221
Rename "Cycle grid display mode" to "Cycle grid spacing"
...
The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.
2024-10-11 14:09:50 +02:00
56bfcde446
Update grid placement tool test
...
I somehow missed this test when splitting up PRs so here it is now
2024-10-11 14:09:50 +02:00
ada20d230a
Fix grid type cycling not taking into account the radio button selection
2024-10-11 14:09:50 +02:00
b93bc21e45
Add back the old keybind for cycling grid spacing
2024-10-11 14:09:50 +02:00
e56a9d2ad4
Add TestGridFromPoints
2024-10-11 14:09:50 +02:00
bfe78ff3a0
fix grid test
2024-10-11 14:09:50 +02:00
d98cc7fe66
use G to change grid type
2024-10-11 14:09:50 +02:00
4a16341a94
Fix crash when switching tracks back and forth with shuffle on
2024-10-11 12:45:14 +02:00
1a25e9d179
Add another failing test case for crash
2024-10-11 12:45:03 +02:00
47cb696b69
Fix switching direction when changing tracks with shuffle on restarting the same track
...
Closes https://github.com/ppy/osu/issues/30190 .
2024-10-11 12:40:45 +02:00
0882f1bb70
Add failing test case
2024-10-11 12:33:43 +02:00
616c2aeefc
Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck
...
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-11 12:02:58 +09:00
af55585dc8
Make `TriggerAction` public
2024-10-10 20:50:47 +02:00
fc7ad96fcd
Move circle flash to `TriggerAction`
2024-10-10 20:20:02 +02:00
9cc6ee2ebc
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-10 20:14:11 +02:00
c545269eec
Merge pull request #30198 from bdach/thank-you-discord-once-more
...
Fix discord RPC complaining yet again if given a single space character as activity state / details
2024-10-11 01:15:56 +09:00
14ecd56913
Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans
...
Fix crashes when attempting to change from a custom ruleset with mods selected to another
2024-10-11 00:57:28 +09:00
245d05a2e2
Merge pull request #30199 from bdach/no-song-progress-tooltip-during-gameplay
...
Fix argon song progress bar tooltip showing during active gameplay
2024-10-11 00:03:27 +09:00
938c3d78ce
Fix argon song progress bar tooltip showing during active gameplay
...
Closes https://github.com/ppy/osu/issues/30197 .
Pretty bad one, might be worth a hotfix...
2024-10-10 14:36:28 +02:00
687bdad389
Remove no-longer-required cache-over hack
...
This is now removable after `AdvancedStats` has been weaned off the
global mods bindable. I think this is a win all things considered?
2024-10-10 14:22:20 +02:00
f1842d781e
Decouple `AdvancedStats` from global mods
...
Closes https://github.com/ppy/osu/issues/30163 .
If I'm to be blunt, the decoupled stuff in song select makes my head
spin. I spent a solid 20 minutes thinking how I was going to fix this
one but then finally realised that generally most of the cause there
was the fact that `AdvancedStats` was seeing the new rulesets *before*
the "ensure global selected mods are valid for current ruleset" logic,
and so decided to just _delay_ that until the decoupled transfer
thingamajig happens.
I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
`Mods` into one property on `AdvancedStats`. I figured I'd rather not
push my luck and try the baseline version first, but I honestly think
that direction is going to be required at some point to properly corral
all of the decoupled madness taking place in song select.
2024-10-10 14:22:16 +02:00
a7fcfd5f0d
Fix discord RPC complaining yet again if given a single space character as activity state / details
...
Closes https://github.com/ppy/osu/issues/30178 .
Really, discord?
2024-10-10 13:59:18 +02:00
cab97a96ab
Merge pull request #30189 from OliBomby/fix-splittable
...
Fix split control point context menu option not showing up on newly created control points
2024-10-10 11:37:24 +02:00
9936ec579f
Fix isSplittable depending on unreliable order of path control point pieces
2024-10-09 23:31:12 +02:00
a6f56036a2
Merge pull request #30164 from bdach/am-i-fired-this-time
...
Fix game deadlocking on startup when set to single thread mode
2024-10-09 19:55:01 +09:00
baa64d1486
Migrate `MusicController` to `Live<T>` to fix broken migrations instead
2024-10-09 11:59:04 +02:00
081d87fe6d
Revert 'Fix any and all migration attempts dying on MusicController'
...
This reverts commit 310eec69fc
2024-10-09 11:55:59 +02:00
270c4c4f12
Merge pull request #30151 from bdach/migration-is-completely-fucked
...
Fix several breakages with migration operation
2024-10-09 14:24:34 +09:00
d836dba982
Rename and xmldoc `RealmResetEmptySet`
2024-10-09 14:18:34 +09:00
48dacd1c15
Remove unused property
2024-10-09 13:45:35 +09:00
7ccb770009
Update framework
2024-10-09 12:36:51 +09:00
68ebf64b2d
Fix dependabot line endings
2024-10-09 12:36:44 +09:00
4a84c6e778
Merge pull request #30153 from ppy/dependabot/nuget/osu.Desktop/System.IO.Packaging-8.0.1
...
Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop
2024-10-09 12:13:56 +09:00
6a754222e4
Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop
...
Bumps [System.IO.Packaging](https://github.com/dotnet/runtime ) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/dotnet/runtime/releases )
- [Commits](https://github.com/dotnet/runtime/compare/v8.0.0...v8.0.1 )
---
updated-dependencies:
- dependency-name: System.IO.Packaging
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-10-09 01:30:23 +00:00
b811b9baf6
Fix `DetachedBeatmapStore` special condition for detecting resets from blocking all operations failing on empty databases
...
See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244 .
2024-10-08 23:16:17 +02:00
1633cbdb66
Fix `OsuGameBase.Migrate()` eating exception messages for breakfast
...
Whomst've thought this was an ok thing to do? How did this pass review?
Let's leave these as rhetorical questions right now. Huge chances are
I'd implicate myself with at least one of them.
2024-10-08 23:16:17 +02:00
310eec69fc
Fix any and all migration attempts dying on `MusicController`
...
I'm not sure why this was "fine" for as long as it apparently was,
but what `MusicController` was doing was completely incorrect and
playing with fire (accessing raw managed realm objects), which went
wrong somewhere around - admittedly -
https://github.com/ppy/osu/pull/29917 , likely because that one started
*storing* these raw managed realm objects to fields, and you know what
will happen to those after you do a migration and recycle realms.
To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
Which does necessitate moving it to `OsuGameBase`, but it's the simplest
way out I can see. I guess the alternative would be to faff around with
`Live<T>` but it's ugly and I'm attempting to fix this relatively quick
right now.
2024-10-08 23:16:10 +02:00
bfad281f62
Merge pull request #26313 from OliBomby/grids-4
...
Add grid placement tool
2024-10-08 19:16:52 +09:00
de2f9dec39
Let right-click reset grid to default values
2024-10-08 10:51:35 +02:00
e794862da5
update comment
2024-10-08 10:46:10 +02:00
b1be31cd6a
Switch back to last tool after using grid tool, rather than always select tool
2024-10-08 17:34:51 +09:00
682023e130
Merge branch 'master' into grids-4
2024-10-08 16:26:42 +09:00
b658d9a681
Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2
...
Avoid updates (and update notifications) from appearing in more gameplay cases
2024-10-08 15:17:09 +09:00
105008672d
Merge pull request #30139 from bdach/bump-diffcalc-versions
...
Bump difficulty calculator versions
2024-10-08 15:00:28 +09:00
dc267733d1
Use FA icon instead
2024-10-07 19:09:21 +02:00
66459c50de
Rename to 'Grid'
2024-10-07 19:09:09 +02:00
Bartłomiej Dach
OliBomby
Dan Balasescu
Marvin Schürz
Dean Herbert
dependabot[bot]