RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only keep track of the names of hit results to display in a `ScoreTable`

This commit is contained in:
Jonas Brandstötter 2024-10-14 16:55:07 +02:00
parent 285756802c
commit a007a81fe8
No known key found for this signature in database
GPG Key ID: DF758C8A6271E098
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game/Overlays/BeatmapSet/Scores/ScoreTable.cs
View File

@ -57,11 +57,11 @@ public ScoreTable()
}
/// <summary>
/// The statistics that appear in the table, grouped by their display name. If multiple HitResults have the same
/// The names of the statistics that appear in the table. If multiple HitResults have the same
/// DisplayName (for example, "slider end" is the name for both <see cref="HitResult.SliderTailHit"/> and <see cref="HitResult.SmallTickHit"/>
/// in osu!) the name will only be listed once.
/// </summary>
private readonly List<(LocalisableString displayName, IEnumerable<HitResult> results)> statisticResults = new List<(LocalisableString displayName, IEnumerable<HitResult> results)>();
private readonly List<LocalisableString> statisticResultNames = new List<LocalisableString>();
private bool showPerformancePoints;
@ -73,7 +73,7 @@ public void DisplayScores(IReadOnlyList<ScoreInfo> scores, bool showPerformanceC
return;
showPerformancePoints = showPerformanceColumn;
statisticResults.Clear();
statisticResultNames.Clear();
for (int i = 0; i < scores.Count; i++)
backgroundFlow.Add(new ScoreTableRowBackground(i, scores[i], row_height));
@ -117,7 +117,7 @@ private TableColumn[] createHeaders(IReadOnlyList<ScoreInfo> scores)
continue;
columns.Add(new TableColumn(resultGroup.Key, Anchor.CentreLeft, new Dimension(minSize: 35, maxSize: 60)));
statisticResults.Add((resultGroup.Key, resultGroup.Select(r => r.result)));
statisticResultNames.Add(resultGroup.Key);
}
if (showPerformancePoints)
@ -168,7 +168,7 @@ private Drawable[] createContent(int index, ScoreInfo score)
var availableStatistics = score.GetStatisticsForDisplay().ToLookup(tuple => tuple.DisplayName);
foreach (var (columnName, resultTypes) in statisticResults)
foreach (var columnName in statisticResultNames)
{
int count = 0;
int? maxCount = null;
@ -176,6 +176,7 @@ private Drawable[] createContent(int index, ScoreInfo score)
if (availableStatistics.Contains(columnName))
{
maxCount = 0;
foreach (var s in availableStatistics[columnName])
{
count += s.Count;