61797 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	38244c081f	Further refactorings along with shadow implementation	2023-07-30 02:29:14 +09:00
Dean Herbert	84bc14c1dd	Improve animation and sizing of maximised screen display	2023-07-30 02:29:14 +09:00
Dean Herbert	1826819663	Move Facade to nested class	2023-07-30 02:29:14 +09:00
Dean Herbert	5fa0a21b56	Add corner radius around player areas	2023-07-30 02:29:14 +09:00
Bartłomiej Dach	55cb400674	Merge pull request #24386 from peppy/fix-autoplay-mod-revert ... Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios	2023-07-29 16:43:46 +02:00
Bartłomiej Dach	579b0bc570	Merge branch 'master' into fix-autoplay-mod-revert	2023-07-29 16:12:11 +02:00
Bartłomiej Dach	43a51671ac	Fix wrong test step name	2023-07-29 16:12:02 +02:00
Dean Herbert	a7ff084be2	Merge pull request #24405 from bdach/spinner-input-test	2023-07-29 11:34:45 +09:00
Bartłomiej Dach	cd416e09f9	Add test scene for checking spinner judgements	2023-07-29 00:49:21 +02:00
Bartłomiej Dach	c21167e2ab	Merge pull request #24360 from peppy/spinner-faster-rotation ... Change spinner rotation animation to match input 1:1	2023-07-29 00:48:56 +02:00
Bartłomiej Dach	35defd97e1	Merge pull request #24389 from peppy/ladder-grid-expand ... Allow ladder editor grid to scale with content	2023-07-28 23:40:40 +02:00
Bartłomiej Dach	c6f0cf50ca	Use better safety in rectangular grid ... - Checking `DrawSize != Vector2.Zero` is too specific. It could also crash on zero-height-but-non-zero-width, or zero-width-but-non-zero-height. - Take the `gridCache.Validate()` call out of the zero checks, because even if the width or height are zero, not generating anything is valid and there is no reason to validate every frame until `gridCache` gets invalidated again.	2023-07-28 22:57:02 +02:00
Bartłomiej Dach	0c10d875ce	Merge branch 'master' into ladder-grid-expand	2023-07-28 22:51:33 +02:00
Bartłomiej Dach	998395c7a7	Merge pull request #24390 from peppy/tournament-client-fix-startup-crash ... Fix potential startup crash due to early application of animations	2023-07-28 22:47:07 +02:00
Bartłomiej Dach	318aa4627b	Merge pull request #24374 from peppy/fix-taiko-alignment ... Fix osu!taiko editor playfield missing a piece	2023-07-28 22:46:01 +02:00
Bartłomiej Dach	caad931a16	Move comment to more fitting place	2023-07-28 22:10:10 +02:00
Bartłomiej Dach	6d018c08af	Rename Apply{Vertical -> Horizontal}Centering to match common understanding	2023-07-28 22:09:28 +02:00
Dean Herbert	f58c69e639	Fix potential startup crash due to early application of animations ... This was always haphazard code, but by luck it never triggered before drawable load until now. With the recently nullability changes, this would be triggered when `flash` is not yet constructed. Switching to `AddOnce` seems safer to avoid multiple applications, regardless.	2023-07-28 17:17:15 +09:00
Dean Herbert	c9155f85ab	Fix playfield not taking up full width correclty when not vertically centered	2023-07-28 16:40:14 +09:00
Dean Herbert	d26164e9fe	Merge branch 'master' into fix-taiko-alignment	2023-07-28 16:32:37 +09:00
Dean Herbert	aa91000505	Always place first match at (0,0)	2023-07-28 16:29:55 +09:00
Dean Herbert	b5c3e2a648	Fix placing new match via right click not using original click position	2023-07-28 16:29:39 +09:00
Dean Herbert	b5f0d739e6	Allow ladder editor grid to scale with content ... Closes https://github.com/ppy/osu/issues/24378.	2023-07-28 16:26:03 +09:00
Dean Herbert	0e4db9b439	Add safety in RectangularPositionSnapGrid that size is greater than zero ... Would crash otherwise	2023-07-28 16:25:40 +09:00
Dean Herbert	f15394fb6d	Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios	2023-07-28 14:49:06 +09:00
Dean Herbert	269d4d1cd6	Add test coverage of autoplay restore not working	2023-07-28 14:49:06 +09:00
Dean Herbert	57e51f4d5b	Merge pull request #24357 from peppy/tournament-fix-null-population ... Fix startup tournament population not recovering from null beatmaps	2023-07-28 14:31:48 +09:00
Dean Herbert	c824b2dedf	Merge pull request #24377 from ILW8/fix-tournament-switcher-height ... Allow scrolling in tournament setup screen to avoid information ending up off-screen	2023-07-28 14:27:55 +09:00
Dao Heng Liu	c7717da232	make SetupScreen scrollable	2023-07-28 14:18:48 +09:00
Bartłomiej Dach	780b8f0ec8	Merge branch 'master' into tournament-fix-null-population	2023-07-27 22:36:11 +02:00
Bartłomiej Dach	b7ddb5c946	Remove fallbacks to empty APIBeatmap on population failure ... Was causing there to be two kinds of missing `TournamentBeatmap`s: one with missing `Beatmap == null`, and one with `Beatmap == new APIBeatmap()`. In particular, they would appear differently in UI (either as "unknown - unknown", or the intensely enigmatic " - ").	2023-07-27 22:33:00 +02:00
Bartłomiej Dach	3c923b9e81	Fix even more missed nullability-related inspections	2023-07-27 22:10:41 +02:00
Bartłomiej Dach	22163020c3	Merge pull request #24367 from peppy/fix-replay-export-from-results ... Fix attempting to export replay from results screen after play not working	2023-07-27 20:47:07 +02:00
Dean Herbert	e702e0a23e	Avoid intercepting temporary files in new test	2023-07-27 17:44:36 +09:00
Dean Herbert	1e9b927b50	Fix some missed null checks	2023-07-27 17:41:27 +09:00
Bartłomiej Dach	057bac39dd	Merge pull request #24375 from peppy/add-back-mode-select-enter-close ... Add back the ability to close mod select using enter key	2023-07-26 22:43:38 +02:00
Bartłomiej Dach	973e6ded2a	Update wrong comment, too	2023-07-26 21:56:04 +02:00
Bartłomiej Dach	992f78b158	Use more consistent way of closing overlay	2023-07-26 21:54:35 +02:00
Bartłomiej Dach	f66093d3cf	Revert failing test to prior assertions too	2023-07-26 21:51:32 +02:00
Bartłomiej Dach	7bc3edb05a	Fix code quality inspection	2023-07-26 20:52:03 +02:00
Dean Herbert	8d5efc9612	Add back the ability to close mod select using enter key ... I've seen this brought up a few times (with people thinking the fact it's not working is a bug) so we'll need to keep this behaviour for now.	2023-07-27 02:36:25 +09:00
Dean Herbert	deba6e2508	Fix osu!taiko editor playfield missing a piece ... Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220	2023-07-27 02:24:10 +09:00
Dean Herbert	fa4992f05a	Apply NRT and avoid throws from null RoundBeatmap.Beatmaps	2023-07-26 17:49:07 +09:00
Dean Herbert	4889864478	Fix files references not correctly being copied after replay import in Player	2023-07-26 15:22:00 +09:00
Dean Herbert	e26afc2b89	Fix ReplayDownloadButton handling key repeat	2023-07-26 15:21:43 +09:00
Dean Herbert	2dace742a3	Add test coverage of score arriving on disk when exporting from results screen after play	2023-07-26 15:21:43 +09:00
Bartłomiej Dach	0b5be51ee0	Merge pull request #24358 from peppy/song-select-drain-length ... Show break time in tooltip at song select	2023-07-25 23:22:18 +02:00
Bartłomiej Dach	57ccf82f34	Merge branch 'master' into song-select-drain-length	2023-07-25 22:40:45 +02:00
Bartłomiej Dach	653f01f4ce	Merge pull request #24359 from peppy/fix-unknown-mod-test-failure ... Fix `TestSceneUnknownMod` failing due to null reference	2023-07-25 22:40:03 +02:00
Bartłomiej Dach	5214efca5a	Merge pull request #24208 from peppy/menu-star-fountains ... Add kiai fountains to main menu	2023-07-25 22:39:07 +02:00