Commit Graph

53973 Commits

Author SHA1 Message Date
Dean Herbert f9f9b65c86 Add test coverage of deserialisation skin layouts 2022-08-01 01:14:05 +09:00
Dean Herbert db4c6aa3d3 Add test skin layout json resources 2022-08-01 01:13:47 +09:00
Salman Ahmed 998e3b74d6
Merge pull request #19481 from peppy/fix-skin-migration
Fix previous skins not loading due to namespace changes
2022-07-30 21:56:28 +03:00
Dean Herbert 93b783d9ea Fix previous skins not loading due to namespace changes 2022-07-31 03:25:38 +09:00
Salman Ahmed 498c796c81
Merge pull request #19478 from peppy/fix-collection-migration
Fix collection migration potentially deleting the database before finishing migration
2022-07-30 19:44:22 +03:00
Dean Herbert 6ad86ce5b7 Run collection import process asynchronously
Actually required to avoid deadlocking..
2022-07-31 01:06:57 +09:00
Dean Herbert 80ffa2cf20 Move collection database rather than deleting post-migration for safety 2022-07-31 00:54:00 +09:00
Dean Herbert 8e06d55960 Fix collection migration incorrectly running asynchronously 2022-07-31 00:53:39 +09:00
Salman Ahmed 471a06883a
Merge pull request #19471 from Susko3/desktop-BatteryInfo
Add battery info / low battery warning for desktop platforms
2022-07-30 18:15:51 +03:00
Susko3 e5118130db Add 'SDL' acronym 2022-07-30 16:05:35 +02:00
Susko3 38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
Dean Herbert 43e612f6d4
Merge pull request #19455 from peppy/confirm-playlist-discard
Add confirmation dialog when about to discard a playlist
2022-07-30 19:17:49 +09:00
Salman Ahmed 8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
Salman Ahmed 369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
Dean Herbert ecf7cc77dd
Merge pull request #19469 from frenzibyte/fix-dodgy-tests
Fix potential nullref in `TestSceneAutoplay` check steps method
2022-07-30 16:46:51 +09:00
Salman Ahmed ec1a7994cc Switch method to statement body for better readability
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
Salman Ahmed 0c125db197 Fix potential nullref on `TestSceneAutoplay` check steps 2022-07-30 10:11:01 +03:00
Salman Ahmed d590219779
Merge pull request #19466 from naipofo/taiko-flashlight-fix
Fix osu!taiko flashlight positioned incorrectly on gameplay restart
2022-07-29 22:05:52 +03:00
Salman Ahmed 1e90ea9e77
Merge branch 'master' into taiko-flashlight-fix 2022-07-29 21:32:35 +03:00
Salman Ahmed 8d1f7970a3
Merge pull request #19465 from peppy/update-framework
Update framework
2022-07-29 21:32:25 +03:00
Salman Ahmed e0107fc3dc Use `RequiredParentSizeToFit` to handle misc geometry changes 2022-07-29 21:11:43 +03:00
NaiPofo 4e32d510c3
Invalidate flashlightProperties on DrawInfo 2022-07-29 20:08:32 +02:00
Dean Herbert eea211eb45 Update framework 2022-07-30 02:46:39 +09:00
Salman Ahmed f79d749fea
Merge pull request #19457 from peppy/fix-summary-kiai-ranges
Fix editor summary timeline not responding to kiai changes correctly
2022-07-29 20:09:45 +03:00
Salman Ahmed 2500e5c533
Merge branch 'master' into fix-summary-kiai-ranges 2022-07-29 19:38:28 +03:00
Salman Ahmed f07a416c4d
Merge pull request #19408 from LeNitrous/pie-chart-progress
Add osu!stable style circular song progress for legacy skins
2022-07-29 17:27:45 +03:00
Dean Herbert acf9ad1429 Apply nullability to `EffectPointVisualisation` 2022-07-29 23:26:38 +09:00
Salman Ahmed 3bc1774c87
Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
Salman Ahmed 3b1a76b190 Remove redundant/overwritten specifications 2022-07-29 16:45:29 +03:00
Salman Ahmed 905bbdc8ee Remove caching of `GameplayClockContainer` in favour of `GameplayClock`
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
Salman Ahmed 3f72e76348 Expose `StartTime` from gameplay clock 2022-07-29 16:18:05 +03:00
Dean Herbert 8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
Dan Balasescu 6703b8df02
Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
Dan Balasescu 70420e6238
Merge pull request #19440 from peppy/bypass-local-metadata-cache
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
Dean Herbert 07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
Dean Herbert 0a2265b0e8 Add test coverage of playlist exit confirmation 2022-07-29 17:11:37 +09:00
Dean Herbert 9d457535c6 Add confirmation dialog when about to discard a playlist
The confirmation will only show if items have been added to the
playlist.

Closes https://github.com/ppy/osu/issues/19444.
2022-07-29 17:11:37 +09:00
Dean Herbert eb92c35335
Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
Dean Herbert cb52b696ed
Merge branch 'master' into bypass-local-metadata-cache 2022-07-29 16:05:54 +09:00
Dean Herbert 2ff6ff06d3 Use tuple to better explain new `bool` parameter 2022-07-29 16:05:41 +09:00
Dean Herbert e07e761c10 Ensure realm is in a good state before asserts in `TestSceneFilterControl` 2022-07-29 15:59:53 +09:00
Dean Herbert be7a9e1487
Merge pull request #19453 from smoogipoo/multiplayer-test-misordering
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:59:51 +09:00
Dan Balasescu aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
Dan Balasescu bc685918b6
Merge pull request #19451 from peppy/dont-wait-spectator-frames
Revert blocking call when sending spectator frames
2022-07-29 14:17:57 +09:00
Dean Herbert fd09155990 Revert blocking call when sending spectator frames
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.

Reverts part of 0533249d11.

Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.
2022-07-29 12:24:54 +09:00
Dean Herbert 45879f7836
Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
Dan Balasescu 0d6b45e515
Merge pull request #19431 from peppy/collections-track-beatmap-updates
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 22:52:54 +09:00
Dean Herbert e664690fe2 Remove unnecessary `LoadTrack` call 2022-07-28 22:19:46 +09:00
Dean Herbert 3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
Dan Balasescu a59d7f6710
Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00