Dean Herbert
f95175983a
Make code more concise and move method to a more appropriate place
2021-03-24 13:37:37 +09:00
Owen Young
c8542d2434
Merge branch 'master' into default-fullscreen
2021-03-23 19:44:22 -05:00
Owen Young
437dadc85f
Changed comment on GetFrameworkConfigDefaults() to be more accurate
2021-03-23 19:37:55 -05:00
Owen Young
67a03ebc23
Fixed formatting issues to be in line with osu coding standards
2021-03-23 19:31:16 -05:00
Owen Young
fbb992fc7e
Added a comment to new method
2021-03-23 19:18:32 -05:00
Dean Herbert
aeff9bd853
Add return bool to HandleRequest to better trigger failures
2021-03-23 18:17:29 +09:00
Dean Herbert
ce452565f4
Avoid firing any kind of failures after success
2021-03-23 17:50:31 +09:00
Dean Herbert
f5ba746ae5
Fail all API requests sent to DummyAPIAccess
...
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.
Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
Dan Balasescu
17a28f4f65
Merge pull request #12136 from peppy/remove-skin-sample-workarounds
...
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
Dan Balasescu
d758343a45
Merge pull request #12149 from peppy/fix-score-token-data-type
...
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
Dean Herbert
1171214541
Update framework
2021-03-23 14:51:22 +09:00
Owen Young
254b0f5dc3
removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :(
2021-03-23 00:24:33 -05:00
Dean Herbert
9c690f9545
Fix second usage
2021-03-23 14:08:00 +09:00
Dean Herbert
58c60100b4
Fix APIScoreToken's data type not matching server side
2021-03-23 14:04:47 +09:00
Owen Young
d9e2c44a34
implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout.
2021-03-22 23:36:55 -05:00
Owen Young
9f788f5854
removed code from OsuGameBase for fullscreen.....OsuSetting still exists but cannot figure out a way to set it to a default and have it actually work
2021-03-22 22:52:16 -05:00
Joehu
16b3f22caf
Fix incorrect trash icon being used on deleted comments counter
2021-03-22 19:32:17 -07:00
Owen Young
bdcb9451f7
added code to OsuGameBase to default to fullscreen, but that might not be a good place to put it.
2021-03-22 20:17:05 -05:00
Owen Young
8ea7271d5c
moved windowmode code to LoadComplete (?)
2021-03-22 19:48:52 -05:00
Owen Young
fc632fd48a
Added WindowSetting setting to OsuSetting enum so that it can be set by default at startup. Modified LayoutSettings.cs so that when it is changed in the settings, it is written to the local settings as well.
2021-03-22 01:30:20 -05:00
Dean Herbert
073dba5330
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-22 14:05:37 +09:00
owen-young
f7bf23dbe9
first attempt at changing windowMode to be fullscreen on default
2021-03-21 21:50:19 -05:00
Joehu
9bc6cdf042
Fix singular format regression on forum post text
2021-03-21 11:19:07 -07:00
Joehu
e31d583a7f
Add comments count to user profile overlay
2021-03-21 11:16:59 -07:00
Bartłomiej Dach
a16c0641b2
Revert EF Core to version 2.2
...
This reverts commit f3faad74d5
, reversing
changes made to 712e7bc7bf
.
Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
Bartłomiej Dach
86b569f5f7
Fix typo in identifier
2021-03-20 12:37:51 +01:00
Bartłomiej Dach
d28bed6ed2
Schedule adding transforms on tablet changes
...
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
Dean Herbert
b9b351311a
Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
...
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
Dean Herbert
ca943a897a
Fix back to front initialisation order
2021-03-20 10:51:58 +09:00
Bartłomiej Dach
dd48b68f8a
Ensure selected blueprints are given selection priority
2021-03-19 22:44:33 +01:00
Dan Balasescu
d54e9ab481
Merge pull request #12077 from peppy/tablet-configuration
...
Add tablet configuration section
2021-03-19 21:49:32 +09:00
Dan Balasescu
5a6ff53837
Merge pull request #12073 from peppy/fix-crash-toggle-overlay-before-loaded
...
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 21:38:47 +09:00
Dan Balasescu
e72205eea2
Merge pull request #12080 from peppy/add-25-playback-editor
...
Change editor speed adjust to adjust frequency (and restore 25% option)
2021-03-19 21:04:12 +09:00
Dean Herbert
68aaf90702
Fix disposal rather than performing some weird hack
2021-03-19 20:30:52 +09:00
Dean Herbert
f59327cc3e
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-19 20:29:44 +09:00
Dean Herbert
b2d8db3a92
Rename incorrect variable
2021-03-19 20:25:21 +09:00
Dean Herbert
63cbac3bd0
Ensure aspect ratio slider gets an initial value
2021-03-19 20:15:29 +09:00
Dean Herbert
6f32c302eb
Add checkbox to optionally disable tablet handling
2021-03-19 20:13:51 +09:00
Dan Balasescu
4da9089b00
Merge branch 'master' into tablet-configuration
2021-03-19 20:09:25 +09:00
Dean Herbert
095b7f8668
Rewrite code to account for non-loaded edge case
2021-03-19 20:09:12 +09:00
Dean Herbert
4795170c60
Add back the default json converter locally to ensure it's actually used
2021-03-19 20:07:13 +09:00
Dean Herbert
86b229b1c9
Increase maximum usable aspect ratio to account for ultrawide monitors
2021-03-19 20:05:18 +09:00
Dean Herbert
8955071703
Change editor speed adjust to adjust frequency
2021-03-19 20:01:45 +09:00
Dean Herbert
9be7981e0d
Adjust timeline ticks to be more visible
2021-03-19 19:45:00 +09:00
Dean Herbert
c0c8b3e46c
Fix regression meaning SkinnableSound
initialisation may never happen
2021-03-19 19:22:50 +09:00
Dean Herbert
bd1e2da1c2
Always hide other overlays, even if the new one is not loaded
2021-03-19 19:09:39 +09:00
Dan Balasescu
0736679016
Merge pull request #12072 from peppy/include-default-skin-in-random-rotation
...
Include the bundled skins when selecting a random skin
2021-03-19 19:08:42 +09:00
Dean Herbert
baf4e4e8f6
Merge branch 'master' into tablet-configuration
2021-03-19 19:06:58 +09:00
Dean Herbert
fefb007805
Remove no longer relevant comment
2021-03-19 19:01:32 +09:00
Dean Herbert
1e82033c84
Move bindings to LoadComplete to avoid cross-thread issues
2021-03-19 19:01:32 +09:00