RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
62,891 Commits 3 Branches 650 Tags 350 MiB
Commit Graph

62891 Commits

Author SHA1 Message Date
Bartłomiej Dach e1d52134ae
Merge pull request #24930 from peppy/adjust-mania-barlines 
Adjust osu!mania "major" barlines to be less visually distracting
 2023-09-26 19:39:22 +02:00
Dean Herbert b9c9cba6d5
Merge pull request #24935 from bdach/fix-flaky-editor-beatmap-creation-test 
Fix flaky editor beatmap creation test
 2023-09-27 01:09:01 +09:00
Bartłomiej Dach 12585c9f27
Fix flaky editor beatmap creation test 
Came up as a failure when locally running tests for
ppy/osu-framework#6001 - but the test is actually a previously-known
flaky that I couldn't reproduce the failure of until the aforementioned
PR.

This appears to be a simple race; the test scene queries the track
length from update thread, but the length is actually set on the audio
thread. So it's not unreasonable that given unlucky timing, the length
will not be set by `TrackBass` before it is queried.

To fix, switch assert to until step. I'm generally not really willing
to give this more time of day until this change is proven insufficient.
 2023-09-26 16:42:59 +02:00
Dean Herbert 9d8c3f0f5c
Merge pull request #24779 from smoogipoo/split-legacy-scoring-attribs 
Split legacy scoring attribs into its own table
 2023-09-26 22:35:38 +09:00
Dan Balasescu 05c9f0f9cc Fix bonus requirement not considering number of normal ticks 2023-09-26 18:11:27 +09:00
Dan Balasescu 19a442a32a Fix incorrect change in taiko score simulator 2023-09-26 17:46:03 +09:00
Dean Herbert 40a548d372 Adjust new test scene to not be super broken 2023-09-26 17:30:49 +09:00
Dan Balasescu 859155dda1 Cap maximum spinner RPM based on OD 2023-09-26 17:20:20 +09:00
Dean Herbert 3b85a636b2
Merge pull request #24706 from frenzibyte/limit-gameplay-sprite-dimensions 
Add maximum dimensions limit to skinnable gameplay elements
 2023-09-26 17:15:55 +09:00
Dean Herbert 9949480ccd Add minor edge smoothing to fix flickering of barlines 
In most cases.

Closes https://github.com/ppy/osu/issues/15184.
 2023-09-26 17:06:52 +09:00
Dean Herbert 5150c5a643 Adjust osu!mania "major" barlines to be less visually distracting 
Applies to both "triangles" and "argon" skins.
 2023-09-26 17:06:27 +09:00
Dean Herbert 990c54519b
Merge branch 'master' into limit-gameplay-sprite-dimensions 2023-09-26 16:40:32 +09:00
Dean Herbert b1561b650f Rename test scene, add xmldoc and increase scale factor to something absurdly high 2023-09-26 16:39:36 +09:00
Dean Herbert ae31a8fadf Reduce delay before loading beatmap after selection change at song select 
This was originally set high because of performance concerns. We have
since improved things quite drastically. Even with a very low debounce
my song select is amazingly smooth.

This is about as low as we can got unless we want chaos when key
repeating left/right arrows (it's not as bad as you think, maybe worth
testing during review and see if it feels more expected?).

Of note, stable has key repeat disabled on left/right arrows and zero
debounce.

Addresses concerns in https://github.com/ppy/osu/discussions/24916.
 2023-09-26 16:21:09 +09:00
Dean Herbert 0dcf7a2fa9
Merge branch 'master' into split-legacy-scoring-attribs 2023-09-26 15:52:27 +09:00
Dean Herbert d1d82d2b49 Improve notification display when score import fails 2023-09-26 15:00:56 +09:00
Dean Herbert 567bc8fcd3 Ensure `DrawableStoryboardSprite`'s texture size propagates corectly on skin change 2023-09-26 14:13:51 +09:00
Dean Herbert 2ca1c684bb
Merge branch 'master' into fix-storyboard-skin-textures-lookup 2023-09-26 14:05:27 +09:00
Bartłomiej Dach 72c61c3a6a
Update osu! scoring tests to match updated formulae 2023-09-25 19:16:31 +02:00
Bartłomiej Dach 57c00e728b
Update classic scoring algorithm to closer match stable score V1 2023-09-25 19:16:18 +02:00
Fabian van Oeffelt 2040dcabe0 Improve Code Quality 2023-09-25 17:51:39 +02:00
Fabian van Oeffelt 2a3391d83b Remove unused namepace 2023-09-25 16:56:34 +02:00
Fabian van Oeffelt 59d3143645 Fix SR/BPM Display in Playlist rooms 2023-09-25 16:53:40 +02:00
Dan Balasescu 81130eacd1
Merge pull request #24897 from peppy/fix-oauth-refresh-no-connection 
Fix OAuth refresh attempt when no network available causing full logout
 2023-09-24 14:06:04 +09:00
Dean Herbert 3c62521e69 Fix OAuth refresh attempt when no network available causing full logout 2023-09-24 10:50:07 +09:00
Salman Ahmed 7d7fc09dbc
Merge pull request #24889 from Fabiano1337/master 
Fix game crash when using "Bubbles" mod on a beatmap with no hit circles
 2023-09-24 03:02:10 +03:00
Salman Ahmed 734ee0e68b Simplify code 2023-09-24 02:22:50 +03:00
Fabian van Oeffelt 7c40072c47 Get first Spinner,Slider or HitCircle instead of only HitCircle 
Fixes bug
 2023-09-23 13:18:49 +02:00
Dean Herbert d019cb5167 Update in line with framed clock changes 2023-09-22 22:02:18 +09:00
Dean Herbert 251a85db43 Fix `StopUsingBeatmapClock` not transferring time and running state 2023-09-22 16:22:36 +09:00
Dean Herbert faa0481fc6 Fix editor operating directly on track rather than decoupled clock 2023-09-22 16:22:36 +09:00
Dean Herbert c40bd74138 Update usages of `GameplayClockContainer` not using an adjustable source 2023-09-22 16:22:36 +09:00
Dean Herbert a3e4d19933 Update tests which were not using an `IAdjustableClock` as `GameplayClockContainer` source 2023-09-22 16:22:36 +09:00
Dean Herbert 8367bb6bee Don't apply decoupling to `SpectatorPlayerClock`s 
See inline comment for reasoning. It's a bit complicated.
 2023-09-22 16:22:35 +09:00
Dean Herbert 6629a47ed3 Fix `FramedBeatmapClock`'s source not being processed 2023-09-22 16:22:35 +09:00
Dean Herbert 3cb928fe6f Add note about test not calling `ProcessFrame` 2023-09-22 16:22:35 +09:00
Dean Herbert bf08fbe196 Set source directly in `FramedBeatmapClock` ctor 
This isn't required, but avoids creating a temporary `StopwatchClock`
and generally just makes debug easier with less state changes.
 2023-09-22 16:22:35 +09:00
Dean Herbert 586311d508 Fix souce clock not always being transferred to `FramedBeatmapClock` in time 2023-09-22 16:22:35 +09:00
Dean Herbert 59d6e67512 Add missing `TestManualClock.Reset` implementation for safe measure 2023-09-22 16:22:35 +09:00
Dean Herbert 0200b63fd3 Add note about beatmap offset not being reapplied correctly on `ChangeSource` 2023-09-22 14:41:07 +09:00
Dean Herbert a1e298930c Remove second hopefully-unnecessary workaround 2023-09-22 14:41:07 +09:00
Dean Herbert a451ab75dd Remove hopefully-unnecessary workaround 
It was causing issues with the new implementation.
 2023-09-22 14:41:05 +09:00
Dean Herbert df08c4e1ad Disable decoupling for `OsuGameBase`'s beatmap implementation 
This avoids it ever mutating the underlying track (aka attempting to start
it). Resolves the one caveat mentioned in
aeef92fa710648d4a00edc523e13c17ac6104125.
 2023-09-22 12:49:25 +09:00
Dean Herbert 5f634f2812 Remove unnecessary encapsulation workaround 
The new implementation of `DecouplingClock` will not mutate the
underlying clock in any way (unless attempting to start it when
approaching from a negative time value).

This should be quite safe as a result.
 2023-09-22 12:49:25 +09:00
Dean Herbert 21a2e27e5f Simplify some pieces of `FramedBeatmapClock` 2023-09-22 12:49:25 +09:00
Dean Herbert 04e6ec8715 Fix interpolation not being applied when `applyOffsets` is set 2023-09-22 12:49:25 +09:00
Dean Herbert 117cd74af6 Update usage of `DecoupleableInterpolatingFramedClock` in `FramedBeatmapClock` 2023-09-22 12:49:25 +09:00
Dean Herbert 3f27be1f33 Replace most usages of `DecoupleableInterpolatingFramedClock` 
Except `FramedBeatmapClock`, which is the high-effort one.
 2023-09-22 12:49:25 +09:00
Dean Herbert 600651795b Change `FramedBeatmapClock` to always be decoupled 2023-09-22 12:49:25 +09:00
Salman Ahmed d18bd2d2ac
Merge pull request #24880 from bdach/flaky-scoreboard-test 
Fix `TestFriendScore` intermittently failing due to randomness
 2023-09-22 02:09:04 +03:00