Commit Graph

60 Commits

Author SHA1 Message Date
Bartłomiej Dach a407e267a2 Fix PF/SD legacy mod conversion
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
Dean Herbert a15828ab25 Introduce the concept of SkinComponents
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
smoogipoo 6ab2b20c70 Add an interface for working beatmaps 2019-08-29 19:38:44 +09:00
smoogipoo 8a64ab0384 Remove generics from IApplicableToBeatmap 2019-08-01 12:39:32 +09:00
smoogipoo d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
smoogipoo 0222424aef Make mods IReadOnlyList<Mod> gamewide
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
smoogipoo c584967eb1 Remove mods from workingbeatmap 2019-04-09 12:59:32 +09:00
Dean Herbert c39c37a18d Apply more missed cases 2019-04-01 12:44:46 +09:00
Dean Herbert de80fc0eac Update icon usage to match framework changes 2019-03-27 19:29:27 +09:00
Dean Herbert baea7230bc Rename RulesetContainer to DrawableRuleset 2019-03-19 23:47:31 +09:00
LeNitrous c271a3a781 remove ruleset specific mods 2019-03-04 17:36:44 +08:00
LeNitrous c6e26a92ec add wind up and wind down mods 2019-01-26 12:15:45 +08:00
Dean Herbert 8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
Dean Herbert 831cd3ed59 ScoreInfo scoreInfo -> ScoreInfo score 2018-11-30 15:18:52 +09:00
smoogipoo 219929eb47 Score -> ScoreInfo 2018-11-28 18:33:01 +09:00
smoogipoo 09b79d736b Remove unused usings 2018-11-28 16:33:42 +09:00
smoogipoo 5fd6e6ca77 Re-namespacing 2018-11-28 16:12:57 +09:00
Dean Herbert 3c06655672 Split out Special mods into Automation and Conversion 2018-07-31 18:00:42 +09:00
Dean Herbert 566d125658 Change order of default initialisation to look better in settings 2018-06-21 14:28:40 +09:00
Tom Arrow d753df65a5 Remove default bindings for right actions 2018-06-19 18:04:53 +02:00
smoogipoo 8f7334874c Fix up performance calculators 2018-06-14 16:04:48 +09:00
smoogipoo 33c7ce1bec Adjust TaikoDifficultyCalculator in-line with changes 2018-06-14 15:47:42 +09:00
Joehu b182635aae Fix taiko nightcore regression 2018-06-12 20:21:37 -07:00
smoogipoo 83ff47ec80 Rewrite difficulty mod combinations 2018-06-06 16:20:17 +09:00
smoogipoo 8274623ad6 Cleanup multi mod constructions 2018-06-06 14:07:50 +09:00
smoogipoo 2ccffb9ac4 Add difficulty calculation mod types 2018-06-03 10:59:56 +09:00
smoogipoo 3091d3a014 Implement the taiko performance calculator 2018-05-17 17:56:44 +09:00
smoogipoo 450d54eea9 Fix taiko difficulty calculator never considering mods 2018-05-17 17:56:37 +09:00
smoogipoo 803200ff6a Apply similar changes to other rulesets 2018-05-15 17:40:19 +09:00
smoogipoo 995fda9b6f Move base classes to osu.Game.Rulesets.Difficulty namespace 2018-05-15 17:38:08 +09:00
smoogipoo 4ecdea8b2e Remove now-unnecessary IsForCurrentRuleset property of RulesetContainer 2018-05-07 10:17:54 +09:00
smoogipoo 03a5df84c6 Initial rework of beatmap conversion process 2018-04-19 22:04:12 +09:00
smoogipoo 66b3b295e7 Use IBeatmap wherever possible 2018-04-19 20:44:38 +09:00
tgi74000 9b36cf2066 Review changes 2018-04-16 14:14:40 +02:00
tgi74000 b23b0a445b Add support for replay mods 2018-04-13 15:41:35 +02:00
Dean Herbert 32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
Dean Herbert e82cadc811 Make LegacyID nullable
The -1 default was getting stored to the database.
2018-03-06 17:40:14 +09:00
smoogipoo c9c65cab53 CreateReplayFrame -> CreateConvertibleReplayFrame 2018-03-01 02:28:14 +09:00
smoogipoo 222ae70062 Populate rulesets with their replay frames 2018-03-01 02:28:14 +09:00
Dean Herbert 58626e3b30 Allow rulesets to create their own instantiation info 2018-01-10 17:04:07 +09:00
Dean Herbert 37d393bca0 Update licence headers 2018-01-05 20:21:19 +09:00
Dean Herbert 679134c030 Add ShortName to rulesets 2017-12-08 18:55:25 +09:00
smoogipoo 62155e6dd5 Make DifficultyCalculator support mod applications
Fixes https://github.com/ppy/osu/issues/476.
2017-11-17 12:36:07 +09:00
smoogipooo 5e32d95ad2 Remove Ruleset's CreateScoreProcessor method 2017-09-13 16:37:05 +09:00
MrTheMake a7f874e5b6 Merge branch 'master' into leaderboard-scores 2017-09-07 18:25:33 +02:00
Dean Herbert 16e96888ab Update KeyCounterCollection to support action-based buttons 2017-08-21 12:39:22 +09:00
Dean Herbert 325eaa8671 Add mouse buttons defaults for taiko 2017-08-20 22:26:33 +09:00
Dean Herbert a18b2bd5f0 Hook everything up 2017-08-20 22:21:16 +09:00
Dean Herbert ec08b2940d Add taiko default keys 2017-08-20 21:56:37 +09:00
MrTheMake 81289db33b CI fix, fixed nullref and removed abstraction of GetAutoplayMod 2017-08-13 20:12:01 +02:00