Commit Graph

1210 Commits

Author SHA1 Message Date
Dean Herbert fb7f9a81db Remove unnecessary equality check in skin editor construction path 2022-03-22 14:35:13 +09:00
Dean Herbert 9a2691c1bc Remove unnecessary schedule 2022-03-21 23:54:47 +09:00
Salman Ahmed 33acc5d720 Remove no longer valid comments 2022-03-21 14:06:53 +03:00
Salman Ahmed 058fbbbe6c Remove unused using directive 2022-03-21 14:06:36 +03:00
Dean Herbert 2a696783af Remove unused const in `SkinEditorOverlay` 2022-03-21 17:33:56 +09:00
Dean Herbert 2f18c512cd Convert `SkinEditorOverlay` to an `OverlayContainer` to allow it to block input 2022-03-21 17:33:56 +09:00
Dean Herbert 3643f879e4 Add test coverage of skin editor settings slider not working via keyboard adjustments 2022-03-21 17:33:56 +09:00
Dean Herbert 355b0fa314 Fix loading player via skin editor still allowing changing current audio track
`PlayerLoader` is required in the sequence to get the game into the
correct state for gameplay right now. Applying ths simplest fix here.

Closes https://github.com/ppy/osu/issues/17351.
2022-03-21 13:49:56 +09:00
Dean Herbert 806a16d8f6 Fix `SkinComponentToolbox` attempting to create instances of abstract classes 2022-03-18 20:13:15 +09:00
Dean Herbert e252f1a3cd Add explanation about try-catch logic in `SkinComponentToolbox` 2022-03-17 18:40:26 +09:00
Dean Herbert 1d83b36cfc Merge branch 'master' into skin-editor-borrowed-dependencies 2022-03-17 15:09:04 +09:00
Dan Balasescu e3cbde5099
Merge pull request #17282 from peppy/skin-editor-reset-position
Add "Reset position" menu item in skin editor
2022-03-17 14:20:24 +09:00
Dan Balasescu 1eac0f41bf
Remove unused using 2022-03-17 13:44:54 +09:00
Dan Balasescu 07433d0540
Merge pull request #17278 from peppy/skin-editor-multiple-component-settings
Show settings for multiple skin components in a selection
2022-03-17 13:43:59 +09:00
Dean Herbert 6df36171b5 Merge branch 'master' into skin-editor-toolbox-ui 2022-03-16 22:21:10 +09:00
Dean Herbert 7e52623645 Add "Reset position" menu item in skin editor 2022-03-16 20:02:52 +09:00
Dean Herbert cc356bcfe4 Show components available for current screen only (using actual live dependencies) 2022-03-16 19:42:00 +09:00
Dean Herbert b07ca87965 Merge branch 'skin-editor-toolbox-ui' into skin-editor-borrowed-dependencies 2022-03-16 19:38:28 +09:00
Dean Herbert 27122c17c9 Show settings for multiple components in a selection 2022-03-16 19:35:45 +09:00
Dean Herbert 54e351efe9 Convert top level skin editor layout to use grid container
Fix `SkinEditor`'s initial target not being a `Screen`
2022-03-16 19:30:51 +09:00
Dean Herbert 4525ed645c Update skin editor to use `EditorSidebar` 2022-03-16 19:30:51 +09:00
Dean Herbert 59cb1ac126 Order components by name for now 2022-03-16 19:21:15 +09:00
Dean Herbert e4a6b7ae91 Expand toolbox component items on hover 2022-03-16 19:21:15 +09:00
Dean Herbert fdb411c0f3 Update skin editor toolbox design to suck less 2022-03-16 19:21:15 +09:00
Dean Herbert b08d4bb8eb Move `SceneLibrary` implementation to its own file 2022-03-16 19:13:52 +09:00
Dean Herbert ee3715f5cf Use `OverlayColourProvider` and adjust metrics to roughly match new designs 2022-03-16 19:13:52 +09:00
Dean Herbert aff6a5a428 Better align scene selector with menu bar 2022-03-16 19:13:52 +09:00
Dean Herbert c6aa32a003 Add basic song select setup for skinnability 2022-03-16 19:12:06 +09:00
Dean Herbert 8d85723a62 Split out `SceneLibrary` into its own component 2022-03-16 19:12:06 +09:00
Dean Herbert d062810ff2 Add basic scene selector 2022-03-16 19:12:06 +09:00
Dean Herbert c807ad7e4e Ensure toolbar is hidden even when the active screen is changed while the editor is open 2022-03-16 19:11:22 +09:00
Dean Herbert 86960c791f Close overlays and toolbar on entering the skin editor 2022-03-16 19:00:23 +09:00
Dean Herbert 99e3161cf0 Fix `SkinEditor`'s initial target not being a `Screen` 2022-03-16 18:57:47 +09:00
Dan Balasescu d80830b415
Merge pull request #17226 from peppy/skin-component-settings
Allow skin components to have settings
2022-03-16 17:12:11 +09:00
Dean Herbert 2b02a6555b Remove current screen check from skin editor changes 2022-03-15 15:40:26 +09:00
Dean Herbert 6d5692fcec
Fix typo in setting name
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-15 14:25:05 +09:00
Dean Herbert 6fb06d69cc
Merge branch 'master' into pp-counter-alloc-reduction 2022-03-15 13:31:57 +09:00
Dan Balasescu ca62560495 Resolve inspections 2022-03-15 09:20:32 +09:00
Dan Balasescu e79bed8fbe Merge branch 'master' into skin-component-settings 2022-03-14 18:54:27 +09:00
Dan Balasescu fd93b42630
Merge pull request #17217 from peppy/skin-editor-reload-on-scene-change
Refactor `SkinEditor` to support switching target screens without full reload
2022-03-14 18:02:01 +09:00
Dean Herbert 3c5fda5f23 Add early exist if the target screen is no longer current 2022-03-14 17:24:31 +09:00
Dan Balasescu 3fff7f4b7e Require ScoreProcessor to receive ruleset 2022-03-14 15:51:10 +09:00
Dean Herbert 7d2752185d Add disclaimer and adjust metrics of `BigBlackBox` 2022-03-13 17:03:25 +09:00
Dean Herbert e4211104b0 Add new settings to the big black box 2022-03-13 17:03:25 +09:00
Dean Herbert 458136dfe7 Add `BigBlackBox` for skinning testing purposes 2022-03-13 17:03:25 +09:00
Dean Herbert 8d1ee28e67 Add settings modification UI to skin editor 2022-03-13 17:03:25 +09:00
Dean Herbert c99397f75a Add the ability to add settings to skinnable elements 2022-03-13 17:03:25 +09:00
Dean Herbert 7a2a3528ef Merge branch 'skin-editor-reload-on-scene-change' into skin-component-settings 2022-03-13 17:03:23 +09:00
Dean Herbert f95e753adb Rename double-container variable name 2022-03-13 16:10:06 +09:00
Dean Herbert d1a9b88fe7
Fix typo in comment
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-03-13 16:05:45 +09:00