Commit Graph

50793 Commits

Author SHA1 Message Date
Dan Balasescu dc0f1a9419
Merge pull request #17979 from peppy/first-run-show-get-started
Improve displayed text on first run setup back/next buttons
2022-04-26 17:04:03 +09:00
Dean Herbert a078440012 Show last step on back button as well 2022-04-26 16:03:17 +09:00
Dean Herbert 37ae39f5fe Move "Next" localisation to common strings 2022-04-26 15:48:40 +09:00
Dan Balasescu 9d198ad6bb
Merge pull request #17972 from peppy/hotfix-context-menu
Fix windows taskbar context menu not popping up correctly
2022-04-26 13:52:02 +09:00
Dan Balasescu 9911584fe1
Merge pull request #17977 from peppy/show-during-gameplay-improvement
Change conditions for HUD being shown to include pause/fail states
2022-04-26 12:55:31 +09:00
Dean Herbert 8ab3636f87 Change conditions for HUD being shown to include pause/fail states
As proposed in https://github.com/ppy/osu/discussions/17975. Feels pretty good to me, and probably how it should have been implemented from the start.
2022-04-26 12:09:21 +09:00
Dean Herbert d310886c26 Add test coverage of `IsPlaying` state during fail and pause 2022-04-26 12:09:18 +09:00
Dan Balasescu 51b4821efa
Merge pull request #17976 from frenzibyte/improve-score-grading
Change score accuracy grading logic to be inclusive
2022-04-26 12:06:58 +09:00
Salman Ahmed 7d32490198 Change score accuracy grading logic to be inclusive 2022-04-26 04:55:27 +03:00
Salman Ahmed f958010d29 Fix `AccuracyCircle` storing accuracy values in `float` 2022-04-26 04:52:48 +03:00
Dean Herbert 5e48b37569 Show "Get Started" text on first run button 2022-04-25 23:59:07 +09:00
Dean Herbert ed894d6428
Merge pull request #17941 from frenzibyte/remove-legacy-skin-fallback
Handle all legacy skin component types explicitly and remove texture fallback
2022-04-25 21:55:05 +09:00
Dean Herbert 3284a464a9
Merge pull request #17952 from frenzibyte/scene-library-incompatible-mods
Deselect mods incompatible with "Autoplay" when entering gameplay via scene library
2022-04-25 19:56:50 +09:00
Dean Herbert d2780c2c50 Add a touch more detail to the unsupported skin component exception 2022-04-25 19:06:47 +09:00
Dean Herbert 7ac3ba132c Remove unused using statements 2022-04-25 18:55:12 +09:00
Dean Herbert a0e80cf901 Merge branch 'master' into scene-library-incompatible-mods 2022-04-25 18:54:40 +09:00
Dean Herbert 7e9d51f33f Fix windows taskbar context menu not popping up correctly
Closes https://github.com/ppy/osu/issues/17965.

Note that this will cause a second osu! icon to appear after running the
application (after any update). As per the inline comment, this will
eventually be resolved via https://github.com/clowd/Clowd.Squirrel/issues/24.

I do think having context menus working is more important than duplicate
icons.

Note that for anyone who already has a pinned taskbar icon, it will need
to be manually unpinned and repinned after a future update to actually
fix this issue.

Thanks to @caesay for help with investigation.
2022-04-25 18:37:41 +09:00
Dean Herbert 2d1cc2e5ea
Merge pull request #17962 from peppy/fix-scroll-container-regressions
Fix context menus not working
2022-04-24 22:38:43 +09:00
Dean Herbert 51aa17eb52 Fix context menus not working 2022-04-24 22:17:38 +09:00
Dean Herbert 07462384e8
Merge pull request #17930 from peppy/fix-song-select-music-control
Fix nested song select in first-run dialog fiddling with global audio
2022-04-24 19:18:27 +09:00
Dean Herbert d92c905600 Actually use exposed property 2022-04-24 18:15:35 +09:00
Dean Herbert 21665f605a
Merge pull request #17937 from frenzibyte/settings-filter-regression-fix-2
Fix settings overlay components not invalidating presence on filter change
2022-04-24 18:12:34 +09:00
Dean Herbert 83970f009c
Merge branch 'master' into settings-filter-regression-fix-2 2022-04-24 17:40:25 +09:00
Dean Herbert 176d263252
Merge pull request #17942 from maromalo/master
Add joystick/gamepad deadzone setting
2022-04-24 17:39:48 +09:00
Dean Herbert c5e8f1d4ab
Merge pull request #17958 from peppy/fix-hide-case
Remove localisation of "hide" string to fix incorrect case
2022-04-24 17:38:49 +09:00
Dean Herbert 60f513abd9
Merge pull request #17957 from peppy/disable-first-run-temporary
Disable first run screen from appearing on startup until it is more complete
2022-04-24 17:37:17 +09:00
Dean Herbert d0fee3c212
Merge pull request #17950 from Susko3/ButtonSystem-keys
Allow any key to trigger the osu! cookie in the initial state
2022-04-24 17:30:22 +09:00
Dean Herbert 66b47d22d7 Also fix case of login form username/password 2022-04-24 17:11:25 +09:00
Dean Herbert 999b4505d1 Remove localisation of "hide" string to fix incorrect case 2022-04-24 16:37:11 +09:00
Dean Herbert 1b2467d3ed Disable first run screen from appearing on startup until it is more complete 2022-04-24 16:35:41 +09:00
Dean Herbert 2200067c52 Display deadzone as percentage and simplify surrounding code 2022-04-24 16:31:20 +09:00
Dean Herbert a40d140353
Merge pull request #17956 from frenzibyte/sections-container-pagination
Fix page up / down in `SectionsContainer` with fixed header skipping content
2022-04-24 15:36:35 +09:00
Salman Ahmed 3700c607d8 Fix sections scroll container not handling fixed header in scrolls 2022-04-24 01:52:13 +03:00
Salman Ahmed 05736fb84c Add failing test case for navigation via PageUp/PageDown 2022-04-24 01:52:11 +03:00
Salman Ahmed e8cf4466b0 Make sections container test scene more usable
Head busted the moment I opened this test scene.

Cleaned it up a bit to make it easier to test changes.
2022-04-24 01:52:10 +03:00
Salman Ahmed 0ecda46d93 Deselect mods incompatible with "Autoplay" when entering gameplay via scene library 2022-04-23 23:16:33 +03:00
Salman Ahmed 60e76d62c1 Add failing test cases 2022-04-23 23:16:06 +03:00
Salman Ahmed 6ab188f8f9 Split skin editor scene library test to own file
Rather than stuffing more random cases to `TestSceneScreenNavigation`.
2022-04-23 23:15:45 +03:00
Salman Ahmed daadc3fc21 Simplfiy and share notification dimsiss method across test scenes
Might as well inline, but I feel like it will require adding the same
comment across all usages, because just `State.Value = Hidden` in an
until step feels off, dunno.
2022-04-23 23:14:19 +03:00
Susko3 684d88ba75 Add full OsuGame tests
These tests ensure the expected behaviour is not broken in the future.
2022-04-23 19:01:55 +02:00
Susko3 cdfef08846 Add tests for shortcut keys 2022-04-23 18:44:50 +02:00
Susko3 e89441951c Allow any key to trigger the initial osu! cookie 2022-04-23 18:33:43 +02:00
maromalo 5addcbf460 Changed KeyboardStep to 0.01 2022-04-23 13:16:20 -03:00
Salman Ahmed 4bf11df57c Change `SpriteComponent` accessibility to `internal` 2022-04-23 19:11:54 +03:00
maromalo 0133ee962d
Change JoystickSettingsStrings.cs text
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-04-23 02:23:07 -03:00
maromalo 6a87dfdabb More Code Quality
Double whoops.
2022-04-23 02:14:41 -03:00
maromalo 23ef1e194d Code Quality
Whoops.
2022-04-23 01:52:59 -03:00
Dean Herbert 99f276a570 Update framework 2022-04-23 13:30:23 +09:00
maromalo 85c47e1ba7
Merge branch 'ppy:master' into master 2022-04-23 00:17:40 -03:00
maromalo 27f3499330 Add joystick/gamepad deadzone setting
Also splits joystick/gamepad into a new sub-section.
2022-04-23 00:17:00 -03:00