Commit Graph

62794 Commits

Author SHA1 Message Date
Dean Herbert d87ab9c82d
Adjust transition time based on miss/hit 2023-10-06 19:34:38 +09:00
Dean Herbert 3f2a00d90d
Add argon health display to default skin layout 2023-10-06 19:34:27 +09:00
Dean Herbert 71be3c8f8b
Add ability to adjust health bar settings in test scene 2023-10-06 19:34:27 +09:00
Dean Herbert f40e910c51
Remove left line from health display 2023-10-06 19:34:27 +09:00
Dean Herbert db5178e453
Change `ArgonHealthDisplay` to be relative sized for now 2023-10-06 18:56:39 +09:00
Dean Herbert cc6210035f
Merge pull request #25023 from bdach/skinning-max-size-update
Adjust gameplay element maximum size limits for backwards compatibility
2023-10-06 14:37:15 +09:00
Bartłomiej Dach 96bb8ed150
Apply feedback regarding maximum osu! element sizings
- `default-N` number sprites maximum size increased by 1.25x to a total
  of 320x320 to counteract the 0.8x factor applied onto them when
  displayed on a hitcircle.

- `sliderb` and parts' maximum size increased to 384x384, to match
  `sliderfollowcircle`, as the two are apparently sometimes used
  interchangeably by skinners to achieve different visual effects.
2023-10-05 22:33:49 +02:00
Bartłomiej Dach 0ae4a0f11f
Adjust gameplay element maximum size limits for backwards compatibility
The new limits were chosen by sampling across over 4000 skins. The
methodology for doing so is described in the following gist:

	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3
2023-10-05 20:37:10 +02:00
Bartłomiej Dach 4d315cb718
Merge pull request #25016 from peppy/fix-waveform-comparison-crash
Fix `WaveformComparisonDisplay` potentially crashing on invalid track length
2023-10-05 20:02:44 +02:00
Dean Herbert 9649cc865d
Merge pull request #25013 from smoogipoo/new-diffcalc-workflow
Add new GitHub Actions diffcalc spreadsheet generator workflow
2023-10-05 23:57:20 +09:00
Dean Herbert d034a3c45d
Merge pull request #25010 from bdach/swell-cheesing
Allow judging at most one swell tick per frame
2023-10-05 23:50:38 +09:00
Dean Herbert c66423279c
Merge branch 'master' into swell-cheesing 2023-10-05 23:08:21 +09:00
Dean Herbert d660395850
Ensure there's no chance of a press being ignored during rewind flow 2023-10-05 23:02:45 +09:00
Dean Herbert 61fd4186af
Ensure `regenerateDisplay` is eventually performed if originally called before load 2023-10-05 22:55:23 +09:00
Bartłomiej Dach b0176dcbf7
Merge pull request #24975 from frenzibyte/crop-gameplay-textures
Crop oversized gameplay textures instead of downscaling them
2023-10-05 10:41:40 +02:00
Bartłomiej Dach c195fbe76f
Merge branch 'master' into crop-gameplay-textures 2023-10-05 09:35:58 +02:00
Bartłomiej Dach 0f7093cb22
Merge pull request #25015 from peppy/fix-intermittent-test-failure
Fix `TestReplayExport` intermittent failure
2023-10-05 08:17:42 +02:00
Dean Herbert 76cc2f9f22
Fix `WaveformComparisonDisplay` potentially crashing on invalid track length
As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.
2023-10-05 14:58:55 +09:00
Dean Herbert 5a0faaa0b1
Fix `TestReplayExport` intermittent failure
The previous fix was not working as it was checking the path for the
prefix `_`, not the filename.

See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows
this.
2023-10-05 14:30:06 +09:00
Dan Balasescu 2e0ca45773 Remove duplicated usage instructions 2023-10-05 14:09:58 +09:00
Dan Balasescu bca257eeda Add description 2023-10-05 13:32:20 +09:00
Dan Balasescu 9f350ce13c Add new difficulty calculation github action 2023-10-05 13:20:07 +09:00
Bartłomiej Dach a1368df62f
Allow judging at most one swell tick per frame 2023-10-04 19:08:03 +02:00
Bartłomiej Dach 2ae1a24355
Add failing test covering counting multiple swell hits per frame 2023-10-04 19:08:02 +02:00
Bartłomiej Dach 66824ce8ca
Merge pull request #25006 from smoogipoo/fix-spinner-precision
Fix spinner requirements being susceptible to FP precision
2023-10-04 10:03:49 +02:00
Dan Balasescu 48209872bf Fix spinner requirements being susceptible to FP precision 2023-10-04 13:53:33 +09:00
Dean Herbert 72cbc3b9cf
Merge pull request #24965 from peppy/legacy-tick-not-so-legacy-after-all
Tidy up `LegacyLastTickOffset` usages and stop passing everywhere
2023-10-04 11:42:32 +09:00
Dan Balasescu 854b797ab5
Merge branch 'master' into legacy-tick-not-so-legacy-after-all 2023-10-04 10:52:13 +09:00
Bartłomiej Dach 844a3b6c1b
Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display
Implement redesigned health bar display for "Argon" skin
2023-10-03 11:26:21 +02:00
Bartłomiej Dach 9c1f5c35d6
Merge pull request #24990 from peppy/argon-better-reverse
Add edge highlight to "argon" slider repeat arrow (and improve all skins' reverse arrow animations)
2023-10-03 10:55:11 +02:00
Dean Herbert 4f3c433946 Move vertex related constants local to method 2023-10-03 17:41:52 +09:00
Dean Herbert 32b2ac4974 Rename and refactor glow/miss bars to hopefully make more sense 2023-10-03 17:41:11 +09:00
Dean Herbert 4f9daa1c14 Tidy up `ArgonHealthDisplay` code quality 2023-10-03 17:32:35 +09:00
Dean Herbert e1445fcc65 Adjust health display test scene's background colour to better visualise background fill 2023-10-03 17:17:42 +09:00
Dean Herbert 8178cf3a8d Tidy up background colour gradient logic
This changes things visually a touch, but I think it feels better.
And reads better.
2023-10-03 17:17:11 +09:00
Dean Herbert 2cbec6dbdf Update resources 2023-10-03 17:11:52 +09:00
Bartłomiej Dach 5338ba98f0
Merge pull request #24998 from peppy/better-nested-path-beatmap-import
Fix legacy beatmap importer not always handling nested paths correctly
2023-10-03 09:43:02 +02:00
Dean Herbert b234a453da Fix legacy beatmap importer not always handling nested paths correctly
Addresses https://github.com/ppy/osu/discussions/24989.
2023-10-03 16:01:17 +09:00
Dean Herbert 16fcc4eaaa Fix incorrect anchor/origin causing rotation to look wrong on legacy skin arrows 2023-10-03 12:32:52 +09:00
Dean Herbert 3aa51301e8 Add null checks in disposal flow 2023-10-02 22:28:33 +09:00
Dean Herbert 94e49a34fd Adjust legacy reverse arrow implementation to match stable more closely 2023-10-02 22:26:57 +09:00
Dean Herbert f0070eecf1 Add rotation support for very old skins 2023-10-02 20:09:39 +09:00
Dean Herbert 1bee7bf353 Add note about rotation 2023-10-02 19:22:24 +09:00
Dean Herbert e4ac8362ec Update other implementations to use non-beat-sync logic 2023-10-02 19:20:11 +09:00
Dean Herbert 8010410487 Stop beat syncing (and close match stable's implementation of arrow animation) 2023-10-02 19:17:35 +09:00
Dean Herbert ad4e988520 Adjust reverse arrows to bounce more 2023-10-02 18:43:50 +09:00
Dean Herbert 455fc228ad Add edge piece to argon reverse arrow 2023-10-02 18:43:50 +09:00
Dean Herbert 7dd9951c44 Split out reverse arrow implementations to allow better animation 2023-10-02 18:43:50 +09:00
Dean Herbert 3a45bcad15 Improve flash and glow further 2023-10-02 02:11:07 +09:00
Dean Herbert c4f47974bc Improve glow further 2023-10-02 02:11:07 +09:00