RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,776 Commits 3 Branches 660 Tags 367 MiB
Commit Graph

53776 Commits

Author SHA1 Message Date
Salman Ahmed d04df19c7e Remove `APIScore` and replace its final usage 2022-07-25 13:13:46 +03:00
Dan Balasescu 068063a43a
Merge pull request #19371 from peppy/fix-working-cache-invalidation 
Fix calls to `GetWorkingBeatmap` invalidating cache too often
 2022-07-25 18:29:46 +09:00
Dan Balasescu 1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display 
Fix star ratings which are still being calculated showing as "-1" at song select
 2022-07-25 18:20:30 +09:00
Dan Balasescu 6937296192
Merge pull request #19374 from peppy/fps-counter-no-scheduler 
Refactor `FPSCounter` to not use scheduled tasks
 2022-07-25 18:19:59 +09:00
Salman Ahmed 35462a04a0
Merge pull request #19367 from smoogipoo/log-diffcalc-failure 
Log beatmap difficulty retrieval failures during score calculation
 2022-07-25 11:49:55 +03:00
Salman Ahmed 678acabf7e
Merge branch 'master' into log-diffcalc-failure 2022-07-25 11:16:31 +03:00
Dean Herbert 3c12b357e6
Merge pull request #19372 from frenzibyte/more-unprocessed-pp-handling 
Update more places to support displaying unprocessed PP placeholder
 2022-07-25 16:45:54 +09:00
Dean Herbert 2dd99ef1fd Refactor `FPSCounter` to not use scheduled tasks 
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.

I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
 2022-07-25 16:26:48 +09:00
Salman Ahmed 4d90e6bbac Flip method to read better 2022-07-25 10:03:06 +03:00
Dean Herbert 6bf2645b1a Fix `StarRatingDisplay` not handling negative numbers as "pending" 2022-07-25 15:44:54 +09:00
Salman Ahmed 6bdd1f43a2 Add visual test coverage 2022-07-25 09:40:20 +03:00
Salman Ahmed e402e919ab Display placeholder for user profile scores 2022-07-25 09:40:20 +03:00
Dean Herbert 2ec90e37bb Fix calls to `GetWorkingBeatmap` invalidating cache too often 
With recent changes, the pathway between refetching (on request) and
refetching (on requirement due to unpopulated files) was combined.
Unfortunately this pathway also added a forced invalidation, which
should not have been applied to the second case.

Closes https://github.com/ppy/osu/issues/19365.
 2022-07-25 15:30:49 +09:00
Dean Herbert bbbc0a863f Add test coverage of `WorkingBeatmap` retrieval from `BeatmapManager` 2022-07-25 15:30:49 +09:00
Salman Ahmed f54cee0270 Display placeholder for leaderboard top scores 2022-07-25 09:18:04 +03:00
Salman Ahmed 91d1c9686c Separate unprocessed PP placeholder to own class 2022-07-25 09:07:51 +03:00
Dan Balasescu fa1bc0fe0e
Merge pull request #19343 from frenzibyte/beatmap-overlay-null-pp 
Display exclamation icon for online scores with unprocessed PP
 2022-07-25 14:45:15 +09:00
Salman Ahmed 7facd6d822
Merge branch 'master' into beatmap-overlay-null-pp 2022-07-25 07:38:59 +03:00
Salman Ahmed 6c95c49da3 Mark test score with null PP for visual testing 2022-07-25 07:31:52 +03:00
Salman Ahmed 54eb2b98a9 Display exclamation triangle on scores with unprocessed PP 2022-07-25 07:30:57 +03:00
Dean Herbert 40b76d7560
Merge pull request #19368 from smoogipoo/disable-timeline-test 
Disable timeline test for now
 2022-07-25 13:21:10 +09:00
Dan Balasescu 0226b358ee Disable timeline test for now 2022-07-25 13:20:33 +09:00
Salman Ahmed 3beb1da3de Merge branch 'master' into beatmap-overlay-null-pp 2022-07-25 07:18:03 +03:00
Dean Herbert 12e2e63a1c
Merge pull request #19349 from bdach/mod-overlay/presets-column 
Implement basic appearance of mod preset column
 2022-07-25 13:10:47 +09:00
Dan Balasescu 3d97b74813 Log beatmap difficulty retrieval failures during score calculation 2022-07-25 13:03:47 +09:00
Dan Balasescu af8349e673
Merge pull request #19363 from frenzibyte/late-end-playing-signal 
Fix `Player` potentially disappearing in spectator list after restart
 2022-07-25 12:05:36 +09:00
Salman Ahmed fa9daa6899 Fix `TestSceneReplayRecorder` not using score provided by gameplay state 2022-07-25 05:21:27 +03:00
Salman Ahmed e0266b0d81 Reword comment slightly 2022-07-25 04:39:14 +03:00
Salman Ahmed f5a5887669 Fix players potentially not displaying in spectator after restart 2022-07-25 04:21:53 +03:00
Salman Ahmed feef16b09b Add potentially failing test case 2022-07-25 04:18:30 +03:00
Bartłomiej Dach 446485f804
Move localisation string to common location 2022-07-24 23:30:52 +02:00
Bartłomiej Dach 8af9cfbe40
Add readonly modifier 2022-07-24 23:29:18 +02:00
Bartłomiej Dach 6a67d76d7c
Add basic mod preset column implementation 2022-07-24 16:39:04 +02:00
Bartłomiej Dach b2f8934117
Extract base mod select column presentation logic 2022-07-24 16:39:03 +02:00
Dean Herbert 08024e70eb
Merge pull request #19345 from frenzibyte/fix-slider-bar-crash 
Fix `OsuSliderBar` throwing on negative draw width
 2022-07-24 19:36:19 +09:00
Salman Ahmed 4332e6cae9 Fix `OsuSliderBar` throwing on negative draw width 2022-07-24 08:34:24 +03:00
Salman Ahmed 0c16ef3e2e Add failing test case 2022-07-24 08:34:24 +03:00
Salman Ahmed 7c477e6f22 Fix beatmap overlay leaderboard not handling null PP scores properly 2022-07-24 04:20:49 +03:00
Dean Herbert 2205e0dc3d
Merge pull request #19324 from peppy/background-processor-error-logging 
Add error logging for background processing failures
 2022-07-24 07:38:26 +09:00
Dean Herbert f1791e79e3 Add error logging for background processing failures 2022-07-23 19:22:16 +09:00
Dean Herbert c7e490eaae
Merge pull request #19312 from frenzibyte/disable-backgorund-beatmap-processor-for-tests 
Fix background beatmap processor resetting star ratings in tests
 2022-07-23 19:21:45 +09:00
Salman Ahmed 836cb0927c
Merge branch 'master' into disable-backgorund-beatmap-processor-for-tests 2022-07-23 11:55:24 +03:00
Salman Ahmed 38d6adba40
Merge pull request #19299 from Cwazywierdo/beatmap-overlay-modded-stats 
Fix beatmap overlay stats showing modded values
 2022-07-23 11:53:36 +03:00
Salman Ahmed 840ad8fad2 Fix background beatmap processor resetting star ratings in tests 2022-07-23 11:10:59 +03:00
Salman Ahmed 2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats 2022-07-23 10:38:13 +03:00
Salman Ahmed c937c0548e Add test coverage 2022-07-23 10:16:11 +03:00
Salman Ahmed 661c79baf6 Add explanatory comment 2022-07-23 10:16:11 +03:00
Adam Baker 06462c13dd Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay 
Implement fix as suggested
 2022-07-22 23:15:24 -05:00
Adam Baker d451bc8fda Revert commits 
This reverts commit 28586c704d.

This reverts commit d9d35bb847.
 2022-07-22 22:25:49 -05:00
Dean Herbert 98593fbba1
Merge pull request #19287 from bdach/mod-overlay/preset-panel 2022-07-23 11:18:51 +09:00