Commit Graph

68122 Commits

Author SHA1 Message Date
Dean Herbert
43addc8400
Fix test regression 2024-07-12 16:29:41 +09:00
Dean Herbert
ca2fc72959
Adjust timeline centre marker visuals and bring in front of ticks 2024-07-12 16:29:40 +09:00
Dean Herbert
f65ab6736d
Adjust breaks in timeline to be centered with waveform / hitobjects 2024-07-12 15:45:58 +09:00
Dean Herbert
2ad2ae0c16
Add slight offset for timeline BPM display to avoid overlaps 2024-07-12 14:34:01 +09:00
Dean Herbert
9a7a0cdb34
Adjust timeline ticks to add a bit more body back 2024-07-12 14:29:18 +09:00
Dean Herbert
685b19a571
Adjust various visuals of summary timeline in a hope for user acceptance
.. with a somewhat appealing design.
2024-07-12 13:57:42 +09:00
Dean Herbert
e6b7d2530e
Change red shade for timing control points 2024-07-12 13:39:40 +09:00
Dean Herbert
fb4f620c90
Add back BPM and adjust sizing of bottom bar a bit more 2024-07-12 12:34:43 +09:00
Dean Herbert
911fa31ac0
Merge pull request #28823 from frenzibyte/remove-volume-key-arrow-handling
Remove key arrow handling in `VolumeOverlay` to avoid conflicting with ruleset key bindings (i.e. osu!catch)
2024-07-12 01:21:21 +09:00
Salman Ahmed
3ea0f58daa Update TestSceneFreeModSelectOverlay to work again 2024-07-11 15:31:23 +03:00
Salman Ahmed
d4a4a059d4 Fix footer content not accessible by overlay when overriden by a subclass 2024-07-11 15:31:02 +03:00
Salman Ahmed
7a5624fd0e Add screen footer to ScreenTestScene 2024-07-11 15:30:07 +03:00
Salman Ahmed
669e945fc3 Fix ModSelectOverlay not hiding without a footer 2024-07-11 14:56:17 +03:00
Salman Ahmed
bd44c17079 Enable NRT in VolumeOverlay 2024-07-11 14:29:56 +03:00
Salman Ahmed
3190f8bb7e Remove key arrow handling in VolumeOverlay 2024-07-11 14:29:33 +03:00
Salman Ahmed
7b541d378c Revert some changes
I can see `IsDisplayingToast` being removed and `IsPresent` becoming `=> Notifications.Any()` but I'll just leave this for another day.
2024-07-11 14:23:11 +03:00
Bartłomiej Dach
ccc4d288b2
Merge pull request #28821 from peppy/fix-editor-dim
Fix editor UI transparency being incorrectly opaque when hovering slider control points
2024-07-11 12:05:10 +02:00
Dean Herbert
95464ebf36
Merge branch 'master' into timeline-redesign 2024-07-11 18:38:17 +09:00
Bartłomiej Dach
6801ccbbc5
Fix editor UI remaining transparent when switching away from compose tab
Could still happen if using the keyboard F-key shortcuts. In that case
the composer becomes non-present, so its `Update()` can't really do
anything.
2024-07-11 11:23:09 +02:00
Bartłomiej Dach
f1fa34e5d5
Merge pull request #28800 from peppy/file-mounting-v3
Add ability to edit beatmap content externally
2024-07-11 10:47:36 +02:00
Dean Herbert
c139478aa2
Merge pull request #28805 from frenzibyte/select-all-on-focus
Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)
2024-07-11 17:33:30 +09:00
Dean Herbert
7b0c1e3498
Also apply to timing textboxes 2024-07-11 16:54:27 +09:00
Bartłomiej Dach
cc0d7e9981
Add error logging on failure to begin/end external edit 2024-07-11 09:54:12 +02:00
Bartłomiej Dach
ac467cf73a
Set locally modified state for all externally modified beatmap(sets) that could not be mapped to online 2024-07-11 09:44:33 +02:00
Bartłomiej Dach
a859978efd
Add failing test steps for locally modified state not being set 2024-07-11 09:43:00 +02:00
Dean Herbert
fe421edd8f
Fix editor UI transparency being incorrectly opaque when hovering slider control points
As mentioned at
https://github.com/ppy/osu/pull/28787#issuecomment-2221150025.
2024-07-11 16:41:21 +09:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3 2024-07-11 15:54:54 +09:00
Dean Herbert
b1dd2ead30
Merge pull request #28818 from peppy/configure-a-wait-what-the-foo-bar
Fix incorrect continuation in `ImportAsUpdate` causing UI blockage
2024-07-11 15:54:42 +09:00
Dan Balasescu
00cab0ec0a
Merge pull request #28809 from bdach/mania-timeline-zooms-composer
Match mania editor playfield time range with timeline zoom
2024-07-11 15:41:26 +09:00
Bartłomiej Dach
bfe34c9671
Merge branch 'master' into fix-all-notifications 2024-07-11 08:35:57 +02:00
Bartłomiej Dach
a9c8c6e74d
Attempt to fix test failures by forcing refresh 2024-07-11 08:18:16 +02:00
Dean Herbert
bdbdc3592e
Move full export async flow inside screen and add error handling 2024-07-11 14:27:12 +09:00
Dean Herbert
2eb6cf57af
Fix incorrect continuation in ImportAsUpdate causing UI blockage 2024-07-11 13:42:24 +09:00
Dean Herbert
599a765fd1
Add confirmation before saving for external edit 2024-07-11 12:20:33 +09:00
Dean Herbert
cd6b0e875a
Simplify save dialogs 2024-07-11 12:15:17 +09:00
Dean Herbert
b0d6c8ca6d
Abort operation on save failure 2024-07-11 11:42:06 +09:00
Bartłomiej Dach
efbbfab59d
Merge pull request #28807 from frenzibyte/fix-dialog-overflow
Fix confirm exit dialog overflowing from too many ongoing operations
2024-07-10 18:41:58 +02:00
Bartłomiej Dach
4901fece26
Merge branch 'master' into fix-dialog-overflow 2024-07-10 18:20:18 +02:00
Bartłomiej Dach
55b4dd9b99
Adjust punctuation 2024-07-10 18:17:10 +02:00
Bartłomiej Dach
92dc125d39
Match mania editor playfield time range with timeline zoom 2024-07-10 17:36:39 +02:00
Dean Herbert
b0e2462400
Merge pull request #28806 from bdach/remove-irrelevant-stuff-from-setup
Remove setup screen controls that do nothing useful
2024-07-10 23:14:34 +09:00
Dean Herbert
b58ba5f5f1
Just give in to silly code quality inspection 2024-07-10 23:02:19 +09:00
Salman Ahmed
bb9a2b705e Remove unnecessary math min 2024-07-10 16:29:28 +03:00
Salman Ahmed
846fd73ac9 Fix notification toast tray potentially hiding some notifications 2024-07-10 16:15:02 +03:00
Salman Ahmed
8ca8648a09 Add failing test case 2024-07-10 16:14:12 +03:00
Bartłomiej Dach
fa749d317e
Enable NRT on ManiaHitObjectComposer 2024-07-10 15:12:03 +02:00
Salman Ahmed
7d667ac46b Fix confirm exit dialog overflowing from too many ongoing operations 2024-07-10 16:06:53 +03:00
Bartłomiej Dach
c8a64c5950
Remove setup screen controls that do nothing useful
Before I go with a hammer to redesign these, I want to remove stuff that
does nothing first.

Hard-breaks API to allow rulesets to specify an enumerable of custom
sections rather than two specific weird ones.

For specific rulesets:

- osu!:
  - Stack leniency slider merged into difficulty section.
- osu!taiko:
  - Approach rate and circle size sliders removed.
  - Colours section removed.
- osu!catch:
  - No functional changes.
- osu!mania:
  - Special style toggle merged into difficulty section.
  - Colours section removed.
2024-07-10 14:53:16 +02:00
Salman Ahmed
ce93455aa8 Extend behaviour to sample edit popover 2024-07-10 15:16:10 +03:00
Salman Ahmed
94f51c92e0 Select all text when focusing a number box 2024-07-10 15:16:10 +03:00