RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,077 Commits 3 Branches 659 Tags 364 MiB
Commit Graph

744 Commits

Author SHA1 Message Date
Bartłomiej Dach a83c45b50e
Fix compile failures from framework breaking change 2022-06-24 16:07:14 +02:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Bartłomiej Dach 26c5b59f6d
Replace usages of `string.To{Lower,Upper}()` 2022-06-24 11:57:45 +02:00
Dean Herbert 50e40756c4 Rename `GracefullyExit` to `AttemptExit` 2022-06-19 12:34:44 +09:00
Dean Herbert f3c9f9a216
Merge pull request #18751 from frenzibyte/tournament-beatmap 
Improve tournament beatmap JSON storage using lightweight model
 2022-06-18 11:00:26 +09:00
Salman Ahmed 4c47996130 `TournamentPlayer` -> `TournamentUser` 2022-06-18 02:33:26 +03:00
Salman Ahmed 60903be566 Standardise naming for online ID 
Rather than continuing with `ID` or `Id`, this should follow the new
standards and use `OnlineID` instead. Only updating this since it's a
newly introduced class.
 2022-06-18 01:48:16 +03:00
Salman Ahmed 9f97d1a7db Replace tournament beatmap storage type with lightweight model 2022-06-18 01:34:09 +03:00
Salman Ahmed 200b23c689 Add lightweight `TournamentBeatmap` model 2022-06-18 01:30:56 +03:00
Salman Ahmed b977ce7995 Replace tournament player storage type with lightweight model 2022-06-17 21:35:04 +03:00
Salman Ahmed f3793c8809 Add lightweight `TournamentPlayer` model 2022-06-17 21:35:04 +03:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Bartłomiej Dach f88c568c8d
Update flag sizes after switch to twemoji assets 
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
 2022-06-15 21:45:47 +02:00
Dean Herbert c661f2b059 Ensure `ChannelManager` has access to API from point of construction 
Closes https://github.com/ppy/osu/issues/18451.
 2022-06-08 19:15:23 +09:00
Dean Herbert afbb1fa750 Fix tournament user stat population potentially using wrong ruleset 
`OsuGameBase.Ruleset` is bound
[late](7d0470794b/osu.Game.Tournament/TournamentGameBase.cs (L169))
so we must use the ladder one during user retrieval.

Closes https://github.com/ppy/osu/issues/18363.
 2022-05-23 14:07:11 +09:00
Dean Herbert 218642c300 Update unsafe file write usages 2022-05-16 18:05:27 +09:00
Dan Balasescu 494955aff1 Resolve inspection issues 2022-04-14 13:11:11 +09:00
Dean Herbert ea672745b0 Add ability to switch between most common tournament scenes using key bindings 2022-04-01 12:44:49 +09:00
Dean Herbert a06b0a4966 Fix tournament bracket parsing's ruleset refetch logic not working correctly 
Due to equality being based on `ShortName`, it was feasible that the
re-fetch exited early (in bindable shortcutting logic) causing the
ruleset's `OnlineID` to remain `-1` or something equally wrong.

Resolves issue pointed out at
https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.
 2022-03-31 18:41:00 +09:00
Dean Herbert a7a7584d3e Add test coverage ensuring ruleset ID is correct after bracket read 
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
 2022-03-31 18:39:58 +09:00
Dean Herbert 2938f44e6c Update `PresentExternally` usages in line with framework changes 2022-03-24 23:41:07 +09:00
Dean Herbert df4170b939 Display star ratings in tournament mode using two decimal places 2022-02-27 23:17:04 +09:00
Dean Herbert 297e5ec62e Remove unused constants 2022-02-27 23:16:04 +09:00
Shivam 4c56458173 Change button location to the right side of dropdown 2022-02-25 15:15:40 +01:00
Shivam 333c0cd4f9 Add open folder button to open currently selected tournament 2022-02-25 14:31:46 +01:00
Dean Herbert 44f2d8a448 Allow game folder migration to fail gracefully when cleanup cannot completely succeed 2022-02-10 19:30:26 +09:00
Bartłomiej Dach 9deeaee404
Fix tournament client not loading 
Caused by a `LoadComponentsAsync()` call being fired from a worker
thread, which will throw exceptions since the recent addition of safety
checks around that method.
 2022-01-27 17:31:12 +01:00
Dean Herbert 5288eedd31 Update all usages of `RulesetID` and `Ruleset.ID` to use `Ruleset.OnlineID` 2022-01-27 15:38:03 +09:00
Salman Ahmed b2d1bd029d Turn on high poll rate when tournament chat is expanded 2022-01-22 16:34:57 +03:00
Bartłomiej Dach 03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
Susko3 19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Dean Herbert b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
Dean Herbert 51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
Joseph Madamba 5082b0e63f Fix some identifiers using shortened naming 2021-12-27 20:26:28 -08:00
Joseph Madamba 7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Bartłomiej Dach 38702beabf
Merge branch 'master' into i-ruleset-store 2021-12-04 15:05:39 +01:00
Dean Herbert 1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert e75e209053 Cache and consume `IRulesetStore` where feasible 2021-12-03 18:16:01 +09:00
Dean Herbert 5158736839 Avoid saving bracket if parsing failed, at all costs 2021-12-03 16:06:38 +09:00
Dean Herbert ba05a0a383 Centralise specification of bracket.json filename 2021-12-03 16:04:11 +09:00
Bartłomiej Dach 87d6a743dd
Migrate custom tournament client assets to uppercased directories 
It has transpired that on filename-case-sensitive filesystems, the
tournament client does not consistently handle custom asset paths.
Videos and mods could only be looked up from `videos` and `mods`
directories (lowercase), while flags could only be looked up from the
`Flags` directory (uppercase).

A complicating circumstance is that default country flags, coming from
osu-resources, also depend on the flag lookup being uppercased.

To attempt to clean up the handling as much as it appears to be
possible, automatically move user-supplied lowercase directories to
uppercase.
 2021-11-28 16:36:19 +01:00
Dean Herbert bbd3ea5b77 Update all actual usages of `RulesetInfo.ID` to use `OnlineID` instead 2021-11-24 15:50:26 +09:00
Dean Herbert 86540d1fb6 Update existing usages of `Author` as `string` to access `Username` directly 2021-11-04 18:57:54 +09:00
Dean Herbert b9983add15 Rename `User` to `APIUser` and move to correct namespace 2021-11-04 18:21:31 +09:00
Dean Herbert 10a9266956 Fix beatmap creator showing twice in tournament map pool panels 2021-11-01 14:33:24 +09:00
Dean Herbert 6f5040722a Merge branch 'master' into beatmap-refactor/uncontested 2021-10-28 16:37:26 +09:00
Dan Balasescu f9ca7f5df1
Merge pull request #15319 from peppy/beatmap-refactor/tournament 
Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode
 2021-10-28 16:26:06 +09:00
smoogipoo 313f78cbfb Fix non-null inspection 2021-10-28 15:24:44 +09:00
Dean Herbert a6669a3892 Add mention of why the serialisation happens outside stream usage 2021-10-28 15:04:09 +09:00
Dean Herbert ef26b0ba8a Fix serlialisation failure during ladder saving causing all existing file content to be deleted 2021-10-28 15:00:30 +09:00