Dean Herbert
ca92c116b5
Fix osu!catch trail spacing not matching osu!stable expectations
...
Closes https://github.com/ppy/osu/issues/28997 .
2024-08-19 15:01:16 +09:00
Bartłomiej Dach
659505f711
Adjust calls to `GetContainingInputManager()`
2024-06-18 07:41:19 +02:00
Bartłomiej Dach
9dae806734
Use `IsRewinding` in a few more places
2023-07-08 13:32:24 +02:00
ekrctb
812a4b412a
Move judgement result revert logic to Playfield
...
Previously, some judgement results were not reverted
when the source DHO is not alive (e.g. frames skipped in editor).
Now, all results are reverted in the exact reverse order.
2023-01-19 19:57:13 +09:00
ekrctb
b88091262d
Remove #nullable disable from Catch.UI
2023-01-15 17:29:35 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
c95eb2d2c1
Fix incorrect case in `CatcherArea` parameter
2022-07-06 14:28:50 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Darius Wattimena
95891bc655
Moved clear plate logic to Catcher class
2021-11-18 20:03:41 +01:00
Darius Wattimena
2c4f1817d3
Fixed an issue where banana showers don't clear the plate when missing the last banana
2021-11-14 20:43:31 +01:00
smoogipoo
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
smoogipoo
3e56388ba8
Match casing in enum value
2021-08-02 15:08:42 +09:00
ekrctb
4e2f928d65
Fix comment
2021-07-30 15:44:09 +09:00
ekrctb
a204ef39dd
Prevent catcher trail generation while rewinding
2021-07-29 17:32:38 +09:00
ekrctb
81f23e1111
Manage catcher trails by lifetime entries
2021-07-29 17:12:01 +09:00
ekrctb
a960a28d06
Replace "end glow" terminology with "hyper-dash after-image"
...
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
ekrctb
0bf04ece34
Avoid `internal` property by using `ChildrenOfType`
2021-07-28 18:13:43 +09:00
ekrctb
846f539428
Avoid usage of LINQ in last dash trail computation
2021-07-27 19:11:08 +09:00
ekrctb
da69867fd4
Move catcher trail generation logic to `CatcherArea`
2021-07-27 19:07:37 +09:00
ekrctb
d9f9ad35be
Move catcher base size constant to `Catcher`.
2021-07-21 16:43:24 +09:00
ekrctb
30777795ce
Add some doc comment to `CatcherArea`
2021-07-21 16:40:35 +09:00
ekrctb
94678064ff
Rename `CatcherArea.MovableCatcher` to `Catcher`
2021-07-21 16:28:31 +09:00
ekrctb
97059a9f50
Create `Catcher` in `CatchPlayfield`
2021-07-19 19:44:40 +09:00
ekrctb
ae09c23e4e
Resolve `DroppedObjectContainer` via DI
2021-06-24 16:09:13 +09:00
ekrctb
16d5893535
Add `DroppedObjectContainer` class
2021-06-24 15:51:54 +09:00
ekrctb
7f7c2c73e0
Move catcher movement logic of `Catcher` to `CatcherArea`
2021-06-11 15:39:06 +09:00
ekrctb
ccca7e0b25
more specific type droppedObjectContainer
2020-12-09 10:35:01 +09:00
ekrctb
0213f77b4b
Move catcher state changing logic to OnNewResult method
2020-12-08 14:28:30 +09:00
ekrctb
e82ca66d3e
Fix depth of dropped objects
2020-12-04 10:21:54 +09:00
ekrctb
5a5c956ced
Move more logic to Catcher from CatcherArea
2020-12-03 16:44:36 +09:00
ekrctb
2eb2c934cc
Refactor fruit dropping code
...
- The repeated `Remove` call was quadratic complexity.
Now it is linear time.
2020-12-03 16:44:36 +09:00
ekrctb
8d32cca5d6
Use more specific type for caught object
2020-12-03 16:44:36 +09:00
ekrctb
a231a4aa6d
Remove unused method
2020-12-03 16:44:36 +09:00
ekrctb
af45e8d97b
Don't delay caught fruit loading
...
It is not needed anymore because
some code in DCHO is moved from `load` to constructor.
2020-12-03 16:44:36 +09:00
ekrctb
d1076778fd
Convert switch expression to switch statement
2020-12-01 09:50:52 +09:00
ekrctb
05aaa377e7
Don't use CreateDrawableRepresentation in CatcherArea
2020-11-30 19:02:49 +09:00
ekrctb
3c3229ac4b
Remove redundant `StaysOnPlate`
2020-11-25 07:59:45 +09:00
ekrctb
ab7251d742
Move members to `PalpableCatchHitObject`
2020-11-24 19:57:37 +09:00
smoogipoo
4ca9a69de2
Use new hit results in catch
2020-09-29 16:33:38 +09:00
Bartłomiej Dach
fcf3a1d13c
Encapsulate combo display better
2020-09-12 22:40:34 +02:00
Salman Ahmed
ba8a4eb6f0
Move osu!catch combo counter display to inside CatcherArea
2020-09-01 20:17:21 +03:00
Bartłomiej Dach
28534c1599
Reintroduce PalpableCatchHitObject at data level
2020-08-20 19:06:26 +02:00
Dean Herbert
2624862e32
Fix osu!catch dropping fruit appearing above the plate instead of behind
2020-07-15 20:58:09 +09:00
ekrctb
3278a1d7d8
Standardize osu!catch coordinate system
...
There were two coordinate systems used:
- 0..512 (used in osu!stable)
- 0..1 (relative coordinate)
This commit replaces the usage of
the relative coordinate system to
the coordinate system of 0..512.
2020-07-02 00:21:45 +09:00
Salman Ahmed
95de2c6f7f
Mark Catcher.additiveTarget to never be null
...
And provide empty containers instead.
2020-04-22 05:04:07 +03:00
Salman Ahmed
ee62739b08
Simplify process of adding catcher trails
2020-04-21 11:44:39 +03:00
Salman Ahmed
19f39fe632
Change AdditiveTarget into a set method
2020-04-04 19:33:52 +03:00
Salman Ahmed
fecafc2e48
Fix additive target accidentally clears all of the added containers
...
It sets the AdditiveTarget on the object initializer but then the catcher is set to Child which wipes up all of the existing children (containers added by Catcher through AdditiveTarget setter)
2020-03-26 09:14:44 +03:00
Dean Herbert
1733519c3a
Split out CatcherArea nested classes and reorder methods
2020-03-13 12:59:30 +09:00
Andrei Zavatski
bc2a1cdb62
Apply suggestions
2020-03-12 12:04:36 +03:00