Commit Graph

25 Commits

Author SHA1 Message Date
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Acid Chicken (硫酸鶏) 267465df18
chore(osu.Game): combine `Osu.Colour.{Draw,Text}ForHitResult` into `OsuColour.ForHitResult` 2022-09-07 23:34:46 +09:00
Acid Chicken (硫酸鶏) 5f0832ead7
refactor(osu.Game): separate `OsuColour.ForHitResult` by usage 2022-09-05 01:58:57 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert bd9ea9bd6f Revert most unnecessary changes
Turns out `AlwaysPresent` at top level is actually enough.

This reverts commit 86163d2225.
2022-06-13 23:58:14 +09:00
Dean Herbert 86163d2225 Fix hit error meters not updating visual state when hidden
It is an expectation of users that when the HUD is shown after a period
of being hidden, it will visually reflect the state based on recent
judgements.

To achieve this, I've added `AlwaysPresent` and moved the transform
application to the meter level, rather than at a child level. If this is
seen as a bad direction, `AlwaysPresent` can be applied to the drawable
children and the transforms can be moved back.

Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
could potentially be removed and reduce `AlwaysPresent` usage by one.
Can do that refactor as part of this PR if preferred.

Closes #18624.
2022-06-13 16:38:57 +09:00
Dean Herbert edcbd4de6d Fix incorrect event unbind logic 2021-12-21 13:05:26 +09:00
Dean Herbert 52db7b36fc Move `Schedule` call to base implementation of error meter for extra safety 2021-12-21 12:55:21 +09:00
sh0ckR6 9a1db04920
Resolve `GameplayClockContainer` instead of `Player` 2021-09-20 10:28:58 -04:00
sh0ckR6 36a20ab0b3
Resolve failed test compilation 2021-09-20 10:26:07 -04:00
sh0ckR6 10fe2382b0
Address most issues 2021-09-20 10:07:42 -04:00
sh0ckR6 f6e279baa1
Add xmldoc to HitErrorMeter.Clear
Explains how the method is called and what inheritors should do when implementing it.
2021-09-18 12:18:11 -04:00
sh0ckR6 b2b3108afa
Resolve addressed issues
+ Stopped using testing methods in non-testing classes
+ Resolve Player and add OnSeek event
+ Take bindings away from BarHitErrorMeter
+ Add support for ColourHitErrorMeter
2021-09-17 16:19:41 -04:00
Dean Herbert c751e087ca
Merge branch 'master' into skin-editor-closest-anchor 2021-06-18 18:54:07 +09:00
smoogipoo 00efed2c39 Add colours for tick judgements 2021-06-08 23:10:21 +09:00
Robin Avery dc50ae40b9
Rename `OverridesClosestAnchor` to `UsesFixedAnchor` 2021-06-08 08:28:42 -04:00
Bartłomiej Dach 0531c2dcd9 Move empty window check to bar error meter
It's not valid in the base `HitErrorMeter`, as the colour meter only
displays colour for a given judgement, so it is still valid to add new
items to it even if the hit window is 0, as misses are still possible.
2021-06-07 13:16:07 +02:00
Robin Avery 133d72a8c0
Rename UsingClosestAnchor
It is now "OverridesClosestAnchor". The logic is inverted accordingly.
2021-06-07 00:14:36 -04:00
Robin Avery ce635af83e
Add UsingClosestAnchor to ISkinnableDrawable
Also implement it as an auto property in its inheritors.
The auto properties default to true.
2021-06-06 23:47:47 -04:00
Dean Herbert 7137315fa7 Remove `HitErrorDisplay` container and hook up data 2021-05-17 19:46:50 +09:00
smoogipoo fa872858b5 Remove unnecessary check 2021-05-10 16:40:06 +09:00
Dean Herbert 97e72849af Fix regressed `HitErrorDisplay` behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
Andrei Zavatski b61aa660c6 Move colours to HitErrorMeter class 2019-12-21 14:52:53 +03:00
Dean Herbert f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
Dean Herbert 8fc177b743 Fix namespacing and hitwindow source 2019-08-30 18:46:42 +09:00