RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
51,925 Commits 3 Branches 658 Tags 358 MiB
Commit Graph

51925 Commits

Author SHA1 Message Date
Dean Herbert 70c8a43961 Update framework 2022-05-29 21:31:20 +09:00
Dean Herbert 7c97719db1 Move `Schedule` to only drawable pieces 2022-05-29 21:28:09 +09:00
Dean Herbert c7570fbce5 Fix potential `ObjectDisposedException` on realm notification in `SkinSection` 2022-05-29 15:15:03 +09:00
Dean Herbert 20701edc23
Merge pull request #18459 from bdach/unobserved/convert-slider 
Fix unobserved exceptions in multiple tests due to constructing `GameplayState` instances with unconverted beatmaps
 2022-05-29 00:54:11 +09:00
Bartłomiej Dach a8e1c5ba87
Fix remaining cases of incorrect `GameplayState` construction in tests 
Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.
 2022-05-28 15:23:29 +02:00
Bartłomiej Dach dcf3d76954
Fix unobserved exceptions due to using unconverted beatmap 
`TestSceneBeatmapSkinFallbacks` was locally caching a `GameplayState`
instance to fulfill dependencies of a
`SkinnableTargetComponentsContainer`. However, it was doing so using
`new TestBeatmap()`, which is a raw decoded beatmap that hasn't been
converted to any ruleset yet, which was causing failures in
`BeatmapDifficultyCache.GetTimedDifficultyAttributesAsync()` as that
method is expecting to receive a post-conversion, ready-for-gameplay
beatmap.

Resolve by proxying forward dependency instances from the
already-known-to-be-working `actualComponentsContainer`.
 2022-05-28 15:23:29 +02:00
Bartłomiej Dach 1641918c51
Revert "Avoid throwing unobserved exception when `PerformancePointsCounter` requests timed attributes" 
This reverts commit 19b655d75b.
 2022-05-28 15:23:28 +02:00
Dean Herbert 10d0238e39
Merge pull request #18457 from bdach/unobserved/not-implemented 
Fix unobserved exceptions in `TestSceneStatisticsPanel` due to unimplemented beatmap converter
 2022-05-28 22:22:25 +09:00
Bartłomiej Dach e18fec3d89
Fix unobserved exceptions due to unimplemented beatmap converter 
`TestSceneStatisticsPanel` intends to check the operation of statistics
panels using dummy ruleset classes. However, `StatisticsPanel` relies on
being able to retrieve the playable beatmap, which requires a converter.
One was not provided by the dummy rulesets, therefore the retrieval
would fail with an unobserved exception.

To fix, add a barebones converter implementation that is enough for the
test to pass.
 2022-05-28 14:10:57 +02:00
Dean Herbert 62266c72ea
Merge pull request #18448 from frenzibyte/editor-metronome-rate 
Fix metronome speed not adjusted on different playback rates
 2022-05-28 10:58:51 +09:00
Dean Herbert 4f2910cdb1
Merge pull request #18445 from frenzibyte/editor-background-colour 
Darken background colour in "setup" and "verify" screens
 2022-05-28 10:56:22 +09:00
Dean Herbert 3aa7e3141e
Merge pull request #18443 from frenzibyte/fix-beatmap-badge-colouring 
Fix beatmap badge colours not updated inline with recent changes
 2022-05-28 10:55:07 +09:00
Dean Herbert 68684f5fe7
Merge pull request #18446 from frenzibyte/editor-row-attribute-background 
Update row attribute background colour to fit screen
 2022-05-28 10:53:50 +09:00
Dean Herbert 6ed21973b0
Merge pull request #18447 from frenzibyte/editor-verify-settings-width 
Fix editor verify settings looking cramped up due to small width
 2022-05-28 10:51:52 +09:00
Dean Herbert 93a8092da6 Increase usable width slightly further 2022-05-28 10:51:39 +09:00
Salman Ahmed 2fac710d4b Add step for adjusting editor clock rate in test scene 2022-05-28 04:10:39 +03:00
Salman Ahmed e12d188dad Fix metronome speed not adjusted on different playback rates 2022-05-28 04:10:39 +03:00
Salman Ahmed d12e4928e6 Increase editor verify settings width to give more breathing space 2022-05-28 03:09:04 +03:00
Salman Ahmed e71d907164 Update row attribute background colour to fit screen 2022-05-28 02:20:04 +03:00
Salman Ahmed eec9248cde Darken background colour in "setup" and "verify" screens 2022-05-28 02:10:18 +03:00
Salman Ahmed 06832a4baf Fix beatmap badge colours not updated inline with recent changes 2022-05-28 01:05:43 +03:00
Dean Herbert 5eb16ff46c Update framework 2022-05-28 04:02:35 +09:00
Dean Herbert ca9b2648a3
Merge pull request #18421 from peppy/reconnect-on-server-shutdown-exception 
Handle server shutdown messages in room creation and spectator initialisation
 2022-05-28 03:52:24 +09:00
Dean Herbert 03d9ca0d8d
Merge pull request #18437 from peppy/fa-playlist-category 
Add featured artist playlist category
 2022-05-28 01:28:21 +09:00
Dean Herbert f708b98058
Merge pull request #18438 from Susko3/use-normalised-precise-scrolling 
Adjust `ScrollDelta` usages to account for normalised `IsPrecise` values
 2022-05-28 01:10:10 +09:00
Bartłomiej Dach e511c1dfff
Merge branch 'master' into use-normalised-precise-scrolling 2022-05-27 16:55:13 +02:00
Bartłomiej Dach aadcf25129
Merge pull request #18441 from peppy/update-resources 
Update resources
 2022-05-27 16:52:50 +02:00
Bartłomiej Dach a94432f3bd
Fix drawable room border colour not matching badge 2022-05-27 16:40:15 +02:00
Dean Herbert 6960bec52d Update resources 2022-05-27 23:29:48 +09:00
Dean Herbert d9ecf69d20 Update framework 2022-05-27 23:29:39 +09:00
Dean Herbert 046867f5f4
Merge pull request #18436 from peppy/fix-unsafe-mutation 
Fix potential crash from unsafe drawable mutation in scoreboard update code
 2022-05-27 21:00:15 +09:00
Dean Herbert 2f57849bcb Fix unexpected assertion failure 2022-05-27 20:59:00 +09:00
Dean Herbert 883c6f1eb3 Update colour of spotlights playlist to match new specs 2022-05-27 20:26:35 +09:00
Dean Herbert ef47b380c6 Add featured artist playlist category 2022-05-27 20:18:46 +09:00
Dean Herbert d94315ee3f Fix potential crash from unsafe drawable mutation in scoreboard update code 2022-05-27 20:03:30 +09:00
Dan Balasescu 5657cb757d
Merge pull request #18435 from peppy/silence-parse-failures 
Don't output beatmap parse failures in a visible manner
 2022-05-27 19:42:18 +09:00
Dean Herbert e53c8518de Don't output beatmap parse failures in a visible manner 
The user can't do much about this. When a user reports a beatmap issue,
the logs will still contain this useful information. Should be fine I
think.

As mentioned in

https://github.com/ppy/osu/discussions/18426
https://github.com/ppy/osu/issues/750
https://github.com/ppy/osu/issues/18372

etc.
 2022-05-27 19:18:38 +09:00
Dean Herbert ab444c213f
Merge pull request #18433 from Joehuu/use-exisiting-chat-translations 
Use existing web localisation for chat strings
 2022-05-27 14:50:54 +09:00
Joseph Madamba 105d581f24 Use existing web localisation for chat strings 2022-05-26 22:23:03 -07:00
Dan Balasescu 198afb6aa7
Merge pull request #18431 from Joehuu/fix-scores-container-visibility 
Fix beatmap info scores container not hiding when there's no leaderboard
 2022-05-27 14:17:42 +09:00
Dean Herbert 27cb9d1ead
Merge pull request #18432 from Joehuu/fix-editor-menu-item-checks 
Fix checkmarks not showing on editor stateful menu items
 2022-05-27 14:16:42 +09:00
Joseph Madamba e551a53601 Fix checkmarks not showing on editor stateful menu items 2022-05-26 21:45:30 -07:00
Joseph Madamba 389020b497 Fix scores container test failures 2022-05-26 20:58:47 -07:00
Joseph Madamba 3554563114 Fix beatmap info scores container not hiding when there's no leaderboard 2022-05-26 19:50:54 -07:00
Joseph Madamba 125dda716d Add failing scores container visibility test 2022-05-26 19:46:42 -07:00
Dan Balasescu cab4299f0c
Merge pull request #18429 from Joehuu/fix-incorrect-beatmap-info-status-pill 
Fix beatmap info status pill being incorrect on multiple status beatmaps
 2022-05-27 10:42:37 +09:00
Joseph Madamba 2b5aa35b56 Fix beatmap info status pill being incorrect on multiple status beatmaps 2022-05-26 17:52:17 -07:00
Joseph Madamba 0cdefbc6df Add failing beatmap info status test 2022-05-26 17:52:17 -07:00
Bartłomiej Dach 0d760e707e
Merge pull request #18423 from smoogipoo/fix-multiplayer-race 
Fix multiplayer race condition when starting gameplay
 2022-05-26 21:13:10 +02:00
Bartłomiej Dach e7a266e742
Merge branch 'master' into fix-multiplayer-race 2022-05-26 20:43:20 +02:00