Commit Graph

2411 Commits

Author SHA1 Message Date
Dean Herbert 374dac57f2 Change expanded card content height to 200 2022-01-04 13:22:00 +09:00
Bartłomiej Dach 0ad555e9f7
Remove surplus blank line 2022-01-03 18:33:32 +01:00
Dean Herbert b9851b278d Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
Closes https://github.com/ppy/osu/issues/16120.
2022-01-03 13:18:28 +09:00
Joseph Madamba 7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Bartłomiej Dach 3ca238825b
Unify width of normal and extra card sizes 2021-12-24 09:17:07 +01:00
Bartłomiej Dach a49a4329ee
Add capability to switch between card sizes 2021-12-23 15:55:37 +01:00
Bartłomiej Dach cd4c1bc678
Add factory method for various card sizes 2021-12-23 15:55:36 +01:00
Dean Herbert f179ff33c9 Remove all NRT changes
This reverts commit bb9877adab.
2021-12-22 21:02:06 +09:00
Dean Herbert bb9877adab Reapply `IWorkingBeatmap` nullability fixed 2021-12-22 20:48:48 +09:00
Dean Herbert bc47801cbb Revert "Apply NRT to `WorkingBeatmap`"
This reverts commit 9e17d7d4e3.
2021-12-22 19:14:18 +09:00
Dean Herbert 9e17d7d4e3 Apply NRT to `WorkingBeatmap` 2021-12-22 18:41:45 +09:00
Dean Herbert 53c0a6708f Move public accessor properties to top of file 2021-12-22 18:25:09 +09:00
Dean Herbert a5f77a86ef Move load methods and rename `loadedTrack` to match other private fields 2021-12-22 18:24:51 +09:00
Dean Herbert 7344c87b16 Remove `RecyclableLazy` 2021-12-22 18:18:12 +09:00
Dean Herbert f3f491374b Remove unused load checks 2021-12-22 18:17:00 +09:00
Dean Herbert 3c95497ed7 Reorder methods to hopefully make more sense 2021-12-22 18:17:00 +09:00
Dean Herbert e38e4c0adc Enable NRT on `IWorkingBeatmap` 2021-12-22 18:17:00 +09:00
Dean Herbert 967419c9ac Remove `BeatmapSetInfo` and `Metadata` from interface
There were very few accesses to this, and after realm they should all be
done via the `BeatmapInfo`, so let's remove this.
2021-12-22 18:17:00 +09:00
Dean Herbert 1b0af78831 Simplify `WorkingBeatmap` in multiple ways
Just a clean-up pass.
2021-12-22 18:17:00 +09:00
Dean Herbert b38b300159 Convert `BeatmapMetadata` access to be via a computed property 2021-12-22 18:17:00 +09:00
Bartłomiej Dach c7b9b176c6
Rename `BeatmapCard{Base => }` 2021-12-21 08:26:25 +01:00
Bartłomiej Dach 88d4e95ad8
Rename `BeatmapCard{ => Normal}` 2021-12-21 08:26:21 +01:00
Bartłomiej Dach 33e930f477
Move scale-on-expand logic to `BeatmapCardContent` 2021-12-17 13:29:20 +01:00
Bartłomiej Dach d6f6039934
Extract base class for beatmap cards 2021-12-17 13:27:11 +01:00
Bartłomiej Dach f052b47d87
Extract collapsible button container for card usage 2021-12-17 12:58:05 +01:00
Bartłomiej Dach 7aab12d4b0
Share extra row dropdown show/cancel show logic 2021-12-17 11:45:05 +01:00
Bartłomiej Dach 3fa45479b0
Share hype/nomination statistic show logic 2021-12-17 11:45:05 +01:00
Bartłomiej Dach c6d0b5d200
Merge branch 'master' into beatmap-card/extra-wip 2021-12-17 11:11:36 +01:00
Bartłomiej Dach 54790bb758
Merge branch 'master' into fix-realm-post-storage-migration-failure 2021-12-17 00:19:46 +01:00
Dean Herbert ad430a6277 Centralise hover state handling (and fix back-to-front conditionals) 2021-12-15 16:44:58 +09:00
Dean Herbert 6a1f535257 Refactor cancellation of expand to be more explicit 2021-12-15 16:38:19 +09:00
Dean Herbert 94d1a2aaca Remove unnecessary collapse call from `BeatmapCard`
This is already handled at the `BeatmapCardContent` level. This call
actually causes the buggy behaviour reported in
https://github.com/ppy/osu/discussions/16085.
2021-12-15 16:37:47 +09:00
Dean Herbert 7a9db22c52 Tidy up method naming and structure for expanded state changes 2021-12-15 16:29:12 +09:00
Dean Herbert ef4ab74565 Also only expose `Expanded` state of `BeatmapCard` as read-only 2021-12-15 16:26:19 +09:00
Dean Herbert 41e6c24dad Expose `Expanded` state of `BeatmapCardContent` as read-only bindable
This is just to reduce complexity of these interactions by ensuring that
the expanded state can only be changed by the class itself.
2021-12-15 16:26:19 +09:00
Dean Herbert f9a2db5ec6 Add accessibility to realm factory via `IStorageResourceProvider`
We might need to rename this class..
2021-12-14 14:19:49 +09:00
Bartłomiej Dach 083ee92dee
Adjust button vertical padding 2021-12-08 22:56:28 +01:00
Bartłomiej Dach 2d739c95ea
Lay out extra card statistics in grid as per design 2021-12-08 22:56:28 +01:00
Bartłomiej Dach 3ecfaa532c
Add source field to extra beatmap card 2021-12-08 22:56:28 +01:00
Bartłomiej Dach 419fee1380
Move mapper link to bottom content 2021-12-08 22:54:11 +01:00
Bartłomiej Dach 61e04f75cc
Resize extra card to design size 2021-12-08 22:54:10 +01:00
Bartłomiej Dach a32492cdd5
Duplicate `BeatmapCard{-> Extra}` as blueprint for extra card size 2021-12-08 22:53:51 +01:00
Dean Herbert 8d9c37a825 Merge branch 'master' into primary-key-consistency 2021-12-08 21:34:38 +09:00
Dean Herbert 25a0505c97 Scale card when expanding to better distinguish hovered card from other cards in listing 2021-12-07 23:48:14 +09:00
Bartłomiej Dach 82ed8eae6b
Ensure hover handling container always calls base on hover events 2021-12-06 21:02:40 +01:00
Bartłomiej Dach ccfc361626
Apply naming suggestions 2021-12-06 21:02:38 +01:00
Bartłomiej Dach 0f74389389
Add scrolling for long difficulty lists in beatmap card 2021-12-05 20:17:59 +01:00
Bartłomiej Dach af35652b8b
Disable beatmap card expansion on solo spectator screen 2021-12-05 20:07:58 +01:00
Bartłomiej Dach e451e43b90
Implement input handling behaviour of beatmap card dropdown 2021-12-05 16:31:45 +01:00
Bartłomiej Dach 250e5b47b7
Move "extra info" beatmap card row to separate component 2021-12-05 15:52:19 +01:00