Commit Graph

3251 Commits

Author SHA1 Message Date
Salman Ahmed 4b56d94a98 Revert accidentally pushed part of change 2021-06-30 10:26:34 +03:00
Salman Ahmed e3344c33ea Better convey reason of "Spin In" incompatibility with "Hidden" 2021-06-30 09:57:15 +03:00
Salman Ahmed dbe3150f88 Mention about marker interfaces even more explicitly 2021-06-29 11:37:08 +03:00
Salman Ahmed 7997d57030 Mention interfaces being "markers" for the time being 2021-06-29 11:25:35 +03:00
Salman Ahmed 69dac018c7 Make `OsuModSpinIn` as incompatible with other `IHidesApproachCircles` mods
Respecting the TODO comment above it, mark `OsuModSpinIn` as
incompatible with other `IHidesApproachCircles` mods as well.
2021-06-28 21:20:07 +03:00
Salman Ahmed baf736026b Mark `IHidesApproachCircles` mods as incompatible with `IRequiresApproachCircles` 2021-06-28 21:20:07 +03:00
Salman Ahmed 6a67a6736a Mark `IRequireApproachCircles` mods as incompatible with `IHidesApproachCircles` 2021-06-28 21:20:07 +03:00
Salman Ahmed 006cc331c8 Separate `IMutateApproachCircles` to requiring and hiding 2021-06-28 21:20:07 +03:00
Bartłomiej Dach 50c27d2635 Update usages of `IHasTooltip` in line with framework localisation changes 2021-06-25 19:10:04 +02:00
Henry Lin ec8810cc2b Use `MathF` instead of `(float)Math` 2021-06-25 09:44:23 +08:00
Henry Lin 26086ca1ef Rename `VectorUtils` to `OsuHitObjectGenerationUtils` 2021-06-25 09:43:14 +08:00
Henry Lin 3fcda83713 Rename `VectorHelper` to `VectorUtils` 2021-06-24 22:00:19 +08:00
Henry Lin 153e204d20 Cap rotation ratio to 1 2021-06-24 13:22:10 +08:00
Henry Lin 2268d7f8a5 Extract utility methods into helper class; Better xmldoc and naming 2021-06-24 13:19:42 +08:00
Dean Herbert 4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
2021-06-22 21:24:56 +09:00
Dean Herbert 6c3d2315d0
Merge pull request #13606 from Naxesss/low-diff-checks
Add low difficulty spacing checks
2021-06-22 16:29:37 +09:00
Dean Herbert 1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
Dean Herbert e9339d6100 Move some inline comments on `const`s to xmldoc instead 2021-06-22 15:16:19 +09:00
Naxess 2f3f4f3e4b Add new checks to verifier 2021-06-21 15:30:45 +02:00
Naxess fcb918d0e1 Add time distance equality check 2021-06-21 15:30:23 +02:00
Naxess 3eb088f89a Add low difficulty overlaps check 2021-06-21 15:30:04 +02:00
Salman Ahmed 999bf27eae Remove unnecessary abstraction of `ApproachCircle` property 2021-06-21 12:07:00 +03:00
Salman Ahmed ba15f7c19b Move `ApproachCircle` out of the scale container and revert relevant changes 2021-06-21 10:47:38 +03:00
Salman Ahmed 036b745425 Remove no longer needed `LegacySpinnerApproachCircle` 2021-06-21 08:41:10 +03:00
Salman Ahmed 42edbe4fb9 Move `ApproachCircle` implementation into per-style 2021-06-21 08:40:38 +03:00
Salman Ahmed 68e28f4903 Implement `IHasApproachCircle` in `DrawableHitCircle` as well 2021-06-21 07:35:07 +03:00
Salman Ahmed 01478d780d Generalize `IHasSpinnerApproachCircle` from being spinner-specifc 2021-06-21 03:43:11 +03:00
Salman Ahmed 72155a7c52 Replace if pattern-matching check with switch cases instead 2021-06-21 03:37:50 +03:00
Salman Ahmed c3217fd8b1 Remove leftover approach circle skin component 2021-06-19 20:10:32 +03:00
Salman Ahmed c04b09520d Replace spinner approach circle proxying logic with hooking up to `OnSkinChange` in mod 2021-06-19 20:06:28 +03:00
Salman Ahmed d6b9436151 Proxy spinner approach circle before the spinner overlay components 2021-06-18 20:34:25 +03:00
Salman Ahmed 843c8bd7a4 Move spinner approach circle to its own `SkinnableDrawable` 2021-06-18 20:33:50 +03:00
Salman Ahmed f7b5341663 Merge branch 'master' into legacy-spinner-approach-circle 2021-06-18 19:50:52 +03:00
Bartłomiej Dach afc89b39d9 Use `StateUpdateTime` for transform clearing logic
`MainCirclePiece` specifies a state transform starting at
`StateUpdateTime`, which is earlier than the previously-used
`HitStateUpdateTime`. Change the transform clearing logic to use the
former to ensure that exactly all animation transforms are cleared.
2021-06-18 16:04:11 +02:00
Bartłomiej Dach e94fbd83e2 Ensure editor ruleset animation disable execution order 2021-06-18 16:04:11 +02:00
Bartłomiej Dach e2a370f602 Add coverage for hit circle fade-out duration 2021-06-18 16:04:11 +02:00
Dean Herbert 860626152a Mark all mods which adjust approach circle as incompatible with each other
Closes https://github.com/ppy/osu/issues/13543.
2021-06-18 13:21:53 +09:00
Salman Ahmed c9458fd9ce Hide spinner approach circle in "Hidden" mod 2021-06-18 06:23:54 +03:00
Dan Balasescu 6cec1145e3
Merge pull request #13523 from ekrctb/applicable-to-dho
Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable
2021-06-17 19:59:06 +09:00
Dean Herbert a46f730a69 Fix approach circle fade not running early on an early user hit
Regressed in https://github.com/ppy/osu/pull/12153.
Closes https://github.com/ppy/osu/issues/13531.
2021-06-17 15:09:05 +09:00
Salman Ahmed 9d9892e99e Add legacy spinner approach circle implementation 2021-06-17 04:58:18 +03:00
ekrctb 90a13b8ed3 Use `IApplicableToDrawableHitObject` for `OsuModApproachDifferent`
Replacing the obsolete interface.
2021-06-16 22:05:40 +09:00
ekrctb b6a9fa9999 Merge branch 'master' into applicable-to-dho 2021-06-16 22:04:10 +09:00
ekrctb af80418ee8 Implement `IApplicableToDrawableHitObject` for mods
A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.
2021-06-16 18:52:01 +09:00
Dean Herbert 7891ee4f32 Change order of settings to make scrolling easier
There's an issue with dropdown menus nested inside a scroll view being
very frustrating to scroll to off-screen items. This works around that
to some extent by giving the user more "parent-scrollable" space to
mouse wheel or drag over.
2021-06-16 17:32:31 +09:00
Dean Herbert 0c1023da31 Simplify transform logic 2021-06-16 17:27:52 +09:00
Dean Herbert ee5f4f1856 Remove default (and make default "Gravity") 2021-06-16 17:27:43 +09:00
Dean Herbert 4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Dean Herbert f6f1a068b2 Rename "easing" references to be "style" instead 2021-06-16 15:15:12 +09:00
Dean Herbert b1dd502e06 Rename class to match new name 2021-06-16 15:09:42 +09:00