RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
63,891 Commits 3 Branches 658 Tags 382 MiB
Commit Graph

65 Commits

Author SHA1 Message Date
Dan Balasescu 7998204cfe
Fix combo/combo colouring issues around spinners 2023-11-23 13:54:05 +09:00
Dean Herbert 3fb74cb5f9
Move helper method to `LegacyRulesetExtensions` and stop applying rounding allowance to catch 
As discussed, it isn't used in stable like this. Was a mistake.
 2023-10-20 18:57:14 +09:00
Dean Herbert 3a5490892c
Centralise and repair circle size calculations game-wide 2023-10-18 19:50:42 +09:00
ekrctb 56fb315f32 Remove #nullable disable from Catch.Objects 2023-01-15 17:29:35 +09:00
Drison64 4958421303 Moved X clamping from X to EffectiveX 2022-09-19 17:26:04 +02:00
Drison64 6d7d80a4fb Made X position value of CatchHitObject clamp to CatchPlayfield's width 2022-09-18 17:29:08 +02:00
Salman Ahmed 8f80a22ef9 Fix osu! and catch hitobjects no longer scaled to 1 by default 2022-07-19 07:00:13 +03:00
Salman Ahmed 1051009827 Change bindable properties in all `HitObject`s to be lazily initialised 2022-07-19 05:39:10 +03:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert a92d499d7a Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo` 2021-10-01 16:55:50 +09:00
Salman Ahmed 523c154f15 Add `ComboIndexWithOffsetsBindable` and bind similar to `ComboIndexBindable` 2021-07-22 16:40:33 +03:00
Dean Herbert 399c3b0be8 Rename property, reword xmldoc and improve readability of update code 2021-07-21 17:32:56 +09:00
Salman Ahmed 9d92b795fa Revert making `ComboOffset`s legacy and define `BeatmapSkinComboIndex` instead 2021-07-20 14:15:43 +03:00
Salman Ahmed 554652b033 Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset 2021-07-20 10:11:52 +03:00
ekrctb 7f432665e5 Preserve Y position of hit objects in osu!catch 2021-07-14 14:38:38 +09:00
ekrctb 175d666906 Use getters of `OriginalX` and `XOffset` 2021-07-06 15:32:32 +09:00
ekrctb ae1b1cbec9 Allow serialization of catch hit objects 2021-07-06 15:32:32 +09:00
Salman Ahmed cd6d070b4a Consider "combo offsets" as legacy logic and separate from combo information 2021-05-05 07:43:08 +03:00
ekrctb 5b5e883904 Remove EffectiveXBindable (setting Value was not handled) 
And use orthogonal `OriginalXBindable` and `XOffsetBindable`.
 2020-12-14 13:39:07 +09:00
ekrctb 0ad256a762 Fix comment 2020-12-14 13:18:32 +09:00
ekrctb d96399ea42 Revert "Remove X setter from CatchHitObject" 
This reverts commit 7cbbd74d
 2020-12-14 13:18:14 +09:00
ekrctb 7cbbd74df2 Remove X setter from CatchHitObject 2020-12-14 11:38:07 +09:00
ekrctb f621d977fc Add some more doc comment 2020-12-14 11:32:34 +09:00
ekrctb 36529bdd1b Use OriginalX for CatchHitObject.X instead of EffectiveX 
And explicitly implement IHasXPosition interface to prevent use of the X property.
It should be preferred for beatmap conversion purpose.
 2020-12-14 11:26:05 +09:00
ekrctb 089f3bebf5 Add doc comments to catch hit object X properties 2020-12-14 11:15:49 +09:00
ekrctb c1f3f1c231 Obsolete `X` getter 2020-12-14 11:03:10 +09:00
ekrctb 8da502da44 Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX 2020-12-14 11:03:03 +09:00
ekrctb fdcfa81e46 Make RandomSeed a property, not a bindable 2020-12-02 20:53:47 +09:00
ekrctb 08848e49de Set banana combo colour using random seed 2020-12-02 17:12:30 +09:00
ekrctb 5e36fb322a Move fruit visual logic from CHO to DrawableFruit 2020-11-27 11:08:32 +09:00
ekrctb c272fda416 Add bindables to catch hit objects 2020-11-27 11:02:23 +09:00
ekrctb ab7251d742 Move members to `PalpableCatchHitObject` 2020-11-24 19:57:37 +09:00
ekrctb 4f7aa7e541 Move Palpable* to separate files 2020-11-24 19:48:13 +09:00
Bartłomiej Dach 28534c1599 Reintroduce PalpableCatchHitObject at data level 2020-08-20 19:06:26 +02:00
ekrctb 3278a1d7d8 Standardize osu!catch coordinate system 
There were two coordinate systems used:
- 0..512 (used in osu!stable)
- 0..1 (relative coordinate)

This commit replaces the usage of
the relative coordinate system to
the coordinate system of 0..512.
 2020-07-02 00:21:45 +09:00
Dean Herbert 26fe15b038 Fix fruit representation not cycling as often as it should 2020-02-19 14:41:25 +09:00
Dean Herbert aeb45c8442 Fix ordering of fruits to match stable 2020-02-19 14:31:43 +09:00
Dean Herbert ab863cdfd9 Fix incorrect scaling factor being applied 2020-02-19 09:52:29 +09:00
Dean Herbert 89bff32274 Fix metrics not matching between skins and lazer 2020-02-17 19:16:40 +09:00
Dean Herbert 51bf600ea7 Use empty hitwindows instead of null 2019-10-09 19:08:31 +09:00
smoogipoo bbf0544a8d Add bindables for IHasComboInformation properties 2019-09-26 16:55:08 +09:00
Dean Herbert f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
smoogipoo 38a2b9d92b Fix multiple invocations by using a separate variable 2019-08-01 13:33:00 +09:00
Unknown 01508e6813 implement HD for CtB 2019-06-28 10:34:04 +02:00
Dean Herbert 8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
Hanamuke a17200a66a Merge branch 'master' into fix_combo 2018-09-14 18:48:13 +02:00
Hanamuke 1c2cc3837a Compute combo for nested Objects. Display fruit depending on Combo for 
osu!catch
 2018-09-13 21:52:15 +02:00
Hanamuke 7d3380db66 Fixed comment. Created static CatchArea.GetCatcheWidth method 2018-09-13 17:01:33 +02:00
Hanamuke a3c3bfb1a8 Fixes hyperdash computation (for nested objects) 2018-09-12 19:48:35 +02:00
smoogipoo 31f324945e Implement combo offsets 2018-08-15 11:47:31 +09:00