Commit Graph

149357 Commits

Author SHA1 Message Date
Ronen Friedman 801186f683
Merge pull request #60668 from ronen-fr/wip-rf-mconf
osd/scrub: cache frequently used configuration parameters

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2024-11-20 08:08:45 +02:00
Adam King c1646dd1d7
Merge pull request #60769 from gbregman/main
mgr/cephadm: Add resource limits to nvmeof configuration

Reviewed-by: Adam King <adking@redhat.com>
2024-11-19 15:07:07 -05:00
Anthony D'Atri 750fd0c314
Merge pull request #60588 from AlexonOliveiraRH/wip-doc-templates
doc/cephadm/services: Update monitoring.rst to add additional templates
2024-11-19 14:49:58 -05:00
Matan Breizman db3db9c950
Merge pull request #60598 from xxhdx1985126/wip-68808
crimson/osd/replicate_backend: add the skipped newly created clone object to the push queue after the clone request completes

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2024-11-19 18:23:00 +02:00
Ronen Friedman f92042853a common: rm the cast operator of md_config_cacher_t
as its replacement - the type-deduced operator() - is now in use,
and the resulting code is more readable and less error-prone.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-19 07:47:08 -06:00
Ronen Friedman 71de8c0acc osd: rm all uses of the cast operator of md_config_cacher_t
as this interface is to be removed in the next commit.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-19 07:44:17 -06:00
Ronen Friedman 3cd7d0226f osd/scrub: cache frequently used configuration parameters
using the md_config_cacher_t, which is a cache object that registers
itself to the config observer and caches the up-to-date configuration
value.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-19 07:37:17 -06:00
Ronen Friedman a99fa1c51e common: a simple API to extract md_config_cacher_t cached value
Using a type-deduced operator() (i.e. my_opt() ), instead of the
existing ValueT() operator (which requires a type-matching cast).

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-19 07:37:17 -06:00
Gil Bregman 1807a553f1 mgr/cephadm: Add resource limits to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68967

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
2024-11-19 13:51:37 +02:00
Gil Bregman 4269d7c152 python-common/ceph/deployment: Add resource limits to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68967

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
2024-11-19 13:51:01 +02:00
Matan Breizman c5eacfcbdb
Merge pull request #60572 from xxhdx1985126/wip-68787
crimson/osd/backfill_state: don't try to do object backfills when primary_bi is empty

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2024-11-19 13:24:23 +02:00
Ronen Friedman 29546089ee
Merge pull request #60661 from ronen-fr/wip-rf-scheduledeep
osd/scrub: fix 'schedule-deepscrub' test asok command

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2024-11-19 10:47:26 +02:00
Yuval Lifshitz 862104bb09
Merge pull request #60674 from oshrey16/bugfix-rgw-ps-list-topics-op
rgw/notification: Fix segmentation fault in RGWPSListTopicsOp::execute() and correct topic listing to use get_topics_v2

Reviewed-By: Joseph Mundackal <jmundackal@bloomberg.net>, Yuval Lifshitz <ylifshit@ibm.com>
2024-11-19 08:20:00 +02:00
Anthony D'Atri cc843c20ff
Merge pull request #60765 from zdover23/wip-doc-2024-11-19-os-recommendations
doc/start: update os-recommendations.rst
2024-11-18 20:04:55 -05:00
Zac Dover c2f1fac3b9 doc/start: update os-recommendations.rst
Remove information about the operating systems that support Ceph's
official container images from the "Platforms" table in
doc/start/os-recommendations.rst and add that information to the (new)
table that shows the operating systems that support Ceph's official
container images.

Credit for this change should go to Enrico Bocchi, who noticed a
discrepancy that motivated it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-11-19 10:37:56 +10:00
Casey Bodley 8bea3afe20
Merge pull request #60309 from linuxbox2/wip-cksum-68537
rgw_cksum:  treat mpu checksums w/o part count as valid in CompleteMu…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-11-18 11:51:32 -05:00
Soumya Koduri 4d1491dadd
Merge pull request #60711 from soumyakoduri/wip-skoduri-dbstore
rgw: Update README for DBStore and Posix drivers

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-11-18 20:31:36 +05:30
Oshrey Avraham d27dab240d rgw/notification: fix segmentation fault and topic listing logic
- Fixed a segmentation fault caused by a null bucket pointer in RGWPSListTopicsOp::execute()
- Corrected logic to use get_topics_v2 when supported, with fallback otherwise

Fixes: https://tracker.ceph.com/issues/68756
Signed-off-by: Oshrey Avraham <oshrey16@gmail.com>
2024-11-18 12:06:22 +02:00
Xuehan Xu 184c1861f8 crimson/osd/replicate_backend: add the skipped newly created clone
object to the push queue after the clone request completes

Fixes: https://tracker.ceph.com/issues/68808
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-17 19:15:21 +08:00
Yingxin 3a35aeb3a9
Merge pull request #60655 from xxhdx1985126/wip-seastore-move-out-root-meta
crimson/os/seastore: move the root meta out of the root block

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2024-11-15 16:51:05 +08:00
Yingxin 5853cb74af
Merge pull request #60209 from myoungwon/wip-init-onode-layout
crimson/os/seastore: initialize oi and ss in onode_layout_t to zero

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2024-11-15 16:50:17 +08:00
Ronen Friedman 9aab8e7446
Merge pull request #60715 from ronen-fr/wip-rf-dumpsched
osd/scrub: list additional information when dumping the queue

Reviewed-by: Samuel Just <sjust@redhat.com>
2024-11-14 15:55:36 +02:00
Guillaume Abrioux f3f2267149
Merge pull request #60727 from guits/dmcrypt-activate
ceph-volume: fix dmcrypt activation regression
2024-11-14 14:02:16 +01:00
Vallari Agrawal 4509ec2d14
Merge pull request #60404 from VallariAg/wip-nvmeof-listeners-prometheus-alerts
monitoring: add 2 nvmeof alerts to prometheus_alerts.yaml
2024-11-14 16:23:55 +05:30
Venky Shankar ef3f512306
Merge pull request #51766 from zhsgao/mds_clear_session_failed
mds: session in the importing state cannot be cleared if an export subtree task is interrupted while the state of importer is acking

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2024-11-14 12:38:35 +05:30
Vallari Agrawal 874ae379d7
Merge pull request #60067 from VallariAg/wip-nvmeof-healthcheck
mon: add nvmeof healthchecks
2024-11-14 08:40:43 +05:30
Guillaume Abrioux 3cf00cde82 ceph-volume: fix dmcrypt activation regression
`ceph.with_tpm` tag is actually a `str`, which means that
`bool('0')` will return `True`.

Fixes: https://tracker.ceph.com/issues/68944

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2024-11-13 16:23:36 +01:00
Ilya Dryomov ce0d6fccc4
Merge pull request #60554 from jshen28/fix-legacy-addr-mismatch
Make mon_info_t consistent with mon_addr

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2024-11-13 13:25:08 +01:00
Zhansong Gao 00b0711188 mds: client is evicted when an export subtree task is interrupted
The importer will force open some sessions provided by the exporter but the client does not know about
the new sessions until the exporter notifies it, and the notifications cannot be sent if the exporter
is interrupted. The client does not renew the sessions regularly that it does not know about, so the client
will be evicted by the importer after `session_autoclose` seconds (300 seconds by default).

The sessions that are forced opened in the importer need to be closed when the import process is reversed.

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 17:39:43 +08:00
Zhansong Gao f23bd5d099 qa: add test for importer's unexpected client eviction after an export subtree task is interrupted
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 17:39:16 +08:00
Zhansong Gao 057c5b1610 mds: session in the importing state cannot be cleared if an export subtree task is interrupted while the state of importer is acking
The related sessions in the importer are in the importing state(`Session::is_importing` return true) when the state of importer is `acking`,
`Migrator::import_reverse` called by `MDCache::handle_resolve` should reverse the process to clear the importing state if the exporter restarts
at this time, but it doesn't do that actually because of its bug. And it will cause these sessions to not be cleared when the client is
unmounted(evicted or timeout) until the mds is restarted.

The bug in `import_reverse` is that it contains the code to handle state `IMPORT_ACKING` but it will never be executed because
the state is modified to `IMPORT_ABORTING` at the beginning. Move `stat.state = IMPORT_ABORTING` to the end of import_reverse
so that it can handle the state `IMPORT_ACKING`.

Fixes: https://tracker.ceph.com/issues/61459
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 17:09:42 +08:00
Zhansong Gao eccaf85294 qa: add test for importer's session cleanup after an export subtree task is interrupted
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 17:09:36 +08:00
Vallari Agrawal 73d5c01ae6
qa/suites/nvmeof: add nvmeof warnings to log-ignorelist
Add NVMEOF_SINGLE_GATEWAY and NVMEOF_GATEWAY_DOWN
warnings to nvmeof:thrash job's log-ignorelist

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2024-11-13 14:26:31 +05:30
Zhansong Gao 11a4303d66 mds: the assert should be before the journal entry submit otherwise it's racy
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 16:34:36 +08:00
Zhansong Gao 79a33025d5 mds: add `importing_count` to session dump
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
2024-11-13 16:34:35 +08:00
Patrick Donnelly 584a81c686
Merge PR #60464 into main
* refs/pull/60464/head:
	mds: add or update MDS thread names
	log: cache recent threads up to a day
	common: cache pthread names
	log: concatenate thread names and print once per thread

Reviewed-by: Milind Changire <mchangir@redhat.com>
2024-11-12 22:17:59 -05:00
Patrick Donnelly 8ae8988275
Merge PR #60327 into main
* refs/pull/60327/head:
	mon/MDSMonitor: send reply to beacons with `state=DNE`

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2024-11-12 22:16:54 -05:00
Patrick Donnelly 9d2b3aaa96
Merge PR #60381 into main
* refs/pull/60381/head:
	doc: remove refrences to `mds_log_major_segment_event_ratio`
	mds: start a new major segment after reaching minor segment threshold
	mds: make parts of mdlog reusable to be used by beacon

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2024-11-12 22:14:20 -05:00
Patrick Donnelly ad153a8d19
Merge PR #60325 into main
* refs/pull/60325/head:
	mds/Beacon: wake up the thread in shutdown()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2024-11-12 22:13:46 -05:00
Patrick Donnelly 3829eb6f08
Merge PR #60283 into main
* refs/pull/60283/head:
	mds: add issue_seq to all cap messages
	include/ceph_fs: correct ceph_mds_cap_peer field name
	include/ceph_fs: correct ceph_mds_cap_item field name
	messages/MClientCaps: use correct ceph_seq_t for cap sequence types
	messages/MClientCaps: dump issue_seq for debugging
	mds: remove dead code

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2024-11-12 22:12:27 -05:00
Patrick Donnelly 5fc414b82a
Merge PR #60226 into main
* refs/pull/60226/head:
	mds/QuiesceDbEncoding: add `inline` to work around linker error

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2024-11-12 22:10:57 -05:00
Patrick Donnelly 5ad3c86046
Merge PR #58586 into main
* refs/pull/58586/head:
	qa/suites/fs/thrash: add convolve operator for overrides
	qa/cephfs: s/prefetch_dirfrags/prefetch_oft_dirfrags

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2024-11-12 22:09:30 -05:00
Zack Cerza 96a8eddc8d
Merge pull request #60675 from zmc/make-dist-quiet 2024-11-12 12:21:23 -07:00
Ronen Friedman 489eed66cd osd/scrub: list additional information when dumping the queue
Extend the information provided for operator dump commands, to
include the basic identity and scheduling information of the
entries in the scrub queue.

This change mostly benefits automatic QA and our internal
testing.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-12 08:21:25 -06:00
Soumya Koduri 4e130affe1 rgw: Update README for DBStore and Posix drivers
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2024-11-12 12:08:19 +05:30
Xuehan Xu d833431ea4 crimson/osd/replicated_backend: add the dedicated method to construct
MOSDRepOp

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-12 11:30:45 +08:00
Xuehan Xu b75dd8d333 crimson/osd/pg: add is_missing_on_peer()
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-12 11:30:45 +08:00
Xuehan Xu b6f27f8305 crimson/osd/pg: reuse already defined methods as many as possible to
improve readability

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-12 11:30:45 +08:00
Xuehan Xu 8a1fab37f2 crimson/osd/ops_executor: call OpsExecutor::apply_stats() before
OpsExecutor::obc is moved out.

OpsExecutor::apply_stats() accesses OpsExecutor::obc indirectly

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-12 11:30:21 +08:00
Xuehan Xu cbd22c7ba2 crimson/osd/pg: fix dangerous lambda captures
In PG::submit_transaction(), osd_op_p was first moved to
ReplicatedBackend::submit_transaction(), and later its at_version is
captured in another lambda. The latter may be already empty at the time
of the capture.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-12 11:30:21 +08:00