Commit Graph

149429 Commits

Author SHA1 Message Date
Samuel Just 7961b3714d crimson/osd/object_context_loader.cc: retab remaining methods
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 14be39509b crimson: InternalClientRequests require that the pg is already active
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just bd5efa44b7 crimson/.../client_request: complete_request() only in with_pg_process
This avoids needing to annotate every exit point in
with_pg_process_interruptible with complete_request.  Regardless of the
result, completing with_pg_process_interruptible without an interruption
means that the request is over.

Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 293679dbb5 crimson/.../client_request: always remove from orderer in complete_request
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just cef3f2f9b7 crimson/.../client_request: remove unnecessary get_handle().exit()
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just de2e92bc93 crimson: rewrite with_[clone_]obc[_only] via manager, remove other helpers
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 177176beab crimson: remove unused PG::with_locked_obc
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just fc8315a6df crimson: convert PG::with_locked_obc users to use obc manager
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 5f99666242 crimson: introduce RAII style obc lock mechanic
Currently, we rely on ObjectContextLoader::with_* wrappers to load,
lock, and guarrantee release of obcs.  That mechanism works well enough,
but the execution pathway is pretty tough to read as it spans
[Internal]ClientRequest, PG, ObjectContextLoader, ObjectContext, and
tri_mutex.  This mechanism cuts out PG and ObjectContext (mostly) and
uses coroutine support for auto variables to make the interface easier
to understand.

This mechanism will also allow a future PR to access the ObjectContext
state prior to loading it.  This will be important to using the
ObjectContext memory to host per-object pipeline states.

Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 737676bdb5 crimson: track obcs unconditionally
Previously, we only interrupted head obcs.  I don't think that
distinction actually makes sense -- both head and clone obcs
can have ops blocked on the lock.  Let's just track them all.

Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just 1dbd7768c0 crimson: remove ObjectContextLoader::reload_obc
Unused.

Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Samuel Just e94ad0dfff crimson/osd/object_context: add formatter for RWState::State
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-11-07 10:29:42 -08:00
Matan Breizman f55fc4599a
Merge pull request #60600 from Matan-B/wip-matanb-crimson-enable-wait
Revert "suites: crimson basic adding wait for test"

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2024-11-07 18:12:08 +02:00
Ronen Friedman ab49ca023a osd/scrub: fix 'schedule-deepscrub' test asok command
The existing implementation of the 'schedule-deepscrub' Asok
command uses the set_last_deep_scrub_stamp() method to "fake"
the last-deep-scrub stamp. Unfortunately, this method also
updates the last-scrub stamp (as required for non-test usage).

Commit 9f3e18b fixed the comparator used when sorting the
scrub targets. An unintended side effect is that
following 'schedule-deepscrub' - the shallow target
is the one to be scrubbed next, instead of the deep target.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-11-07 07:34:16 -06:00
Kushal Deb db943eef65
Fix tuned profile to allow multiple settings
Signed-off-by: Kushal Deb <Kushal.Deb@ibm.com>
2024-11-07 11:56:01 +05:30
Kefu Chai d6dfc1c2b8
Merge pull request #56771 from nh2/doc-mclock-references
doc: Document which options are disabled by mClock.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2024-11-07 13:34:04 +08:00
Anthony D'Atri 406e52faef
Merge pull request #60642 from yuvalif/wip-yuval-68858
doc/rgw/notification: clarified the notification_v2 behavior upon upgrade
2024-11-06 15:12:15 -05:00
Zac Dover f6b56f9ee5 doc/cephadm: clean "Adv. OSD Service Specs"
Clean the English grammar and the .RST in the section "Advanced OSD
Service Specifications" in the file doc/cephadm/services/osd.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-11-07 02:16:22 +10:00
Zac Dover 06cbecd930
Merge pull request #60643 from zdover23/wip-doc-2024-11-06-cephadm-osd-host-pattern-matching
doc/cephadm: link to "host pattern" matching sect

Reviewed-by: Adam King <adking@redhat.com>
2024-11-07 01:56:01 +10:00
Yuri Weinstein 6af80fca00
Merge pull request #60132 from li-positiveandfocus/wip-67820-lj
qa/tasks: added "is down" warning to thrash-old-clients ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>
2024-11-06 07:35:26 -08:00
Yuri Weinstein 29df6b129e
Merge pull request #60071 from shraddhaag/fix-mon-cluster-log-test
qa/standalone/mon/mon_cluster_log.sh: retry check for log line

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2024-11-06 07:34:58 -08:00
Yuri Weinstein 80c29ae812
Merge pull request #59855 from NitzanMordhai/wip-nitzan-expected-failure-wait-osd-down
qa/tasks/ceph: wait the osds down before start check the logs

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2024-11-06 07:33:58 -08:00
Zac Dover cdfa299a25 doc/cephadm: link to "host pattern" matching sect
Link to the "Placement by Pattern Matching" section in
doc/cephadm/services/index.rst from the "Advanced OSD Service
Specifications" section in doc/cephadm/services/osd.rst.

Fixes: https://tracker.ceph.com/issues/68812

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-11-06 22:22:14 +10:00
Yuval Lifshitz fccf7fd25e doc/rgw/notification: clarified the notification_v2 behavior upon upgrade
Fixes: https://tracker.ceph.com/issues/68858

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2024-11-06 11:51:54 +00:00
Ilya Dryomov 0d0bbbe920
Merge pull request #60622 from idryomov/wip-spdk-submodule
spdk: update submodule to fix build with newer glibc

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
2024-11-06 12:29:53 +01:00
SrinivasaBharathKanta 1017b1d230
Merge pull request #59743 from sseshasa/wip-fix-mclock-low-iops-capacity-threshold
common,osd: Use last valid OSD IOPS value if measured IOPS is unrealistic
2024-11-06 15:46:54 +05:30
Mohit Agrawal 0f0089472c TEST_backfill_grow fails after finding "num_bytes mismatch" in osd log
Need to ignore "num_bytes mismatch" messages during throw backfill/recovery
progress.

Fixes: https://tracker.ceph.com/issues/68585
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
2024-11-06 15:27:53 +05:30
Zac Dover f94ff6063f
Merge pull request #56599 from rhkelson/patch-2
doc/cephadm: Update operations.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Adam King <adking@redhat.com>
2024-11-06 19:39:42 +10:00
shenjiatong 14b0951973 Make mon addrs consistent with mon info
For legacy librbd clients, sanitize_mons will panic if addrs are not
consistent with mon_info_t.

Signed-off-by: shenjiatong <yshxxsjt715@163.com>
fixes: https://tracker.ceph.com/issues/68743
2024-11-06 17:27:21 +08:00
Nizamudeen A 9272d438a7
Merge pull request #60602 from rhcs-dashboard/cherrypy-version-get-fix
mgr/dashboard: remove cherrypy_backports.py

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-11-06 10:21:30 +05:30
rhkelson 34bc35a734 doc/cephadm: Update operations.rst
Fixed typo 'no' to 'not' in sentence "If this test fails, cephadm will
no be able to manage services on that host."

Signed-off-by: rhkelson <119636079+rhkelson@users.noreply.github.com>
2024-11-06 10:34:47 +10:00
Kamoltat (Junior) Sirivadhna 28e38e30bb
Merge pull request #59483 from kamoltat/wip-ksirivad-exit-stretch-mode
mon [stretch mode]: support disable_stretch_mode
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2024-11-05 13:07:06 -05:00
Matan Breizman a91bcae9f5
Merge pull request #56832 from Matan-B/wip-matanb-crimson-recovery-version
crimson/osd/pg: introduce projected_log
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
2024-11-05 18:02:17 +02:00
Gal Salomon 141b675b0b hiding parquet dependencies upon parquet-select option is off
Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
2024-11-05 17:30:12 +02:00
Venky Shankar 4e355cead8 Merge PR #58847 into main
* refs/pull/58847/head:
	ceph-fuse: Improve fuse mount usage message

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2024-11-05 18:06:53 +05:30
leonidc 3f1b0feb0f
Merge pull request #60559 from leonidc/wip-leonidc-no-listeners-fix
fix no-listeners FSM , detect no-listeners
2024-11-05 14:20:11 +02:00
Matan Breizman 0a76ec3855 test/crimson/test_backfill: support projected log and pg log
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-11-05 09:47:22 +00:00
Matan Breizman 7a2db2f46e crimson/osd/pg: introduce projected_log
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-11-05 09:47:22 +00:00
Ilya Dryomov 77dd0027ba spdk: update spdk submodule to fix build with newer glibc
Pick up a change that introduced CONFIG_HAVE_ARC4RANDOM to allow
building with glibc 2.36 and newer.

Fixes: https://tracker.ceph.com/issues/67843
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2024-11-05 10:45:27 +01:00
Aashish Sharma 9eaff51b9d
Merge pull request #60100 from piyushagarwal1411/fix-68316-main
mgr/dashboard: Add 'Browse Dashboards' button in multi-cluster and ceph-cluster Grafana dashboards

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2024-11-05 15:09:52 +05:30
afreen23 66e6a8675b
Merge pull request #60017 from rhcs-dashboard/kcli-quick-install
mgr/dashboard: improve the kcli bootstrap process

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2024-11-05 12:41:03 +05:30
Nizamudeen A 7ae56f4f56 mgr/dashboard: remove cherrypy_backports.py
since its mostly used only for older cherrypy versions which we don't
support anymore in any of our recent upstream releases, we could remove
it completely

Fixes: https://tracker.ceph.com/issues/68802
Signed-off-by: Nizamudeen A <nia@redhat.com>
2024-11-05 09:52:40 +05:30
Zack Cerza 681a75e949
Merge pull request #60577 from zmc/rpm-dwz-toggle 2024-11-04 15:26:27 -07:00
Max Kellermann df422f9f25 include/str_list: remove unnecessary #include
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann dcb6c4a30b common/error_code: remove unused includes
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann cd95497f03 common/perf_counters: forward-declare class utime_t
And add a few missing includes.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann b9ffdba1a7 common/DecayCounter: forward-declare ceph::Formatter
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann 9615c04d7d common/Thread: include cleanup
This header uses `std::string`, but not `std::system_error`.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann f7ee8b122d common/Journald: add missing include
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00
Max Kellermann 85f9521b4e common/StackStringStream: remove unused includes
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2024-11-04 22:31:06 +01:00