Additionally, remove the image defaults from the two previous locations
and update the check for the number of instances of "quay" and "docker"
in these areas respectively.
Fixes: https://tracker.ceph.com/issues/68120
Signed-off-by: Adam King <adking@redhat.com>
We want to use this location for files to be shared between
the cephadm binary and cephadm mgr module so it must be included
as part of the zipapp
Signed-off-by: Adam King <adking@redhat.com>
CODEOWNERS: let orchestration cover all of python-common
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
While working on the smb.py file I began to be annoyed at the Config
class and the need to repeat myself. Now that cephadm is not expected to
run on python versions older than 3.7 I think it's safe to convert
Config to use a dataclass.
While making the change to a dataclass I also chose to make it a frozen
dataclass to help eliminate any future bugs wrt mutating the config object.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
During shutdown, the MDS sends a `MSG_MDS_BEACON` with
`MDSMap::STATE_DNE` (in `MDSDaemon::suicide()`) and then waits for a
`MSG_MDS_BEACON` reply from the MON.
The MON, however, suppresses replies to `STATE_DNE`; in
`MDSMonitor::preprocess_beacon()`, it returns early on `STATE_DNE` and
`MDSMonitor::prepare_beacon()` silently evicts the dying MDS without
any reply.
This delays the MDS shutdown until the MDS times out.
Since `MDSDaemon::suicide()` has code to wait for a beacon reply, I
figure that the MON reply was suppressed accidently, therefore I
suggest adding it.
Fixes: https://tracker.ceph.com/issues/68761
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
While it's not perfectly correct to say the orchestration team owns
src/python-common, it's closer to the truth than not. It also ensures
that someone with domain specific knowledge is looking at the rest of
python-common outside just the deployment section (short of creating
some sort of new python-sig type group). This is relevant due to the
changes in PR #60377 as python-common's ceph package will be included
in cephadm.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This eliminates the `wait_for()` delay and speeds up MDS shutdown.
Fixes: https://tracker.ceph.com/issues/68759
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
The reverted commit unconditionally copies the Info
data from the primary-info message to the replica,
causing multiple tests failures.
For example:
compare the failures in
https://pulpito.ceph.com/?branch=wip-rf-store2-steps
to
https://pulpito.ceph.com/?branch=wip-rf-store2-steps-reverted
(with said PR reverted).
Revert "src/osd: pg stat are not synced between osds after deep-scrub. So if primary osd is killed, next primary osd has wrong stats. Reason behind it is PeeringState::proc_primary_info does not process or update any pg stats."
This reverts commit a24f3cf1e9.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
* refs/pull/60010/head:
script/ceph-debug-docker: add debuginfod for ubuntu
script/ceph-debug-docker: drop /ceph mount
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
doc/dev/crimson: Add BackfillMachine state graph
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
osd/scrub: improve scrub information conveyed in standard
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
qa/suites/orch: add a tests for testing public_addr for smb cluster create cmd
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King
Yuri Weinstein
Casey Bodley
Adam King
Gil Bregman
Milind Changire
Zac Dover
afreen23
Venky Shankar
John Mulligan
Max Kellermann
Ernesto Puerta
Dnyaneshwari
Patrick Donnelly
Anthony D'Atri
Gil Bregman
Ronen Friedman
Matan Breizman
Jos Collin