Arve Knudsen
6ef1eb4e68
Merge pull request #14064 from aknuds1/arve/close-engine
...
Release PromQL engine resources on close, from tests
2024-09-04 12:07:35 +02:00
Joshua Hesketh
f2064c7987
NH: Do not re-use spans between histograms ( #14771 )
...
promql, tsdb (histograms): Do not re-use spans between histograms
When multiple points exist with the same native histogram schemas they
share their spans.
This causes a problem when a native histogram (NH) schema is modified (for example, during
a Sum) then the other NH's with the same spans are also modified. As such,
we should create a new Span for each NH. This will ensure NH's interfaces
are safe to use without considering the effect on other histograms.
At the moment this doesn't present itself as a problem because in all
aggregations and functions operating on native histograms they are copied
by the promql query engine first.
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
---------
Signed-off-by: Joshua Hesketh <josh@nitrotech.org>
2024-09-04 12:07:16 +02:00
George Krajcsovits
282fb1632a
Merge pull request #14772 from krajorama/fix-mockseriesiterator
...
Fix: chunkenc.MockSeriesIterator
2024-09-03 16:55:26 +02:00
Björn Rabenstein
4ffb74dae4
Merge pull request #14810 from bboreham/fix-proto-parse-exemplar
...
[BUGFIX] Protobuf scraping: reset exemplar position
2024-09-03 15:05:59 +02:00
Julien
18cafabeb0
Merge pull request #14779 from prometheus/dependabot/github_actions/actions/setup-node-4.0.3
...
Bump actions/setup-node from 4.0.2 to 4.0.3
2024-09-03 13:35:22 +02:00
Julien
5397657e1a
Merge pull request #14790 from prometheus/dependabot/go_modules/github.com/envoyproxy/protoc-gen-validate-1.1.0
...
Bump github.com/envoyproxy/protoc-gen-validate from 1.0.4 to 1.1.0
2024-09-03 13:28:06 +02:00
Julien
272118c38c
Merge pull request #14789 from prometheus/dependabot/go_modules/github.com/ionos-cloud/sdk-go/v6-6.2.1
...
Bump github.com/ionos-cloud/sdk-go/v6 from 6.2.0 to 6.2.1
2024-09-03 13:27:34 +02:00
Julien
3b291c9411
Merge pull request #14799 from prometheus/dependabot/go_modules/github.com/prometheus/client_golang-1.20.2
...
Bump github.com/prometheus/client_golang from 1.20.0 to 1.20.2
2024-09-03 13:27:19 +02:00
Julien
e86729a0f0
Merge pull request #14800 from prometheus/dependabot/go_modules/golang.org/x/oauth2-0.22.0
...
Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0
2024-09-03 13:26:35 +02:00
Julien
76775d58f8
Merge pull request #14784 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/common-0.57.0
...
Bump github.com/prometheus/common from 0.55.0 to 0.57.0 in /documentation/examples/remote_storage
2024-09-03 13:18:25 +02:00
dependabot[bot]
e896643403
Bump actions/setup-node from 4.0.2 to 4.0.3
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...1e60f620b9
2024-09-03 11:14:58 +00:00
Julien
f3968ca60e
Merge pull request #14776 from prometheus/dependabot/github_actions/github/codeql-action-3.26.6
...
Bump github/codeql-action from 3.25.15 to 3.26.6
2024-09-03 13:14:14 +02:00
Julien
e3f356a53f
Merge pull request #14777 from prometheus/dependabot/github_actions/prometheus/promci-0.3.0
...
Bump prometheus/promci from 0.1.0 to 0.3.0
2024-09-03 13:14:01 +02:00
Julien
a4f30a687c
Merge pull request #14778 from prometheus/dependabot/github_actions/bufbuild/buf-setup-action-1.39.0
...
Bump bufbuild/buf-setup-action from 1.35.1 to 1.39.0
2024-09-03 13:13:15 +02:00
Arve Knudsen
70bb219d33
Merge pull request #14680 from charleskorn/promqltest-scalar
...
promqltest: improve error messages when unexpected type is returned, and fix inverted expected and actual values in error message
2024-09-03 10:38:04 +02:00
Julien
93f27409cd
Merge pull request #14660 from roidelapluie/customheaders
...
Add documentation for custom headers.
2024-09-03 10:19:01 +02:00
Bartlomiej Plotka
f1d3c3f464
fix: Properly put OM text p.CreatedTimestamp behind feature flag ( #14809 ) ( #14815 )
...
Mitigates https://github.com/prometheus/prometheus/issues/14808
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Co-authored-by: Manik Rana <Manikrana54@gmail.com>
2024-09-03 07:33:44 +01:00
Arthur Silva Sens
442f24e099
chore: Simplify TestHeadAppender_AppendCTZeroSample ( #14812 )
...
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2024-09-02 21:30:37 +01:00
Arve Knudsen
2cfc7b244a
Merge pull request #14700 from shandongzhejiang/main
...
Comments: fix some function names
2024-09-02 18:59:28 +02:00
Oleg Zaytsev
ce7d830f1f
Bring back BenchmarkLoadRealWLs ( #14757 )
...
This was part of #14525 which was reverted.
I still think that having this benchmark committed in to the repo is
useful.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-09-02 17:20:10 +01:00
Bryan Boreham
d599c4b28c
[BUGFIX] Protobuf scraping: reset exemplar position
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-02 16:43:50 +01:00
Bryan Boreham
3aaf2c3c9d
[TESTS] Add second native histogram with exemplars in TestProtobufParse
...
This test fails.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-02 16:43:50 +01:00
Bryan Boreham
e8ecc11816
[TESTS] Fix up item numbers in TestProtobufParse
...
If an error is thrown by the test, these numbers help you see which item is wrong.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-09-02 16:43:49 +01:00
Arve Knudsen
5dfbcc390e
Merge remote-tracking branch 'prometheus/main' into arve/close-engine
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-09-02 16:26:59 +02:00
dependabot[bot]
6c08f8f559
Bump github.com/ionos-cloud/sdk-go/v6 from 6.2.0 to 6.2.1
...
Bumps [github.com/ionos-cloud/sdk-go/v6](https://github.com/ionos-cloud/sdk-go ) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/ionos-cloud/sdk-go/releases )
- [Changelog](https://github.com/ionos-cloud/sdk-go/blob/master/docs/CHANGELOG.md )
- [Commits](https://github.com/ionos-cloud/sdk-go/compare/v6.2.0...v6.2.1 )
---
updated-dependencies:
- dependency-name: github.com/ionos-cloud/sdk-go/v6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-02 12:06:35 +00:00
Julien
7dd74ca6b7
Merge pull request #14802 from prometheus/dependabot/go_modules/github.com/hashicorp/consul/api-1.29.4
...
Bump github.com/hashicorp/consul/api from 1.29.2 to 1.29.4
2024-09-02 14:05:08 +02:00
Julien
f19c2e7fa4
Merge pull request #14805 from prometheus/dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.13.1
...
Bump github.com/hetznercloud/hcloud-go/v2 from 2.12.0 to 2.13.1
2024-09-02 14:04:52 +02:00
Bryan Boreham
28a830ed9f
Merge pull request #14768 from bboreham/improve-almost
...
[COMMENT] Improve comment on almost.Equal; add tests
2024-09-02 09:33:29 +01:00
dependabot[bot]
02d1cabd0a
Bump github.com/hetznercloud/hcloud-go/v2 from 2.12.0 to 2.13.1
...
Bumps [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go ) from 2.12.0 to 2.13.1.
- [Release notes](https://github.com/hetznercloud/hcloud-go/releases )
- [Changelog](https://github.com/hetznercloud/hcloud-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/hetznercloud/hcloud-go/compare/v2.12.0...v2.13.1 )
---
updated-dependencies:
- dependency-name: github.com/hetznercloud/hcloud-go/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:50:13 +00:00
dependabot[bot]
fae66d0bba
Bump github.com/hashicorp/consul/api from 1.29.2 to 1.29.4
...
Bumps [github.com/hashicorp/consul/api](https://github.com/hashicorp/consul ) from 1.29.2 to 1.29.4.
- [Release notes](https://github.com/hashicorp/consul/releases )
- [Changelog](https://github.com/hashicorp/consul/blob/main/CHANGELOG.md )
- [Commits](https://github.com/hashicorp/consul/compare/api/v1.29.2...api/v1.29.4 )
---
updated-dependencies:
- dependency-name: github.com/hashicorp/consul/api
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:49:48 +00:00
dependabot[bot]
c09f6f80c6
Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0
...
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2 ) from 0.21.0 to 0.22.0.
- [Commits](https://github.com/golang/oauth2/compare/v0.21.0...v0.22.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:49:32 +00:00
dependabot[bot]
6290287c1c
Bump github.com/prometheus/client_golang from 1.20.0 to 1.20.2
...
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ) from 1.20.0 to 1.20.2.
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.20.0...v1.20.2 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:49:28 +00:00
dependabot[bot]
40e6188b6d
Bump github.com/envoyproxy/protoc-gen-validate from 1.0.4 to 1.1.0
...
Bumps [github.com/envoyproxy/protoc-gen-validate](https://github.com/envoyproxy/protoc-gen-validate ) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/envoyproxy/protoc-gen-validate/releases )
- [Changelog](https://github.com/bufbuild/protoc-gen-validate/blob/main/.goreleaser.yaml )
- [Commits](https://github.com/envoyproxy/protoc-gen-validate/compare/v1.0.4...v1.1.0 )
---
updated-dependencies:
- dependency-name: github.com/envoyproxy/protoc-gen-validate
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:48:48 +00:00
dependabot[bot]
8dd49103ba
Bump github.com/prometheus/common
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.55.0 to 0.57.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md )
- [Commits](https://github.com/prometheus/common/compare/v0.55.0...v0.57.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 23:15:51 +00:00
dependabot[bot]
8789a124bc
Bump bufbuild/buf-setup-action from 1.35.1 to 1.39.0
...
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action ) from 1.35.1 to 1.39.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases )
- [Commits](aceb106d24...54abbed4fe
2024-09-01 23:07:57 +00:00
dependabot[bot]
b2bb0d458b
Bump prometheus/promci from 0.1.0 to 0.3.0
...
Bumps [prometheus/promci](https://github.com/prometheus/promci ) from 0.1.0 to 0.3.0.
- [Release notes](https://github.com/prometheus/promci/releases )
- [Commits](3cb0c3871f...45166329da
2024-09-01 23:07:53 +00:00
dependabot[bot]
471fb8c978
Bump github/codeql-action from 3.25.15 to 3.26.6
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.15 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](afb54ba388...4dd16135b6
2024-09-01 23:07:51 +00:00
Suraj Nath
a35b15cea8
chore: migrate stale check to use stale github action ( #14650 )
...
- chore: migrate stale check to use stale github action
- add stale check in list of files to sync
- pin to SHA of github action
- only run in prometheus and prometheus-community orgs
Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
2024-09-01 21:22:36 +05:30
György Krajcsovits
a693dd19f2
Fix: chunkenc.MockSeriesIterator
...
Starts its index from 0 , but users call Next() before first sample
so it needs to start from -1
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2024-08-30 16:44:36 +02:00
machine424
d23d196db5
fix(discovery): prevent the manager from storing stale targetGroups
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-08-30 14:39:31 +02:00
Julien
d63f5b35df
Merge pull request #14765 from kevinrawal/kevinrawal/fix-broken-url-for-feature-flag
...
Fix: Broken URL for Querying Prometheus
2024-08-30 11:49:22 +02:00
Arve Knudsen
bc6c2c5d35
OTLP Receiver: Add tests ( #14764 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-08-30 11:30:57 +02:00
Bryan Boreham
d550c4a0b9
[COMMENT] Improve comment on almost.Equal; add tests
...
At first it wasn't obvious to me why the first check would give a
different result to the second.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-08-30 10:13:00 +01:00
Callum Styan
a77f5007f9
fix bug with metadata for rw2 ( #14766 )
...
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2024-08-30 08:14:20 +01:00
Arthur Silva Sens
ee2b7fdf9d
Merge pull request #14760 from bboreham/simplify-otel-time-conversion
...
[REFACTOR] OTLP translator: simplify time conversion
2024-08-29 17:39:43 -03:00
Kevin Rawal
b0677263c3
Update basics.md
...
fix broken URL for feature flags native histograms in querying prometheus documentation
Signed-off-by: Kevin Rawal <84058124+kevinrawal@users.noreply.github.com>
2024-08-29 23:06:31 +05:30
Neeraj Gartia
8c7bf39d96
Moves TestNativeHistogram_MulDivOperator to promql testing framework ( #14688 )
...
PromQL: add test for mul and div operator
Also, remove the converted test from the engine_test.go file.
This also includes an extension of the test framework to allow NaN/Inf in histogram buckets.
---------
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
2024-08-29 16:42:35 +02:00
Jorge Creixell
e9e3d64b7c
PromQL engine: Delay deletion of __name__ label to the end of the query evaluation ( #14477 )
...
PromQL engine: Delay deletion of __name__ label to the end of the query evaluation
- This change allows optionally preserving the `__name__` label via the `label_replace` and `label_join` functions, and helps prevent the dreaded "vector cannot contain metrics with the same labelset" error.
- The implementation extends the `Series` and `Sample` structs with a boolean flag indicating whether the `__name__` label should be deleted at the end of the query evaluation.
- The `label_replace` and `label_join` functions can still access the value of the `__name__` label, even if it has been previously marked for deletion. If `__name__` is used as target label, it won't be dropped at the end of the query evaluation.
- Fixes https://github.com/prometheus/prometheus/issues/11397
- See https://github.com/jcreixell/prometheus/pull/2 for previous discussion, including the decision to create this PR and benchmark it before considering other alternatives (like refactoring `labels.Labels`).
- See https://github.com/jcreixell/prometheus/pull/1 for an alternative implementation using a special label instead of boolean flags.
- Note: a feature flag `promql-delayed-name-removal` has been added as it changes the behavior of some "weird" queries (see https://github.com/prometheus/prometheus/issues/11397#issuecomment-1451998792 )
Example (this always fails, as `__name__` is being dropped by `count_over_time`):
```
count_over_time({__name__!=""}[1m])
=> Error executing query: vector cannot contain metrics with the same labelset
```
Before:
```
label_replace(count_over_time({__name__!=""}[1m]), "__name__", "count_$1", "__name__", "(.+)")
=> Error executing query: vector cannot contain metrics with the same labelset
```
After:
```
label_replace(count_over_time({__name__!=""}[1m]), "__name__", "count_$1", "__name__", "(.+)")
=>
count_go_gc_cycles_automatic_gc_cycles_total{instance="localhost:9090", job="prometheus"} 1
count_go_gc_cycles_forced_gc_cycles_total{instance="localhost:9090", job="prometheus"} 1
...
```
Signed-off-by: Jorge Creixell <jcreixell@gmail.com>
---------
Signed-off-by: Jorge Creixell <jcreixell@gmail.com>
Signed-off-by: Björn Rabenstein <github@rabenste.in>
2024-08-29 15:50:39 +02:00
Bryan Boreham
5359567264
Merge pull request #14729 from bboreham/multimeta
...
TSDB: streamline reading of overlapping head chunks
2024-08-29 14:11:45 +01:00
Bryan Boreham
f90c7a11d1
[REFACTOR] OTLP translator: simplify time conversion
...
We don't need multiple levels of abstraction to convert nanoseconds to
milliseconds.
We do benefit from tests, however.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-08-29 12:00:01 +01:00
