RepoMirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus synced 2024-12-29 02:02:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
13,574 Commits 243 Branches 0 Tags 653 MiB
6ef1eb4e68
Commit Graph

13574 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Suraj Nath
74c1af3fd5 address review comments 
Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
 2024-08-12 23:36:48 +05:30
Lukasz Mierzwa
7694c89497 Increase TestHangingNotifier timeout 
This test keeps timing out on our arm64 CI server, it does use a very slow timeout and that 5ms doesn't seem to be enough.
But it 10x.

Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
 2024-08-12 14:53:08 +01:00
György Krajcsovits
6aee5b4b38 fix typo 
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-12 12:04:45 +02:00
György Krajcsovits
06a8886b94 Native histograms: define behavior when rate is null. 
Histogram quantile returns NaN in this case, which might be
surprising, so add a unit test that clarifies that this is
intentional.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-12 10:40:21 +02:00
suntala
532904a1d6 Document changes to sort by label 
Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com>
Signed-off-by: suntala <arati.rana@grafana.com>
 2024-08-11 21:44:03 +02:00
suntala
fd2f44af7f Fall back to comparing by label set when sorting by label desc 
Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com>
Signed-off-by: suntala <arati.rana@grafana.com>
 2024-08-11 21:44:03 +02:00
suntala
94ad489328 Fall back to comparing by label set when sorting by label 
Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com>
Signed-off-by: suntala <arati.rana@grafana.com>
 2024-08-11 21:44:03 +02:00
Suraj Nath
a3b36c1225 pin to SHA of github action 
Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
 2024-08-09 23:06:11 +05:30
Suraj Nath
5dcaaee72a add stale check in list of files to sync 
Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
 2024-08-09 23:01:16 +05:30
Suraj Nath
7f0254da29 chore: migrate stale check to use stale github action 
Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
 2024-08-09 23:01:16 +05:30
Arve Knudsen
5fd66ba855
Merge pull request #14510 from aknuds1/arve/add-normalize-name-tests 
otlptranslator: Add tests for BuildCompliantName
 2024-08-09 18:21:16 +02:00
machine424
82f38d3e9a
fix(tsdb/db_test.go): close the corrupted chunk after creating it to satisfy Windows FS 
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-08-09 14:53:57 +02:00
Bryan Boreham
5354e87a70
Merge pull request #14644 from prometheus/prep-2.54.0 
Cut release 2.54.0
 2024-08-09 12:34:14 +01:00
Bryan Boreham
8978f3ef71 Cut release 2.54.0 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-08-09 12:07:28 +01:00
Julien
616038f2b6
Merge pull request #14553 from prometheus/dependabot/go_modules/github.com/aws/aws-sdk-go-1.55.5 
build(deps): bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5
 2024-08-09 12:06:36 +02:00
Julien
7b0f6f1aed
Merge pull request #14573 from prometheus/dependabot/github_actions/scripts/actions/setup-go-5.0.2 
build(deps): bump actions/setup-go from 5.0.1 to 5.0.2 in /scripts
 2024-08-09 12:06:05 +02:00
Julien
c210917b91
Merge pull request #14571 from prometheus/dependabot/github_actions/actions/upload-artifact-4.3.4 
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4
 2024-08-09 12:05:37 +02:00
Julien
4387de8189
Merge pull request #14568 from prometheus/dependabot/github_actions/bufbuild/buf-setup-action-1.35.1 
build(deps): bump bufbuild/buf-setup-action from 1.34.0 to 1.35.1
 2024-08-09 12:05:24 +02:00
Charles Korn
f992f81bd0
Merge branch 'main' into sum-and-avg-over-mixed-custom-exponential-histograms 
Signed-off-by: Charles Korn <charleskorn@users.noreply.github.com>
 2024-08-09 13:58:54 +10:00
Charles Korn
5cfdde327c
Address PR feedback: add extra test case 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-09 13:57:37 +10:00
Charles Korn
82bb35fabb
Address PR feedback: fix typo and rename variable 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-09 13:51:31 +10:00
George Krajcsovits
cf62fb5c44
Merge pull request #14629 from krajorama/fix-to-encoded-chunks 
Fix ToEncodedChunks minT for recoded chunks
 2024-08-08 20:00:31 +02:00
György Krajcsovits
1ea3781699 Fix ToEncodedChunks minT for recoded chunks 
Discovered while working on #14546 OOO native histograms.
Not triggered on main before #14546 as the code path is unused.

There was a bug where the min time of a chunk was adjusted even
if it was only recoded and not completely new.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-08 15:22:46 +02:00
Björn Rabenstein
b5cdb4e479
Merge pull request #14628 from prometheus/beorn7/doc 
docs: Be more explicit about `promql-experimental-functions`
 2024-08-08 15:00:04 +02:00
Julien
5857888926
Merge pull request #14570 from prometheus/dependabot/github_actions/golangci/golangci-lint-action-6.1.0 
build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0
 2024-08-08 14:45:43 +02:00
Julien
339889f60f
Merge pull request #14567 from prometheus/dependabot/github_actions/ossf/scorecard-action-2.4.0 
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0
 2024-08-08 14:44:46 +02:00
Julien
d7e4ba6cf1
Merge pull request #14566 from prometheus/dependabot/github_actions/actions/setup-go-5.0.2 
build(deps): bump actions/setup-go from 5.0.1 to 5.0.2
 2024-08-08 14:43:55 +02:00
beorn7
2360ce8d2b docs: Be more explicit about promql-experimental-functions 
We have not mentioned that experimental PromQL functions might get
removed entirely, although that's one of the most important properties
of functions declared experimental.

Signed-off-by: beorn7 <beorn@grafana.com>
 2024-08-08 14:37:29 +02:00
Björn Rabenstein
41f8a0223c
Merge pull request #14609 from charleskorn/rate-over-mixed-custom-exponential-histograms 
promql: fix "cannot reduce resolution to custom buckets schema" panic in `rate` over native histograms with mix of custom and exponential buckets
 2024-08-08 14:03:41 +02:00
Manik Rana
02c465bf58
textparse: Implement CreatedTimestamp() in openmetricsparse.go (#14356) 
* feat: initial implement of createedTimestamp() with tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: return ct after finding it

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove unneeded test

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: multiple changes

- implement changes from pair programming session
- use newParse.val()
- advance parser p if ct is found

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: check if err from p.Next()

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: advance parser and parse histograms + summary

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: restore previous tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: retore failing tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove unneeded comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: return nil when mtype doesn't match

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: update go fmt version

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: cleanup

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: document deepcopyparser

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: cover edgecase of `gauge_created` in CreatedTimestamp()

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: readability updates

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: dedeuplicate labeldiff checks

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* tests: add tests for new label functions

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: document CreatedTimestamp func

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: optimize `CreatedTimestamp()`

 - Use refactored CreatedTimestamp function with bug fixes
 - Remove unused code in labels.go
 - Improve code documentation

 Signed-off-by: Manik Rana <manikrana54@gmail.com>

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add tests and lint fixes

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove mName

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* tests: add tests for CT parse failures and deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: edit expectCT struct

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add new label in deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: use p.builder in deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: add NewMetricsParserWithOpts

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* chore: comments

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* chore: rename var

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: add condition for OM fuzzing

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: build tags

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: default skipCT to false

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: rename skipCT to skipCTSeries

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: formatting

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments and readability updates

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* refac: remove NewOpenMetricsParserWithOpts

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: extract skipCTSeries logic from parseMetricSuffix

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: inline create a NewOpenMetricsParser

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* refac: improve error handling

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: return error instead of nil

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: remove skipCT check from tBraceOpen

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* Pair programming with Manik, Arthur and Daniel.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* chore: comments and use helper funcs

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

---------

Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2024-08-08 12:35:35 +01:00
Ben Ye
b7a58dcf3d
Add hidden flag to disable overlapping compaction (#14581) 
TSDB: add hidden flag to disable overlapping compaction

Signed-off-by: Ben Ye <benye@amazon.com>

---------

Signed-off-by: Ben Ye <benye@amazon.com>
 2024-08-08 12:09:39 +02:00
George Krajcsovits
1d7fe4be5c Update promql/engine.go 
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
 2024-08-08 09:12:15 +02:00
György Krajcsovits
1fb0ff7e45 Add unit test 
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-08 09:12:11 +02:00
György Krajcsovits
909785b97f Fix histogram pool poisoning bu chunkenc.Iterator 
chunkenc.Iterator.AtFloatHistogram may do a shallow copy if
it receives nil as input pointer. This can in turn share the
span slice with multiple histograms in the matrixSelectorHPool,
leading to unexpected errors.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-08 09:12:02 +02:00
Filip Petkovski
8f9751b00d Use CopyTo when resetting histogram in stats iterator 
The histogram stats iterator does not fully clear the histogram object
and is not resilient to new fields being added to the histogram type.

To resolve the issue, the commit uses the CopyTo methods which should
be future proof to new fields being added.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
 2024-08-08 09:05:21 +02:00
Filip Petkovski
02d9d874a2 Add more test cases 
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
 2024-08-08 08:57:01 +02:00
Filip Petkovski
6100e756a8 Ignore stale histograms for counter reset detection 
The histogram stats decoder keeps track of the last seen histogram sample
in order to properly detect counter resets. We are seeing an issue where
a histogram with UnknownResetHint gets treated as a counter reset when it follows
a stale histogram sample.

I believe that this is incorrect since stale samples should be completely ignored
in PromQL. As a result, they should not be stored in the histogram stats iterator
and the counter reset detection needs to be done against the last non-stale sample.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
 2024-08-08 08:56:55 +02:00
Charles Korn
f91009aa2e
promql: clarify error message when panic occurs during query evaluation 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-08 09:11:38 +10:00
Björn Rabenstein
27579c9148
Merge pull request #14605 from krajorama/fix-staleness-pool-corrupt 
Fix histogram pool poisoning bug chunkenc.Iterator
 2024-08-07 21:02:08 +02:00
George Krajcsovits
17b0b788da
Update promql/engine.go 
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
 2024-08-07 20:15:46 +02:00
Arthur Silva Sens
f74d448c69
Merge pull request #14516 from freak12techno/use-humanize-duration-from-common 
chore: use HumanizeDuration and ConvertToFloat from prometheus/common
 2024-08-07 14:01:03 -03:00
George Krajcsovits
3a673cd0bc
Merge pull request #14598 from krajorama/fix-compaction-panic 
Fix: panic: runtime error: index out of range [4] with length 4
 2024-08-07 17:14:14 +02:00
machine424
92873d3009 feat: allow to delay head compaction start time helping Prometheus instances to 
avoid simultaneous compactions and reduce stress on shared resources.

This is enabled via `--enable-feature=delayed-compaction`.

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
 2024-08-07 17:10:27 +02:00
Oleg Zaytsev
0833d2a230
Fix appendable: check whether last val was a histogram (#14613) 
* Fix appendable: check whether last val was a histogram

When appending a float, we were checking whether lastValue was equal to
current value, but we didn't check whether last value was a float value.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-08-07 15:02:59 +02:00
Charles Korn
0f4bc87b4f
Make linter happy 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-07 15:35:06 +10:00
Charles Korn
f07b3ae67b
Fix issue where avg over mixed exponential and custom buckets, or incompatible custom buckets, produces incorrect results or panics 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-07 15:32:35 +10:00
Charles Korn
5ee94f49a2
Fix issue where sum over mixed exponential and custom buckets, or incompatible custom buckets, produces incorrect results 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-07 15:30:01 +10:00
Charles Korn
424cefcf5e
Fix "cannot reduce resolution to custom buckets schema" panic in rate over native histograms with mix of custom and exponential buckets 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-07 14:45:02 +10:00
Charles Korn
f6e4b775e2
Check for errors first 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-08-07 14:25:46 +10:00
György Krajcsovits
b91acc61b0 Add unit test 
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-08-06 20:50:51 +02:00