Merge pull request #13499 from bboreham/tweak-remote-tests

storage/remote: document why two benchmarks are skipped
This commit is contained in:
Bryan Boreham 2024-01-31 12:02:12 +00:00 committed by GitHub
commit 34875ae8c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions

View File

@ -924,7 +924,7 @@ func BenchmarkSampleSend(b *testing.B) {
func BenchmarkStartup(b *testing.B) { func BenchmarkStartup(b *testing.B) {
dir := os.Getenv("WALDIR") dir := os.Getenv("WALDIR")
if dir == "" { if dir == "" {
return b.Skip("WALDIR env var not set")
} }
// Find the second largest segment; we will replay up to this. // Find the second largest segment; we will replay up to this.

View File

@ -204,6 +204,7 @@ func TestCommitErr(t *testing.T) {
} }
func BenchmarkRemoteWriteOOOSamples(b *testing.B) { func BenchmarkRemoteWriteOOOSamples(b *testing.B) {
b.Skip("Not a valid benchmark (does not count to b.N)")
dir := b.TempDir() dir := b.TempDir()
opts := tsdb.DefaultOptions() opts := tsdb.DefaultOptions()