mirror of
https://github.com/prometheus/prometheus
synced 2024-12-26 08:33:06 +00:00
storage/remote: document why two benchmarks are skipped
One was silently doing nothing; one was doing something but the work didn't go up linearly with iteration count. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
parent
ae2852be6a
commit
b9fdf3dad1
@ -924,7 +924,7 @@ func BenchmarkSampleSend(b *testing.B) {
|
||||
func BenchmarkStartup(b *testing.B) {
|
||||
dir := os.Getenv("WALDIR")
|
||||
if dir == "" {
|
||||
return
|
||||
b.Skip("WALDIR env var not set")
|
||||
}
|
||||
|
||||
// Find the second largest segment; we will replay up to this.
|
||||
|
@ -204,6 +204,7 @@ func TestCommitErr(t *testing.T) {
|
||||
}
|
||||
|
||||
func BenchmarkRemoteWriteOOOSamples(b *testing.B) {
|
||||
b.Skip("Not a valid benchmark (does not count to b.N)")
|
||||
dir := b.TempDir()
|
||||
|
||||
opts := tsdb.DefaultOptions()
|
||||
|
Loading…
Reference in New Issue
Block a user