From b9fdf3dad15748a2f17663dc479a9d25eb7e876b Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Tue, 30 Jan 2024 16:48:01 +0000 Subject: [PATCH] storage/remote: document why two benchmarks are skipped One was silently doing nothing; one was doing something but the work didn't go up linearly with iteration count. Signed-off-by: Bryan Boreham --- storage/remote/queue_manager_test.go | 2 +- storage/remote/write_handler_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/storage/remote/queue_manager_test.go b/storage/remote/queue_manager_test.go index 778861e2b..5a9600629 100644 --- a/storage/remote/queue_manager_test.go +++ b/storage/remote/queue_manager_test.go @@ -924,7 +924,7 @@ func BenchmarkSampleSend(b *testing.B) { func BenchmarkStartup(b *testing.B) { dir := os.Getenv("WALDIR") if dir == "" { - return + b.Skip("WALDIR env var not set") } // Find the second largest segment; we will replay up to this. diff --git a/storage/remote/write_handler_test.go b/storage/remote/write_handler_test.go index 9f7dcd175..df92dc6bc 100644 --- a/storage/remote/write_handler_test.go +++ b/storage/remote/write_handler_test.go @@ -204,6 +204,7 @@ func TestCommitErr(t *testing.T) { } func BenchmarkRemoteWriteOOOSamples(b *testing.B) { + b.Skip("Not a valid benchmark (does not count to b.N)") dir := b.TempDir() opts := tsdb.DefaultOptions()