63036 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	fb2293821a	Allow watching replay from multi/playlist results screens	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	c4af8591a5	Preserve OnlineID when importing scores ... Previously, for lazer scores, the ID returned from `osu-web` was discarded and replaced with -1, due to the fact that the appropriate structures for unification with stable, as well as unification across solo and multiplayer, were not in place yet. Now we're at the point where scores from all the aforementioned sources receive a `solo_scores` DB row, and as such, we can start treating `solo_scores`-scheme IDs as canonical "online IDs" for a score.	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	d5a733d244	Use solo score ID as OnlineID when converting from MultiplayerScore	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	b144cfd55c	Add LegacyOnlineID handling to places that definitely need it ... Mostly places that can interact with imported replays. There are other places that use the online ID as a sort tiebreaker, or to check presence of a score on results screens, but they should probably still continue to only use `OnlineID`, since all scores with a legacy online ID should have an online ID, but the converse is not generally true.	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	c53f4c144c	Encode/decode new OnlineID into/from LegacyReplaySoloScoreInfo	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	fa519984df	Move legacy online ID encode/decode to legacy property	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	bfcb4f4f2d	Add failing test for legacy online ID decoding	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	c1a817fec6	Add LegacyOnlineID with backwards migration	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	9cd33d9bb2	Merge pull request #25139 from peppy/collection-ordering-fix ... Fix collections not being sorted alphabetically in context menus	2023-10-16 10:53:43 +02:00
Bartłomiej Dach	ee3ddacf46	Merge pull request #25140 from peppy/manage-collections-drag-handles-bye-bye ... Remove drag handles from manage collections dialog for now	2023-10-16 10:47:38 +02:00
Bartłomiej Dach	38d92187af	Merge pull request #25136 from peppy/fix-taiko-hp-bar-animation ... Fix health bar animating when it shouldn't be	2023-10-16 10:30:17 +02:00
Dean Herbert	7139592e43	Fix collections not being sorted correctly in context menus	2023-10-16 16:03:12 +09:00
Dean Herbert	36112302d6	Remove drag handles from manage collections dialog for now ... The realm implementation doesn't support this.	2023-10-16 15:51:18 +09:00
Dean Herbert	48832c64ac	Fix health bar animating when it shouldn't be ... It wasn't correctly checking the current underlying health, which could be zero in usages of `AccumulatingHealthProcessor`, for instance. Closes #25046.	2023-10-16 13:12:04 +09:00
Dean Herbert	54722bf251	Merge pull request #25113 from nekodex/generic-error-sfx ... Use new `generic-error` sample in appropriate places	2023-10-14 04:35:12 +09:00
Dean Herbert	67a8a51ec7	Merge branch 'master' into generic-error-sfx	2023-10-14 03:56:41 +09:00
Dean Herbert	3cb9945545	Merge pull request #25101 from peppy/fix-hr-cs-mania-adjustment ... Fix "Hard Rock" mod affecting CS/AR in osu!mania and osu!taiko	2023-10-14 03:56:24 +09:00
Dean Herbert	d4627a2402	Update resources	2023-10-14 03:48:59 +09:00
Bartłomiej Dach	8a4c2624bd	Merge branch 'master' into fix-hr-cs-mania-adjustment	2023-10-13 16:08:54 +02:00
Dean Herbert	c372f11013	Merge pull request #25115 from bdach/fix-keybinding-test-failures ... Fix key binding panel test failures from introducing placeholder text	2023-10-13 22:50:58 +09:00
Bartłomiej Dach	9b474b656d	Fix key binding panel test failures from introducing placeholder text ... Whoops.	2023-10-13 15:03:41 +02:00
Bartłomiej Dach	4e1d564d70	Merge pull request #25110 from peppy/limit-extra-elements ... Apply a few more object sizing limits	2023-10-13 14:57:36 +02:00
Bartłomiej Dach	c762241268	Merge branch 'master' into fix-hr-cs-mania-adjustment	2023-10-13 14:08:05 +02:00
Jamie Taylor	d97b618d02	Use new generic-error sample in appropriate places	2023-10-13 21:06:50 +09:00
Bartłomiej Dach	d656306692	Remove approach rate adjustment from TaikoModHardRock ... Approach rate does nothing in taiko.	2023-10-13 14:05:43 +02:00
Dean Herbert	3d5736188e	Merge pull request #25112 from bdach/dangerous-button-shades ... Fix dangerous buttons using different shades of pink	2023-10-13 20:43:24 +09:00
Dean Herbert	7ac2a1721c	Merge pull request #25106 from bdach/dimmed-placeholder-empty-binding ... Use dimmed placeholder text instead of empty box on cleared bindings	2023-10-13 20:43:02 +09:00
Bartłomiej Dach	af89d69fc4	Fix dangerous buttons using different shades of pink	2023-10-13 13:16:24 +02:00
Bartłomiej Dach	a88779e588	Use dimmed placeholder text instead of empty box on cleared bindings	2023-10-13 13:10:04 +02:00
Dean Herbert	6358a5e210	Merge pull request #25105 from bdach/multiple-keys-one-binding ... Disallow binding multiple bindings in a single section to one key	2023-10-13 20:01:33 +09:00
Bartłomiej Dach	a1c68b66f2	Rename KeyBindingRow parts to appease CodeFileSanity	2023-10-13 12:06:25 +02:00
Bartłomiej Dach	ea766b792d	Update localisation keys to match localisable member names	2023-10-13 11:58:55 +02:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Dean Herbert	17b6ebbfbf	Avoid using a bindable in KeyBindingConflictPopover where data is never mutated	2023-10-13 18:40:21 +09:00
Dean Herbert	9b0c4acdef	Split KeyBindingRow out into partial pieces	2023-10-13 18:29:06 +09:00
Dean Herbert	8e609b6f1d	Switch records to classes for sanity ... I don't have anything against records except for the capitalisation when including the paramter names in a constructor. ie. `new Record(This: 1);`	2023-10-13 18:19:12 +09:00
Bartłomiej Dach	d5557bbbfb	Merge pull request #25005 from minetoblend/multiplayer-invites ... Add ability to invite players to multiplayer rooms	2023-10-13 11:09:28 +02:00
Dean Herbert	d7a06059f2	Rename string properties to give more hinting to localisers	2023-10-13 17:49:48 +09:00
Bartłomiej Dach	e04a57d67f	Use less dodgy method of specifying allowable notification types	2023-10-13 10:31:00 +02:00
Bartłomiej Dach	79cec7707d	Privatise setter	2023-10-13 09:56:46 +02:00
Bartłomiej Dach	61b8d035fe	Use dangerous colour for "apply new" button	2023-10-13 09:08:13 +02:00
Dean Herbert	0b64852181	Limit sliderscorepoint to hitcicle dimensions ... You'd never use anything above this unless crazy.	2023-10-13 15:43:20 +09:00
Dean Herbert	17df2fdf01	Restrict followpoint size ... See https://github.com/ppy/osu/issues/24940#issuecomment-1760980461.	2023-10-13 15:42:49 +09:00
Dean Herbert	37411f923e	Merge branch 'master' into multiple-keys-one-binding	2023-10-13 15:07:12 +09:00
Dean Herbert	7c36848eb1	Merge pull request #25104 from bdach/make-realm-key-binding-action-suck-less ... Refactor key binding panel for easier usage	2023-10-13 14:27:07 +09:00
Dean Herbert	549a6581b0	Merge branch 'master' into make-realm-key-binding-action-suck-less	2023-10-13 13:53:24 +09:00
Dean Herbert	9289c47cd4	Tidy up GlobalActionContainer a bit	2023-10-13 13:47:51 +09:00
Dean Herbert	aabed8b6e5	Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info ... Add extended info support to tiny mod switches	2023-10-13 13:40:24 +09:00
Bartłomiej Dach	6c8490bc7e	Revert changes to LoungeSubScreen.Join() ... - `virtual` modifier was used in mocking. - The spacing change revert is just mostly to keep it out of the final diff.	2023-10-12 20:39:40 +02:00
Bartłomiej Dach	edec10204e	Merge pull request #25096 from peppy/show-total-bonus ... Show maximum bonus statistics on results screen	2023-10-12 20:29:28 +02:00