Bartłomiej Dach
3db88fbcea
Use less confusing message format when logging discord errors
...
The "code" is a number, so it looked weird when put in the middle
without any nearby punctuation. Example:
An error occurred with Discord RPC Client: 5005 secrets cannot currently be sent with buttons
2024-03-25 17:54:20 +01:00
Bartłomiej Dach
4979305b2d
Ensure TryDisableCustomRulesetsCausing()
never actually crashes itself
2024-03-25 11:34:29 +01:00
Bartłomiej Dach
fb08d6816b
Only attempt to disable rulesets when decidedly crashing out
2024-03-25 11:33:15 +01:00
Arthur Araujo
78037fa477
Handle new combo on HandleReverse
2024-03-25 04:19:14 -03:00
Dean Herbert
bb9fa52fda
Fix displayIndex
not being correctly set to -1
after last expiry date
2024-03-25 14:53:05 +08:00
Dean Herbert
057f86dd14
Add handling of expiration
2024-03-25 14:31:05 +08:00
Dan Balasescu
a1be45234c
Merge pull request #27708 from 64ArthurAraujo/verify-video-resolution
...
Add verify check for too high video resolution
2024-03-25 15:14:46 +09:00
Dean Herbert
f0614928b1
Read from new location
2024-03-25 13:19:12 +08:00
Dean Herbert
e9f15534ed
Improve test coverage
2024-03-25 12:33:32 +08:00
Dean Herbert
3847aae57d
Don't rotate when hovering
2024-03-25 12:14:40 +08:00
Dean Herbert
d0b164b44f
Add automatic rotation support
2024-03-25 11:41:50 +08:00
Dean Herbert
a4c619ea97
Add basic support for loading multiple images
2024-03-24 15:14:56 +08:00
Dean Herbert
ec4a9a5fdd
Make work again for simple case
2024-03-24 14:55:45 +08:00
Dean Herbert
4c82e44291
Add isolated test coverage of online menu banner
2024-03-24 14:55:45 +08:00
Dean Herbert
ef2a16dd8f
Various renaming and class updates to allow multiple menu banners
2024-03-24 14:55:43 +08:00
Arthur Araujo
8a05fecad5
Fix formatting issue
2024-03-23 23:28:55 -03:00
Arthur Araujo
eb93827204
Add missing copyright header
2024-03-23 23:11:13 -03:00
Arthur Araujo
6fbe1a5b8d
Add video resolution check
2024-03-23 19:22:47 -03:00
Bartłomiej Dach
c7c0330265
Attempt to disable rulesets that can be linked to an unhandled crash
2024-03-22 19:05:58 +01:00
Arthur Araujo
6fa663c8ca
Make check ruleset specific
2024-03-22 14:48:22 -03:00
Dan Balasescu
77660e57ea
Merge pull request #27692 from bdach/artist-sort-uses-title-as-tiebreaker
...
Use title as tiebreaker when sorting beatmap carousel by artist
2024-03-22 17:15:40 +09:00
Bartłomiej Dach
a1880e89c2
Use title as tiebreaker when sorting beatmap carousel by artist
...
Closes https://github.com/ppy/osu/issues/27548 .
Reference: e53980dd76/osu
!/GameplayElements/Beatmaps/BeatmapTreeManager.cs#L341-L347
2024-03-22 08:41:10 +01:00
Bartłomiej Dach
e2df098184
Add failing test case for desired artist sort behaviour
2024-03-22 08:41:08 +01:00
Arthur Araujo
a4822fd615
Make CheckAbnormalDifficultySettings
abstract
2024-03-22 01:37:06 -03:00
Salman Ahmed
b9b9ef671e
Merge pull request #27418 from huoyaoyuan/convert-path-string-new
...
Make slider path parsing more friendly with spans
2024-03-22 05:35:20 +03:00
Salman Ahmed
1efa08a1b8
Merge branch 'master' into convert-path-string-new
2024-03-22 05:15:04 +03:00
Dean Herbert
970e45ff24
Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load
...
Stop blocking player load when hovering over osu! logo
2024-03-21 21:52:25 +08:00
Bartłomiej Dach
3e764ae4f0
Merge pull request #27639 from 64ArthurAraujo/verify-unused-audio-at-end
...
Add verify checks to unused audio at the end
2024-03-21 12:19:53 +01:00
Bartłomiej Dach
983385bafc
Merge pull request #27677 from smoogipoo/fix-catch-banana-fail
...
Fix catch banana shower judgement causing fail when at 0 HP
2024-03-21 11:23:51 +01:00
Dean Herbert
c081cc7d77
Merge pull request #27681 from smoogipoo/add-deployed-build-attribute
...
Warn about not using an official "deployed" build
2024-03-21 14:13:40 +08:00
Dean Herbert
b99b0337cf
Adjust text slightly
2024-03-21 13:06:25 +08:00
Dean Herbert
0589924dc6
Merge pull request #27079 from smoogipoo/tcm-resume
...
Add delayed resume for taiko/catch/mania
2024-03-21 12:48:53 +08:00
Dean Herbert
ef693ffbb6
Merge pull request #27676 from bdach/add-logging-on-metadata-discard
...
Add extended logging when discarding online metadata lookup results
2024-03-21 12:23:19 +08:00
Dean Herbert
55d66d4615
Add sounds to countdown
2024-03-21 11:45:48 +08:00
Dean Herbert
a07d5115bf
Update resources
2024-03-21 11:42:22 +08:00
Arthur Araujo
b132734f9c
Fix codefactor issues
2024-03-20 18:54:38 -03:00
Arthur Araujo
2d6a3b8e2b
Remove warning for 10K+
2024-03-20 16:51:27 -03:00
Arthur Araujo
c605e463a4
Add mania keycount check
2024-03-20 15:52:16 -03:00
Dan Balasescu
ac7fca10d6
Warn about not using an official "deployed" build
2024-03-21 00:47:45 +09:00
Arthur Araujo
4904c49c38
Add abnormal difficulty settings checks
2024-03-20 09:31:58 -03:00
Dan Balasescu
bf5640049a
Fix banana showers causing fails when hp is at 0
2024-03-20 17:31:33 +09:00
Dan Balasescu
66ace02e58
Add test for banana shower fail
2024-03-20 17:31:11 +09:00
Dan Balasescu
c78e203df5
Fix infinite health processor loop when no top-level objects
...
This is unlikely to occur in actual gameplay, but occurs in the
follow-up test.
2024-03-20 17:30:37 +09:00
Bartłomiej Dach
1f343b7545
Add extended logging when discarding online metadata lookup results
...
Related to: https://github.com/ppy/osu/issues/27674
Relevant log output for that particular case:
[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes
[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507.
[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507)
[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes
[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982.
[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982)
Note that the online IDs are swapped.
2024-03-20 08:28:11 +01:00
Bartłomiej Dach
8ee391530f
Merge pull request #27675 from peppy/remove-breadcrumb-control
...
Remove unused `ScreenBreadcrumbControl`
2024-03-20 08:02:36 +01:00
Dean Herbert
1f70019009
Merge pull request #27630 from EVAST9919/editor-performance
...
Improve editor performance for maps with many control points
2024-03-20 13:20:21 +08:00
Salman Ahmed
0d6daef42b
Merge branch 'master' into remove-breadcrumb-control
2024-03-20 08:11:03 +03:00
Salman Ahmed
773daee50b
Merge pull request #27443 from jvyden/discord-rpc-invites
...
Support Discord game invites in multiplayer lobbies
2024-03-20 08:05:53 +03:00
Dean Herbert
fd509c82f5
Adjust code structure slightly
2024-03-20 12:52:54 +08:00
Salman Ahmed
5f86b5a2fa
Use DI correctly
2024-03-20 07:36:15 +03:00