Bartłomiej Dach
f9873968a5
Apply NRT in OsuResumeOverlay
2024-04-16 13:39:06 +02:00
Bartłomiej Dach
c4bf03e640
Add failing test
2024-04-16 13:39:05 +02:00
Bartłomiej Dach
d2a67d2d54
Merge pull request #27881 from smoogipoo/fix-mod-refilter
...
Don't re-filter unless mods may change the filter
2024-04-16 11:21:35 +02:00
Bartłomiej Dach
2c90ba9614
Merge pull request #27891 from peppy/stop-background-process-high-performance
...
Fix high memory usage during spectator modes when background processing is running
2024-04-16 10:57:33 +02:00
Dean Herbert
926424d8ea
Update HighPerformanceSessionManager.cs
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-04-16 16:37:11 +08:00
Dean Herbert
a651cb8d50
Stop background processing from running when inside a high performance session
2024-04-16 10:04:38 +08:00
Dean Herbert
d89edd2b4f
Expose high performance session state
2024-04-16 10:04:38 +08:00
Dean Herbert
7e4782d4b1
Allow nested high performance sessions
...
Mostly just for safety, since I noticed this would pretty much fall over
in this scenario until now.
2024-04-16 10:04:38 +08:00
Dan Balasescu
0e218ee271
Merge pull request #27148 from Givikap120/traceable_pp
...
Add Traceable performance calculation support
2024-04-16 04:54:57 +09:00
Dan Balasescu
343b3ba0e6
Don't re-filter unless mods may change the filter
2024-04-15 21:07:36 +09:00
Dan Balasescu
fe7df808b6
Add tests
2024-04-15 21:07:08 +09:00
Dean Herbert
1c02cbfa5d
Merge pull request #27877 from bdach/fix-faded-pp-on-stable-scores
...
Fix stable scores showing with faded out pp display due to classic mod presence
2024-04-15 18:21:21 +08:00
Bartłomiej Dach
7c4c8ee75c
Fix stable scores showing with faded out pp display due to classic mod presence
2024-04-15 11:53:05 +02:00
Bartłomiej Dach
8506da725d
Add failing test
2024-04-15 11:49:47 +02:00
Dan Balasescu
d34834af05
Merge pull request #27853 from Drison64/mask-volume-bar
...
Fix toolbar volume bar masking
2024-04-15 03:36:31 +09:00
Ondřej Vajďák
ed6680a61d
Fixed type inconsistency and rounding
2024-04-14 15:10:05 +02:00
Ondřej Vajďák
9833dd955f
Fix toolbar volume bar masking
2024-04-14 01:30:59 +02:00
Dan Balasescu
e14e2a4629
Merge pull request #27845 from Loreos7/beatmap_hash
...
Fix missing underscore in `invalid beatmap_hash` notification message
2024-04-13 21:16:55 +09:00
Loreos7
5a8b8908dd
fix missing underscore
2024-04-13 14:53:51 +03:00
Givikap120
4a21ff9726
removed duplication
2024-04-13 13:59:09 +03:00
Givikap120
feb9b5bdb8
Make traceable pp match HD
2024-04-13 13:42:57 +03:00
Dean Herbert
b7b3401b34
Merge pull request #27839 from smoogipoo/fix-macos-crash
...
Fix crash when entering multiplayer on macOS
2024-04-13 12:54:00 +08:00
Dan Balasescu
c7f3a599c9
Fix crash when entering multiplayer on macOS
2024-04-13 13:17:06 +09:00
Dan Balasescu
3793a552b8
Merge pull request #27832 from peppy/skin-editor-new-items-apply
...
Fix newly placed items in skin editor not getting correct anchor placement
2024-04-12 21:00:52 +09:00
Dean Herbert
c0dce94f15
Fix newly placed items in skin editor not getting correct anchor placement
2024-04-12 17:08:49 +08:00
Dean Herbert
da1a07fb45
Merge pull request #27827 from smoogipoo/fix-ios-build
...
Update Sentry to fix iOS build
2024-04-12 08:48:12 +08:00
Dean Herbert
3ec93745a4
Fix test failures due to sentry oversight
2024-04-12 01:10:42 +08:00
Dan Balasescu
8b2017be45
Update Sentry to fix iOS build
2024-04-12 01:02:40 +09:00
Dean Herbert
3e8ddbd2a9
Add new entries to dotsettings (Rider 2024.1)
2024-04-11 11:33:16 +08:00
Bartłomiej Dach
b559bec49f
Merge pull request #27734 from smoogipoo/fix-catmull-bulbs
...
Fix bulbs on Catmull sliders
2024-04-10 11:49:29 +02:00
Bartłomiej Dach
518addf323
Merge branch 'master' into fix-catmull-bulbs
2024-04-10 11:25:02 +02:00
Dean Herbert
6cb5bffdfc
Update resources
2024-04-10 13:03:37 +08:00
Dean Herbert
6c5fad8638
Merge pull request #27810 from smoogipoo/fix-discord-rpc-crash
...
Fix possible crash due to race in DiscordRichPresence
2024-04-08 23:37:44 +08:00
Dan Balasescu
7d8fe51178
Fix possible crash due to race in DiscordRichPresence
2024-04-08 23:33:42 +09:00
Bartłomiej Dach
b226a05637
Merge pull request #27787 from peppy/update-hit-error-icons
...
Update hit error metre to use new icons
2024-04-05 09:58:12 +02:00
Bartłomiej Dach
d6b1e68ee7
Merge branch 'master' into update-hit-error-icons
2024-04-05 09:36:18 +02:00
Dean Herbert
6093b50641
Merge pull request #27797 from smoogipoo/revert-storyboard-optimisation
...
Revert recent storyboard optimisations
2024-04-05 14:56:44 +08:00
Dan Balasescu
7b92c725b1
Revert "Merge pull request #27454 from EVAST9919/sb-lifetime-improvements"
...
This reverts commit 0881e7c8c1
, reversing
changes made to 29a37e3585
.
2024-04-05 14:45:49 +09:00
Dean Herbert
673882f64b
Merge pull request #27789 from smoogipoo/disable-discord-uri-macos
...
Disable Discord URI registration on macOS for now
2024-04-04 15:58:19 +08:00
Dan Balasescu
fb8fb4f34e
Disable Discord URI registration on macOS for now
2024-04-04 16:43:26 +09:00
Dean Herbert
6ec5c1d7e2
Merge pull request #27788 from smoogipoo/update-framework
...
Update osu.Framework package
2024-04-04 15:18:23 +08:00
Dean Herbert
10d1308a0a
Update resources
2024-04-04 15:05:59 +08:00
Dan Balasescu
cd474de61f
Update osu.Framework package
2024-04-04 15:55:05 +09:00
Dean Herbert
9521c1e3e4
Update hit error metre to use new icons
...
- [ ] Depends on https://github.com/ppy/osu-resources/pull/317 .
2024-04-04 14:31:40 +08:00
Dean Herbert
2e1d63a1c2
Merge pull request #27783 from 64ArthurAraujo/add-invalid-beatmap-hash-custom-message
...
Add custom message in the case of a `invalid beatmap_hash`
2024-04-04 10:47:22 +08:00
Arthur Araujo
9e92ebaa43
Make message more general
...
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2024-04-03 19:15:22 -03:00
Dean Herbert
2f64c16088
Merge pull request #27784 from bdach/double-skip-yet-again
...
Fix some maps requiring multiple intro skips that weren't there on stable
2024-04-04 04:14:03 +08:00
Arthur Araujo
8e00368f7c
Add custom message in the case of a invalid beatmap_hash
2024-04-03 11:30:14 -03:00
Bartłomiej Dach
9d54f1a092
Fix some maps requiring multiple intro skips that weren't there on stable
...
Closes https://github.com/ppy/osu/issues/25633 .
The reason why that particular beatmap did not have a double skip
on stable is here:
e53980dd76/osu
!/GameModes/Play/Player.cs#L1761-L1770
The particular place of interest is the `leadInTime < 10000` check.
If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out
that `AudioEngine.Time` will always be more than or equal to `leadIn`,
because it's also the gameplay start time:
e53980dd76/osu
!/GameModes/Play/Player.cs#L2765
This essentially means that if the `leadInTime` is less than 10000,
that particular check is just dead. So a double skip can only occur
if the gameplay starts at time -10000 or earlier due to the storyboard.
2024-04-03 16:12:20 +02:00
Bartłomiej Dach
524a5815bc
Add test coverage
2024-04-03 16:11:40 +02:00