Bartłomiej Dach
e0b7539c2a
Fix sample changes not being applied in patcher
2023-05-22 22:45:23 +02:00
Bartłomiej Dach
2ce150ba2b
Add failing test case for sample undo
2023-05-22 22:23:05 +02:00
Bartłomiej Dach
f253d17a7f
Fix slider velocity changes not being applied in patcher
2023-05-22 22:19:10 +02:00
Bartłomiej Dach
843d2903d2
Add failing test case for slider velocity undo
2023-05-22 22:18:15 +02:00
Dean Herbert
7742904d2a
Merge pull request #23593 from Dimmitsaras/unfocused-notifications
...
Always show chat message notifications if window is unfocused
2023-05-22 14:17:20 +09:00
Dean Herbert
09c66bea8f
Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area
...
Fix clicking area of news sidebar post links
2023-05-22 14:17:08 +09:00
Joseph Madamba
7392109bce
Apply same behavioral changes to NewsCard
2023-05-21 19:28:12 -07:00
Joseph Madamba
2279aad360
Apply NRT to NewsCard
2023-05-21 19:27:20 -07:00
Dean Herbert
3df0eea92d
Merge pull request #23573 from Susko3/use-atomic-ReplaceRange
...
Prevent feedback with display resolution bindable by using atomic `.ReplaceRange()`
2023-05-22 11:26:06 +09:00
Dean Herbert
b3527b92b6
Handle case in tests where current display becomes null
2023-05-22 09:25:44 +09:00
Bartłomiej Dach
19816ae013
Update framework
2023-05-21 20:38:27 +02:00
Bartłomiej Dach
6df1d29862
Merge branch 'master' into use-atomic-ReplaceRange
2023-05-21 20:32:59 +02:00
Joseph Madamba
88c112612f
Remove hardcoded website url
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-21 10:35:22 -07:00
Joseph Madamba
8aefb62532
Rename PostButton
to PostLink
2023-05-20 16:38:56 -07:00
Joseph Madamba
ec5f0bbf42
Fix clicking area of news sidebar post links
...
Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).
2023-05-20 16:32:04 -07:00
Bartłomiej Dach
de5917b645
Merge branch 'master' into unfocused-notifications
2023-05-20 19:32:52 +02:00
Bartłomiej Dach
a677d87d39
Touch up inline comments
2023-05-20 19:29:59 +02:00
Bartłomiej Dach
7fa8a1148d
Merge pull request #22716 from peppy/fix-menu-state-display
...
Update in line with framework menu handling changes
2023-05-20 19:10:22 +02:00
Bartłomiej Dach
8e0a97ca49
Remove usage of HasSubmenu
...
Property has been removed in the appropriate framework-side PR and
instead folded into `IsActionable`.
See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647
2023-05-20 18:02:12 +02:00
Bartłomiej Dach
67c044773b
Merge branch 'master' into fix-menu-state-display
2023-05-20 17:57:00 +02:00
Bartłomiej Dach
afdddb0195
Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes
...
Fix timeline blueprint display not showing correct combo number / colour during placement
2023-05-20 15:02:55 +02:00
Bartłomiej Dach
0e11adaaac
Merge pull request #23564 from peppy/fix-missing-sample-additions
...
Fix sample banks not transferring when adjusting via editor
2023-05-20 14:36:45 +02:00
Bartłomiej Dach
ec442a94e2
Merge pull request #23595 from peppy/pin-to-6.x
...
Pin builds to .NET 6
2023-05-20 13:25:56 +02:00
Dean Herbert
e8cb19e40a
Pin builds to .NET 6
...
As more things move to having the 7 SDK installed, let's pin for now.
This helps with mobile build scenarios, which fall over on the new SDKs
and require further attention.
2023-05-19 17:49:27 +09:00
Dean Herbert
ee522253cb
Remove a couple of unnecessary volume
declarations
2023-05-18 14:12:57 +09:00
Bartłomiej Dach
9ca1c7f7b7
Merge pull request #23580 from peppy/fix-profile-button-depth
...
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 21:23:46 +02:00
Bartłomiej Dach
fb441b864e
Merge pull request #23576 from peppy/fix-random-button-right-click
...
Fix random button hover state sticking when rewinding using right mouse button
2023-05-17 21:02:39 +02:00
Dimmitsaras
7ac6688a0f
Chat message notifications always play on unfocused window
2023-05-17 18:34:39 +03:00
Dean Herbert
b58ab28765
Make EditorClock
non-nullable in PlacementBlueprint
2023-05-17 21:40:52 +09:00
Dean Herbert
214d7e07fa
Add TODO regarding failing stack display code
2023-05-17 17:52:17 +09:00
Dean Herbert
0b25818bd2
Update combo information on placement blueprint
2023-05-17 17:26:19 +09:00
Dean Herbert
9563d4f730
Fix weird purple tint on placement object in timeline
2023-05-17 17:26:19 +09:00
Dean Herbert
8d925c8a8a
Move combo information updating to an interface level helper method
2023-05-17 17:26:19 +09:00
Dean Herbert
e43f2c2c43
Improve previous hitobject lookup efficient and correctness
2023-05-17 17:19:29 +09:00
Dean Herbert
7d7d402d4e
Apply NRT to PlacementBlueprint
2023-05-17 17:19:29 +09:00
Dean Herbert
79e1d978e7
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 15:42:38 +09:00
Dean Herbert
764f0323f4
Show "rewind" text on random button when beginning a right mouse press
2023-05-17 14:51:40 +09:00
Dean Herbert
94b184712d
Fix random button hover state not correctly being reset on right click
2023-05-17 14:51:40 +09:00
Dean Herbert
dc421bd2af
Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"
...
This reverts commit ab2bd123e7
, reversing
changes made to 267e63320f
.
2023-05-17 14:49:47 +09:00
Dean Herbert
510ebe1f23
Fix weird optional usage in HitSampleInfo.With
2023-05-17 14:11:52 +09:00
Dean Herbert
dc51d5ecf3
Rename GetSampleInfo
to better describe what method does
...
Also add full xmldoc
2023-05-17 14:07:48 +09:00
Dean Herbert
a8bc337006
Change default volume when constructing a HitSampleInfo
to non-zero
2023-05-17 14:06:02 +09:00
Susko3
fec47fa690
Merge branch 'master' into use-atomic-ReplaceRange
...
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Dean Herbert
0d3c64dc32
Merge pull request #23572 from bdach/avoid-display-settings-feedback
...
Work around issues with bindable/event feedback in layout settings
2023-05-17 12:03:45 +09:00
Dean Herbert
ab2bd123e7
Merge pull request #23570 from huoyaoyuan/inspect-code-cs11
...
Update InspectCode to 2022.3.3 and enable C# 11
2023-05-17 11:37:57 +09:00
Bartłomiej Dach
c97b7a077e
Use better issue reference
2023-05-16 23:47:47 +02:00
Bartłomiej Dach
70426a5042
Add reference to youtrack issue to suppression
2023-05-16 22:42:25 +02:00
Susko3
2d7fe68311
Prevent feedback by using atomic .ReplaceRange()
...
`display.NewValue` will never be null, checked on SDL + osuTK/Android.
On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays
2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution
2023-05-16 21:02:23 +02:00