Commit Graph

28166 Commits

Author SHA1 Message Date
Dean Herbert da0667365b
Merge branch 'master' into inheritable-allow-track-adjust 2021-09-16 16:35:11 +09:00
Dean Herbert 6f2d818b64
Merge pull request #14740 from smoogipoo/mania-note-animations
Add animation support for mania notes
2021-09-16 16:34:53 +09:00
Dean Herbert 3495fae519 Handle potential for `OnResuming` call without an `OnSuspending` first 2021-09-16 16:31:41 +09:00
Dean Herbert b58415fe19 Make suspend stored state nullable to ensure we don't break it 2021-09-16 16:12:14 +09:00
Dean Herbert fa693bb8a8 Move `MusicController` adjustment set to inside `OsuScreen` itself (and result `nullable`) 2021-09-16 16:08:09 +09:00
Dan Balasescu 43379a2eaa
Merge pull request #14752 from peppy/realm-settings
Move (ruleset) settings to realm
2021-09-16 14:05:41 +09:00
Dean Herbert 4d4a9b86c1 Merge branch 'master' into mania-note-animations 2021-09-16 11:12:07 +09:00
AbstractQbit 318f0941ca Move all the "inherit previous `AllowTrackAdjustments`" logic into `OsuScreen` 2021-09-15 21:25:39 +03:00
Dean Herbert 931e873a7e
Merge branch 'master' into inheritable-allow-track-adjust 2021-09-15 22:26:13 +09:00
AbstractQbit f0439ef50b Remove unnecessary `AllowTrackAdjustments` overrides, add true to `SongSelect` 2021-09-15 13:12:57 +03:00
Dean Herbert 8acfefed1b
Merge pull request #14741 from smoogipoo/fix-lounge-beatmaps-counter
Fix incorrect beatmap count and SR range in multi lounge
2021-09-15 18:51:52 +09:00
AbstractQbit 1181317c72 Fix issues found by code quality ci 2021-09-15 12:01:56 +03:00
Dean Herbert 4f1db5af40 Attach migration memo to `DatabasedSetting` class for visibility 2021-09-15 17:25:07 +09:00
Dean Herbert a1d325cb22 Mark key and value non-nullable (at realm end) and simplify `Value` logic 2021-09-15 17:16:05 +09:00
Dean Herbert a150fb2996 Add nullability directive and make variant non-nullable 2021-09-15 17:16:05 +09:00
Dean Herbert 15e3f95c87 Remove remnants of `DatabasedSetting` from `SkinInfo`
This was never used
2021-09-15 17:12:04 +09:00
Dean Herbert dcfe9c67e3 Make ruleset id non-nullable 2021-09-15 17:12:04 +09:00
Dean Herbert 80ecf81be3 Rename all databased setting classes to be specific to rulesets for now 2021-09-15 17:12:04 +09:00
Dean Herbert 520e550764 Bring back `SettingsStore` to avoid changing ruleset API for now
Also fixes some remaining test failures due to locally constructed
rulesets that are not being tracked by the game.
2021-09-15 17:12:02 +09:00
Dean Herbert c36a67d06e Fix some tests failing due to using a locally constructed ruleset 2021-09-15 17:04:38 +09:00
Dean Herbert 5bb741b4e8 Remove migration of key bindings 2021-09-15 17:04:38 +09:00
smoogipoo f54d554d30 Extract removal to method 2021-09-15 17:03:28 +09:00
AbstractQbit 48cf98ef93 Rephrase null meaning in `IOsuScreen.AllowTrackAdjustments`
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-09-15 11:00:49 +03:00
AbstractQbit b87af3dd68 Move the inherited `AllowTrackAdjustments` into `OsuScreen` 2021-09-15 10:55:16 +03:00
Dean Herbert 2bcb3fd304 Add migration of existing settings 2021-09-15 16:31:13 +09:00
Dean Herbert ac377a2e3c Remove unused `SettingsStore` 2021-09-15 16:31:13 +09:00
Dean Herbert a2f1752344 Make settings works with current caching structure
Will likely pull out that `RulesetConfigCache` next, but this is an
"everything works" state.
2021-09-15 16:31:13 +09:00
Dean Herbert 14314476f0 Update realm to latest version 2021-09-15 16:22:14 +09:00
Dean Herbert 187c557ea8 Begin migrating settings implementation across to realm 2021-09-15 16:22:14 +09:00
Dean Herbert 623377772c
Merge branch 'master' into fix-spectator-random-mod 2021-09-15 13:55:28 +09:00
Dean Herbert 1ba716d9f1
Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state
Preserve current time and clipboard contents when switching between difficulties
2021-09-15 12:38:56 +09:00
Dan Balasescu 5ea1924c30
Merge branch 'master' into display-sr-changes 2021-09-15 10:22:11 +09:00
Bartłomiej Dach 7b9e501fa0
Merge branch 'master' into 14421-multi-password-error-handling 2021-09-14 22:58:20 +02:00
Bartłomiej Dach baf9961934
Amend xmldoc of shake extension method 2021-09-14 22:50:45 +02:00
AbstractQbit bd18c581c1 Replace `allowTrackAdjustmentsStack` with a Dictionary 2021-09-14 21:14:24 +03:00
AbstractQbit 01d2f4f17a Make `allowTrackAdjustmentsStack` readonly 2021-09-14 18:04:43 +03:00
AbstractQbit b9193aae6d Make IOsuScreen.AllowTrackAdjustments nullable
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
Dean Herbert 57f8ccca16 Remove nullability from `EditorState` properties
Also update the xmldoc to not be specific to difficulty switching
2021-09-14 23:36:28 +09:00
Dean Herbert f8bdca542d Make restoring state a `public` call on `Editor` 2021-09-14 23:36:17 +09:00
Dean Herbert 2a894e7a3f Make `EditorLoader` state `private` 2021-09-14 23:26:02 +09:00
smoogipoo a775915338 Fix incorrect beatmap count and SR range in multi lounge 2021-09-14 18:20:28 +09:00
smoogipoo 63aa3ddcba Add animation support for mania notes 2021-09-14 17:45:23 +09:00
smoogipoo b807c161b4 Remove now-unused DI params 2021-09-14 17:25:57 +09:00
smoogipoo 6cffbee592 Fix random/target mods not working in spectator 2021-09-14 17:22:58 +09:00
Dean Herbert 5058f28504 Remove breaking padding 2021-09-14 14:52:50 +09:00
Dean Herbert 8865e3cab8 Add back shake and tweak transform of text 2021-09-14 14:44:32 +09:00
Dean Herbert e17b800470 Move shake logic into extension method 2021-09-14 14:44:23 +09:00
Dean Herbert 7bd749d0eb Remove weird shaking 2021-09-14 14:19:55 +09:00
Dean Herbert e3c56f9ebd Show error message in popover 2021-09-14 14:14:06 +09:00
Dean Herbert eaac2bad3d Fix incorrect child margin specifications 2021-09-14 13:49:02 +09:00