Commit Graph

51048 Commits

Author SHA1 Message Date
Dean Herbert a27fcda9f1 Fix failing tests due to `CurrentDialog` being unexpectedly not set after `Push` 2022-05-05 01:52:39 +09:00
Dean Herbert 383245f43a Fix dialoged pushed to `DialogOverlay` too early potentially doing cross-thread transforms
As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.
2022-05-04 20:23:36 +09:00
Dean Herbert cf220f171b Add test coverage of cross-thread transforms if a dialog is pushed too early 2022-05-04 20:23:36 +09:00
Dean Herbert 0018408bdb
Merge pull request #18071 from frenzibyte/distance-spacing-osd
Display toast notification on editor distance spacing changes
2022-05-04 18:42:00 +09:00
Dean Herbert 4e0f899159 Rename value changed variable 2022-05-04 18:13:30 +09:00
Salman Ahmed f5d4f02200 Use `ToUpper` for key binding text 2022-05-04 11:59:29 +03:00
Salman Ahmed 0b8fd2e39f Improve distance spacing toast inline with key binding changes 2022-05-04 11:43:19 +03:00
Salman Ahmed 3d2072498e Merge branch 'master' into distance-spacing-osd 2022-05-04 11:41:12 +03:00
Salman Ahmed 6f52a0b5eb Merge branch 'master' into distance-spacing-osd 2022-05-04 11:10:18 +03:00
Dean Herbert f64a6305af
Merge pull request #18070 from frenzibyte/distance-spacing-keybinding
Add keybind for handling distance spacing scrolls in editor
2022-05-04 17:03:06 +09:00
Dean Herbert 40f1ceca0a
Merge branch 'master' into distance-spacing-keybinding 2022-05-04 16:34:01 +09:00
Dean Herbert 732739715a Remove "grid" from strings 2022-05-04 16:31:20 +09:00
Salman Ahmed 504ca5be31 Fix scrolling no longer adjusting distance spacing by amount 2022-05-04 09:52:33 +03:00
Bartłomiej Dach 1122ee967c
Merge pull request #18085 from peppy/fix-editor-grid-rendering
Improve editor grid rendering
2022-05-04 08:23:39 +02:00
Salman Ahmed 813d6fed48 Split activation keybind to separate increase/decrease keybinds 2022-05-04 09:00:54 +03:00
Dean Herbert df530cb5ab Add highlighting to the position snap grid edges in addition to centre lines 2022-05-04 13:49:04 +09:00
Dean Herbert 0bb90c7b07 Fix gridline centering and ensure lines are always rendered using a fixed screen-space width 2022-05-04 13:41:55 +09:00
Dean Herbert bb086800b1 Remove ugly playfield border 2022-05-04 13:41:30 +09:00
Bartłomiej Dach 533574e3d0
Merge pull request #17915 from GSculerlor/sheared-search-textbox
Implement new sheared search textbox design
2022-05-03 19:57:26 +02:00
Bartłomiej Dach e17756fe25
Merge branch 'master' into sheared-search-textbox 2022-05-03 16:45:54 +02:00
Dean Herbert 054a82d152
Merge pull request #18067 from smoogipoo/reduce-diffcalc-sort-complexity
Reduce sorting worst-case time complexity in difficulty calculation
2022-05-03 21:49:44 +09:00
Salman Ahmed 0dd2e1652c Mark `OnScreenDisplay` dependency as nullable 2022-05-03 11:15:28 +03:00
Salman Ahmed b8287f3687 Display toast notification on editor distance spacing change 2022-05-03 10:30:32 +03:00
Salman Ahmed 521ec1a225 Add keybind for distance grid spacing activation 2022-05-03 10:15:24 +03:00
Dan Balasescu 637f817696 Ignore zero-sections on a per-case basis 2022-05-03 16:06:20 +09:00
Dan Balasescu a555c47212 Reduce sorting complexity in worst-case of diffcalc 2022-05-03 15:02:57 +09:00
Dean Herbert 983eed32fc Reduce complexity of icon container nesting 2022-05-03 14:48:00 +09:00
Dean Herbert b5ea26f2fa Fix incorrect shear masking on nested textbox 2022-05-03 14:45:17 +09:00
Dean Herbert bc88c4ee8e Reduce container nesting by one level 2022-05-03 14:34:18 +09:00
Dean Herbert 8e0235392f Inline single-use constants 2022-05-03 14:31:20 +09:00
Dean Herbert 4a56297c1c Add localisation and improve visuals of placeholder text 2022-05-03 14:29:04 +09:00
Dean Herbert 4fb66a812f
Merge branch 'master' into sheared-search-textbox 2022-05-03 14:12:59 +09:00
Dean Herbert 04fb0f5e63
Merge pull request #18063 from GSculerlor/split-searchbox
Split `SearchTextBox` implementation for reusability
2022-05-03 14:12:44 +09:00
Ganendra Afrasya a35502a834 Move implementation to ctor instead of bdl method 2022-05-03 11:33:03 +07:00
Ganendra Afrasya e03d086305 Inherit `SearchTextBox` instead 2022-05-03 11:24:48 +07:00
Ganendra Afrasya a436ff877f Apply review 2022-05-03 11:13:07 +07:00
Ganendra Afrasya e6fbb19951 Implement new search textbox design 2022-05-03 11:13:07 +07:00
Dean Herbert faeefc5e18
Merge pull request #16576 from frenzibyte/osu-distance-spacing
Add "distance spacing" support in editor for osu! ruleset
2022-05-03 12:15:18 +09:00
Ganendra Afrasya 81be69e72e Update search textbox implementation to use `BasicSearchTextBox` instead 2022-05-03 06:18:42 +07:00
Ganendra Afrasya d7919f462c Split `SearchTextBox` into `SearchTextBox` and `BasicSearchTextBox` 2022-05-03 06:18:27 +07:00
Dean Herbert 4442ed89b5
Merge pull request #17586 from Joehuu/move-difficulty-graph-toggle
Move difficulty graph toggle to individual skin settings
2022-05-03 00:59:02 +09:00
Dean Herbert abdb4c16a7
Merge pull request #18056 from peppy/fix-countdown-sounds
Fix countdown stopping at first completed minute rather than actual last minute
2022-05-03 00:32:16 +09:00
Bartłomiej Dach 2b4a49e17f
Merge branch 'master' into move-difficulty-graph-toggle 2022-05-02 16:38:25 +02:00
Dean Herbert c4c62ff4e7 Fix countdown sounds playing every minute, rather than only on the last minute 2022-05-02 22:46:14 +09:00
Bartłomiej Dach b9642a13c8
Merge pull request #18054 from frenzibyte/fix-footer-random-jarringness
Fix footer random button autosizing to text length
2022-05-02 15:21:32 +02:00
Bartłomiej Dach 47aea45895
Merge branch 'master' into fix-footer-random-jarringness 2022-05-02 14:56:05 +02:00
Salman Ahmed 18c0390b20
Merge pull request #18052 from peppy/fix-beatmap-set-dismissal
Fix clicking anywhere in the beatmap overlay dismissing it
2022-05-02 15:51:08 +03:00
Salman Ahmed 18852b2509 Fix footer random button autosizing to text length 2022-05-02 15:36:22 +03:00
Bartłomiej Dach be4ef0880e
Merge branch 'master' into fix-beatmap-set-dismissal 2022-05-02 14:28:51 +02:00
Bartłomiej Dach 62951066bb
Merge pull request #18053 from peppy/sheared-button-ux
Adjust sheared button visuals to improve disabled / mousedown state
2022-05-02 13:54:23 +02:00