1
0
mirror of https://github.com/ppy/osu synced 2024-12-16 20:05:41 +00:00
Commit Graph

34238 Commits

Author SHA1 Message Date
Dean Herbert
9d3de5bca0 Fix hit lighting dictating lifetime even when not present in skin 2020-11-18 19:03:34 +09:00
Dean Herbert
9d0a6de26e Fix SkinnableSprite initialising a drawable even when the texture is not available 2020-11-18 19:03:34 +09:00
Dean Herbert
72a15ef2dc Handle DrawableJudgement lifetime more flexibly 2020-11-18 19:03:34 +09:00
Dean Herbert
25d4511e49 Fix judgement test scene always using hitobjects at t=0 2020-11-18 19:03:34 +09:00
Dean Herbert
94886a09b2 Remove fades from DrawableJudgement itself 2020-11-18 19:03:34 +09:00
Dean Herbert
5bd4ace37f Split out new and old style legacy judgement pieces 2020-11-18 19:03:34 +09:00
Dean Herbert
8be31f4805 Adjust legacy skin judgement transforms to match stable 2020-11-18 19:03:05 +09:00
Bartłomiej Dach
57eaee27ae Rename param to match type better 2020-11-17 20:12:04 +01:00
Bartłomiej Dach
875d7dec79 Remove redundant this. qualifier 2020-11-17 20:11:13 +01:00
Dean Herbert
dd4b69feab Add legacy judgement implementation which doesn't transform on animations 2020-11-17 15:46:57 +09:00
Dean Herbert
8247e6ce91 Move result type to ctor 2020-11-17 15:43:54 +09:00
Dean Herbert
e4f1e52422 Add xmldoc coverage of Apply() 2020-11-17 15:03:26 +09:00
Dean Herbert
f465dd5a5e Move all extended animation logic out of DrawableJudgement 2020-11-17 14:59:34 +09:00
Dean Herbert
82c3925a37 Remove unused DrawableOsuJudgement constructors 2020-11-17 14:13:51 +09:00
Dean Herbert
9dfa4249e0 Make Apply non-virtual 2020-11-17 14:05:13 +09:00
Dean Herbert
dc38aeac43 Remove unnecessary local definition of colour logic from taiko judgement 2020-11-16 17:23:02 +09:00
Dan Balasescu
09298139e1
Merge pull request from bdach/spinner-rotation-tracker-state
Fix rotation tracker state not being reset on drawable spinner re-use
2020-11-16 17:10:40 +09:00
Dean Herbert
d8c9db860a
Merge pull request from ekrctb/dotnet-tool-inspectcode
Use `dotnet tool` for InspectCode build script
2020-11-16 16:25:01 +09:00
Dean Herbert
86ef73c587
Merge pull request from Joehuu/consistent-tournament-strings
Make tournament strings more consistent
2020-11-16 16:20:49 +09:00
Dean Herbert
6706840b54
Merge pull request from bdach/add-to-legacy-conversion-tests 2020-11-16 15:22:04 +09:00
ekrctb
b20898a1ac Use dotnet tool for InspectCode build script 2020-11-16 14:57:52 +09:00
Dean Herbert
a4c17906b4 Make comment a bit more explicit 2020-11-16 14:52:18 +09:00
Dean Herbert
baed1573dc
Merge pull request from nbvdkamp/fix-quick-delete-crash 2020-11-16 14:42:52 +09:00
Dan Balasescu
3dbd7d5654
Merge pull request from bdach/reset-transforms-on-return-to-pool
Clear DrawableHitObject transforms on return to pool
2020-11-16 14:40:38 +09:00
Dean Herbert
7169dc9173 Add extra step checking slider deletion on second click 2020-11-16 14:06:37 +09:00
Dean Herbert
7b79b9b9c1
Merge branch 'master' into fix-quick-delete-crash 2020-11-16 13:54:54 +09:00
Dean Herbert
0ea75450d4
Merge pull request from nbvdkamp/clamp-editor-movement
Clamp selection movement instead of refusing to move on playfield borders
2020-11-16 12:46:48 +09:00
Bartłomiej Dach
399a1a16a0 Refactor beginClickSelection in a slightly different way 2020-11-15 21:06:47 +01:00
Bartłomiej Dach
337311c323 Remove redundant type specification 2020-11-15 20:52:58 +01:00
Bartłomiej Dach
1f0945d4de Simplify accesses via ChildrenOfType() 2020-11-15 20:52:33 +01:00
Bartłomiej Dach
4e77800b98 Rename & simplify property 2020-11-15 20:51:35 +01:00
Bartłomiej Dach
9c0a0031d6 Clear existing transforms on DHO return to pool 2020-11-15 19:50:22 +01:00
Bartłomiej Dach
42de4437cc Add failing test case 2020-11-15 19:43:42 +01:00
kamp
c77ec3e905 Fix slider control point quickdelete test 2020-11-15 17:42:52 +01:00
Dean Herbert
67db278864
Merge pull request from bdach/fix-spectator-preview-crash
Add support for previewing tracks on spectator screen
2020-11-16 01:09:37 +09:00
kamp
1db303b159 Revert beginClickSelection logic 2020-11-15 16:54:48 +01:00
Bartłomiej Dach
6b38bb9d76 Add test coverage for new ownerless behaviour 2020-11-15 16:38:25 +01:00
kamp
83727a2e85 Add quick-delete tests 2020-11-15 16:06:29 +01:00
Bartłomiej Dach
7736d1ae85 Fix taiko-specific missing cases 2020-11-15 15:41:58 +01:00
Bartłomiej Dach
a17990f2ee Fix osu!-specific missing cases 2020-11-15 15:40:31 +01:00
Bartłomiej Dach
e5d9cca9de Fix mania-specific missing cases 2020-11-15 15:38:12 +01:00
Bartłomiej Dach
5d44286d38 Add missing generic mappings to legacy mods 2020-11-15 15:35:06 +01:00
Bartłomiej Dach
5ace7abaa8 Add abstract non-generic ModNightcore to pattern-match over 2020-11-15 15:32:02 +01:00
Bartłomiej Dach
e9b5f54128 Cover mapping fully for taiko mods 2020-11-15 15:32:02 +01:00
Bartłomiej Dach
9f27d4a9f4 Cover mapping fully for osu! mods 2020-11-15 15:32:02 +01:00
Bartłomiej Dach
ee5e70135f Cover mapping fully for mania mods 2020-11-15 15:09:02 +01:00
Bartłomiej Dach
f9fa7c86ea Cover mapping fully for catch mods 2020-11-15 14:53:25 +01:00
Bartłomiej Dach
8b74298567 Add base method for testing conversion in other direction 2020-11-15 14:48:23 +01:00
kamp
268bbcf77d Clamp selection movement instead of refusing to move on borders 2020-11-15 14:22:46 +01:00
Bartłomiej Dach
9899687bfe Rename existing method to allow for new one 2020-11-15 14:17:41 +01:00