Commit Graph

2852 Commits

Author SHA1 Message Date
smoogipoo d3f0c0730d Merge branch 'master' into non-concurrent-sample-playback 2021-02-12 17:22:15 +09:00
Dan Balasescu cb4d119f23
Merge pull request #11740 from peppy/editor-fix-slider-samples-new-placement
Fix newly placed sliders in the editor not playing hitsounds
2021-02-12 13:31:00 +09:00
Dean Herbert f84ea30637 Expose Mods in DrawableRuleset to avoid using external DI 2021-02-11 17:47:29 +09:00
Dean Herbert aaa0362b12 Merge branch 'master' into autoplay-rate-independence 2021-02-11 17:39:45 +09:00
Dean Herbert db79080bc4 Fix GetNodeSamples potentially returning a live reference and overwriting existing samples 2021-02-11 17:14:49 +09:00
Dean Herbert 4710a12774
Merge branch 'master' into classic-mode-flags 2021-02-11 16:21:55 +09:00
smoogipoo 5d1d6ec1cb Fix inverted calculation 2021-02-10 22:09:24 +09:00
smoogipoo 20a6405fd2 Add explanatory comments + const 2021-02-10 22:06:19 +09:00
smoogipoo bd2486e5a0 Fix grammatical error in comment 2021-02-10 21:27:12 +09:00
smoogipoo 1d425b8322 Simplify case 2021-02-10 21:25:31 +09:00
smoogipoo 4a391ce03d Fix div-by-0 when 0 ticks are hit 2021-02-10 21:24:41 +09:00
smoogipoo be9b07a4cf Merge branch 'master' into difficulty-adjustment-extension 2021-02-10 20:42:08 +09:00
smoogipoo c458c4cfae Fix unintended changes due to renaming or otherwise 2021-02-10 20:27:47 +09:00
smoogipoo 0dcdad9839 Adjust comment for DrawableSliderHead 2021-02-10 19:04:23 +09:00
smoogipoo 6bf40170db Rename SliderBall flag 2021-02-10 18:53:26 +09:00
smoogipoo a16f4cee3a Adjust DrawableSlider comment 2021-02-10 18:52:39 +09:00
smoogipoo 2fcc4213e1 Rename IgnoreJudgement -> OnlyJudgeNestedObjects 2021-02-10 18:46:26 +09:00
smoogipoo 9519b7f7c1 Adjust comment 2021-02-10 18:43:14 +09:00
smoogipoo 18a29dcb96 Rename bindable member, reorder binds 2021-02-10 18:42:24 +09:00
smoogipoo 6730c4c58b Apply review comments (user explanations + property names) 2021-02-10 18:41:28 +09:00
smoogipoo cf06684ad1 Judge heads as slider ticks instead 2021-02-10 18:38:31 +09:00
Dean Herbert 1cb51fa8d2
Merge branch 'master' into autoplay-rate-independence 2021-02-09 16:05:34 +09:00
Dean Herbert 695e46a358 Fix AutoPilot mod failing to block touch input 2021-02-09 15:31:55 +09:00
Dean Herbert b96a594546 Remove unnecessary initial call to HitObjectApplied bound method
Was causing test failures. Looks to be unnecessary on a check of when
HitObjectApplied is invoked.
2021-02-09 15:11:59 +09:00
smoogipoo 7021d1dfdc Merge branch 'hit-policy-refactor' into classic-mode-flags 2021-02-08 20:12:33 +09:00
smoogipoo f4a31287bf Add/use IHitObjectContainer interface instead of IEnumerables 2021-02-08 20:11:06 +09:00
smoogipoo d955200e07 Prevent invalid hit results for ignored slider heads 2021-02-08 11:10:14 +09:00
smoogipoo 2218247b21 Override mod type 2021-02-08 11:07:50 +09:00
Bartłomiej Dach 0e1ec703d3 Use IApplicableToRate in osu! auto generator 2021-02-07 18:49:31 +01:00
Bartłomiej Dach 3fabe247b0 Allow OsuModGenerator to accept a mod list 2021-02-07 18:35:34 +01:00
Bartłomiej Dach 68c20a2a37 Allow autoplay score generation to access mod list 2021-02-07 18:35:34 +01:00
smoogipoo a5855f5d28 Move follow circle tracking to DrawableSliderHead 2021-02-05 17:33:48 +09:00
smoogipoo ee3367d7c5 Add classic slider ball tracking 2021-02-05 17:14:23 +09:00
smoogipoo 3aa3692ed4 Disable snaking out when tracking is disabled 2021-02-05 15:56:13 +09:00
smoogipoo 6aece18f8d Add OOHP tests 2021-02-05 15:36:47 +09:00
smoogipoo a4551dc1ee Add object-ordered hit policy 2021-02-05 15:36:47 +09:00
smoogipoo 6c78d308a4 Merge branch 'hit-policy-refactor' into classic-mode-flags 2021-02-05 15:36:43 +09:00
smoogipoo 8adf37d958 Add SetHitObjects() to IHitPolicy instead of using ctor 2021-02-05 15:25:03 +09:00
smoogipoo 08aae011c1 Add IHitPolicy interface 2021-02-05 15:25:03 +09:00
smoogipoo df1df81847 Better indicate ordering 2021-02-05 15:25:03 +09:00
smoogipoo 0528469b44 Rename OrderedHitPolicy -> StartTimeOrderedHitPolicy 2021-02-05 15:25:03 +09:00
smoogipoo 3b5c67a063 Add OsuModClassic 2021-02-03 23:08:59 +09:00
smoogipoo 2f22dbe06b Make sliders display judgements when not ignored 2021-02-03 22:42:50 +09:00
smoogipoo 03b7817887 Add flags to return to classic slider scoring 2021-02-03 22:12:20 +09:00
smoogipoo 623b47f9af Add flag to toggle follow circle tracking for slider heads 2021-02-03 21:55:19 +09:00
Bartłomiej Dach ae08ef2543 Reset SPM counter state on DHO application 2021-01-29 20:32:45 +01:00
Dean Herbert d521bfc251 Don't directly update HandleUserInput (as it is used by mods) 2021-01-30 02:35:11 +09:00
Dean Herbert 5a306dfc2b Fix unused using 2021-01-29 20:22:25 +09:00
Dean Herbert f25809d35f Ensure spinners only handle input during their hittable time
While this was already being enforced inside of `CheckForResult`, the
internal tracking values of rotation were still being incremented as
long as the `DrawableSpinner` was present. This resulted in incorrect
SPM values being displayed if a user was to start spinning before the
object's `StartTime`.

Kind of annoying to write a test for (there's no setup for spinners yet)
but am willing to do so if that is deemed necessary.

Closes https://github.com/ppy/osu/issues/11600.
2021-01-29 19:55:55 +09:00
smoogipoo de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00