RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
63,096 Commits 3 Branches 650 Tags 350 MiB
Commit Graph

63096 Commits

Author SHA1 Message Date
Dan Balasescu 832ba861bb
Fix incorrect PR url in diffcalc workflow 2023-10-19 15:19:51 +09:00
Dean Herbert 66421a55ab
Merge pull request #25159 from smoogipoo/improve-diffcalc-command 
Fix + improve diffcalc command for comment-based execution
 2023-10-19 12:11:16 +09:00
Dan Balasescu 14cadd1eeb
Pin third-party actions 2023-10-19 02:39:34 +09:00
Bartłomiej Dach 12f343f0e2
Merge pull request #24640 from Givikap120/pitch_change 
Add an "Adjust pitch" switch to DT/HT
 2023-10-18 13:07:22 +02:00
Bartłomiej Dach f1a16c50b8
Merge branch 'master' into pitch_change 2023-10-18 12:27:27 +02:00
Bartłomiej Dach cff69d63a6
Add inline commentary in `Mod{Day,Night}core` about different speed adjustments 2023-10-18 12:27:16 +02:00
Dean Herbert 54da6f1048
Merge pull request #25160 from bdach/repeat-arrow-hidden-fade 
Adjust slider repeat transforms to closer match stable
 2023-10-18 18:03:48 +09:00
Dean Herbert 9907adc337
Take in `IBindable`s and tidy up multiplier handling 2023-10-18 17:39:13 +09:00
Dean Herbert 161890292f
Move audio adjustment hookup to own method for clarity 2023-10-18 17:38:11 +09:00
Dean Herbert e56ff33271
Also share `ScoreMultiplier` implementation 2023-10-18 17:23:50 +09:00
Dean Herbert 43238b0cee
Split common functionality from rate adjust mods into helper class 2023-10-18 17:23:50 +09:00
Dean Herbert eabfcfbf2a
Merge branch 'master' into pitch_change 2023-10-18 16:33:03 +09:00
Dean Herbert bf4aa3c118
Merge pull request #25163 from Joehuu/double-click-slider-nub-default 
Add ability to revert slider settings to default when double-clicking nub
 2023-10-18 16:23:05 +09:00
Joseph Madamba 18e8ca6245 Add ability to revert slider settings to default when double-clicking nub 2023-10-17 21:41:03 -07:00
Joseph Madamba 1a3a81c33b Add slider nub double click revert to default test 2023-10-17 21:41:03 -07:00
Bartłomiej Dach e927267c4d
Merge pull request #25155 from peppy/fix-new-inspections 
Fix various new rider EAP inspections
 2023-10-17 17:04:39 +02:00
Bartłomiej Dach f3cda58474
Fix legacy slider repeats becoming much too large on hit 
They had scale transforms applied to them in two places: the actual
legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
`DrawableSliderRepeat` level.

This change moves all of the scale transforms to the skinnable pieces.
Argon and triangles have received a copy of the previous logic each,
so behaviour on those skins should not change.
 2023-10-17 14:47:44 +02:00
Bartłomiej Dach 30e5f47007
Instantly fade out slider repeats when hidden is active 2023-10-17 14:15:21 +02:00
Bartłomiej Dach f116854c9f
Add test step for covering slider appearance with hidden active 2023-10-17 14:15:21 +02:00
Dan Balasescu 4946b437c9
Run timeout job on self-hosted runner 2023-10-17 21:01:23 +09:00
Dan Balasescu 566b09ff20
Delete comment on cancellation 
- Add always() pre-condition to force evaluation.

- Message is set as it's required by the action for a non-error status code.
 2023-10-17 20:51:28 +09:00
Dan Balasescu 08845ec1c6
Use action for GHA diffcalc workflow permissions check 2023-10-17 20:28:04 +09:00
Dean Herbert d9fc532a9f
Merge pull request #25152 from bdach/key-binding-deduplication 
Clear pre-existing bindings of same key combination to single action
 2023-10-17 17:49:51 +09:00
Dean Herbert e081fa48a2
Fix various other inspections 2023-10-17 17:48:51 +09:00
Dean Herbert 5341a335a6
Bypass `Parent` nullability checks for now 2023-10-17 17:48:45 +09:00
Bartłomiej Dach 5833c20be5
Merge pull request #25153 from peppy/store-speed-change-config 
Persist the state of "show speed changes" between editor sessions
 2023-10-17 10:23:00 +02:00
Dean Herbert 4885c55ef0
Merge branch 'master' into key-binding-deduplication 2023-10-17 17:17:44 +09:00
Bartłomiej Dach 4cfc95c673
Add backwards migration of catch dash binding 2023-10-17 09:43:40 +02:00
Bartłomiej Dach 79a4b985fe
Use left mouse as alternative default binding for catch dash 
This mirrors stable. Although the way stable does this is pretty dodgy,
see:
	https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L274-L275
 2023-10-17 09:31:29 +02:00
Dean Herbert 165cd07428
Persist the state of "show speed changes" between editor sessions 
Addresses https://github.com/ppy/osu/discussions/25149.
 2023-10-17 16:01:02 +09:00
Dan Balasescu 6f4a2b9889
Merge pull request #25111 from peppy/mania-bonus-refactor 
Change osu!mania "perfect" judgements to only award bonus score
 2023-10-17 14:27:54 +09:00
Dan Balasescu d2a3f14d5b
Merge branch 'master' into mania-bonus-refactor 2023-10-17 13:28:04 +09:00
Bartłomiej Dach 240d317928
Merge pull request #25143 from peppy/split-spinner-fix 
Apply various fixes and cleanup to spinner logic
 2023-10-16 22:30:24 +02:00
Bartłomiej Dach 828cedea33
Fix bindings being cleared if multiple bindings for same action have the same combination 
This actually seems to be the case in catch (dash is bound to shift
twice). This is annoying but harmless, so let's work around it for now
to avoid ruining users' configs.
 2023-10-16 22:20:26 +02:00
Bartłomiej Dach 3aae07d1ca
Add failing case for two bindings of single action bound to same key 2023-10-16 22:20:26 +02:00
Bartłomiej Dach 9c6166ec3d
Add migration to remove duplicate bindings 2023-10-16 22:20:26 +02:00
Bartłomiej Dach 639c96e60c
Prevent ruleset input managers from reading duplicate bindings 2023-10-16 21:02:24 +02:00
Bartłomiej Dach 90c44cee54
Implement method to deduplicate keybindings 2023-10-16 20:51:57 +02:00
Bartłomiej Dach 79273b88f6
Add stub of method to deduplicate bindings (and failing test) 2023-10-16 20:48:52 +02:00
Bartłomiej Dach f14928cdfb
Merge branch 'master' into split-spinner-fix 2023-10-16 18:59:08 +02:00
Dan Balasescu 3065c9f23d
Fix potential frame misordering in generator 2023-10-16 22:49:41 +09:00
Dean Herbert 75011db3a7
Merge pull request #25142 from bdach/clean-up-scoring-difficulty-attributes 
Remove no longer used scoring difficulty attributes
 2023-10-16 20:16:20 +09:00
Bartłomiej Dach f2436a5ecb
Remove no longer used scoring difficulty attributes 2023-10-16 12:36:58 +02:00
Dean Herbert 0bb95cfa88
Fix incorrect initial rotation transfer value 
Should have been removed as part of https://github.com/ppy/osu/pull/24360.
 2023-10-16 19:34:55 +09:00
Dean Herbert 10bab61441
Tidy up `lastAngle` usage and add assertion of maximum delta 2023-10-16 19:34:22 +09:00
Dean Herbert 04af46b8c7
Change `SpinFramesGenerator` to take degrees as input 2023-10-16 18:34:56 +09:00
Dean Herbert 28ee99f132
Add prospective test coverage of spinner input handling 2023-10-16 18:31:01 +09:00
Dean Herbert cfa4adb24d
Add `SpinFramesGenerator` class to simplify creating spinner tests 2023-10-16 18:25:40 +09:00
Dean Herbert 159b24acf7
Rename `RateAdjustedRotation` to `TotalRotation` 2023-10-16 18:25:03 +09:00
Dan Balasescu 84be714d6b
Fix large instantaneous delta on first frame 
Happens when the first update frame comes in before any mouse input.
 2023-10-16 18:17:11 +09:00