Commit Graph

40505 Commits

Author SHA1 Message Date
Dan Balasescu
b283c48abb
Merge branch 'master' into factor-out-hoc 2021-06-04 15:31:35 +09:00
Dan Balasescu
a02c39b066
Merge pull request #7316 from mcendu/kiai
Implement kiai flash of hit circles
2021-06-04 15:31:19 +09:00
Dean Herbert
19a44d65c5 Tidy up code 2021-06-04 15:18:16 +09:00
Dean Herbert
23096c58bb
Merge branch 'master' into fix-spectator-frame-conversion 2021-06-04 15:06:15 +09:00
Dean Herbert
071c07586a Increase music volume back to 80% for the time being 2021-06-04 15:00:53 +09:00
Nathan Alo
996c156106 apply suggestions
- apply 0 alpha to beatmap background if storyboard replaces it
- use an AudioContainer to mute all samples coming from the storyboard
2021-06-04 13:56:10 +08:00
Dean Herbert
f62a2747f6 Add legacy implementation 2021-06-04 14:51:35 +09:00
Dean Herbert
52557da335 Add test coverage 2021-06-04 14:14:51 +09:00
Dean Herbert
5953674737 Tidy up constants 2021-06-04 14:14:51 +09:00
Dean Herbert
ff70f99da2 Merge branch 'master' into kiai 2021-06-04 13:50:12 +09:00
Dan Balasescu
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
Dean Herbert
eebd5745a8 Move full stop out of link and reword slightly 2021-06-04 11:44:43 +09:00
Dan Balasescu
233551fc08
Merge pull request #13323 from gagahpangeran/extract-sidebar
Create abstract class `OverlaySidebar`
2021-06-04 11:38:36 +09:00
Dan Balasescu
50c60c791f
Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods
Add seed option for all random mods
2021-06-04 11:26:13 +09:00
Dan Balasescu
a648cdfd14
Merge pull request #13324 from peppy/fix-collection-enumeration-replay
Detach gameplay score from replay recorder before importing
2021-06-04 10:44:23 +09:00
Gagah Pangeran Rosfatiputra
905472a20b
make NewsSidebar extends OverlaySidebar 2021-06-04 00:12:29 +07:00
Gagah Pangeran Rosfatiputra
076e498a63
create abstract class OverlaySidebar 2021-06-04 00:12:13 +07:00
Dean Herbert
d444fed46f Detach gameplay score from replay recorder before importing
Closes #13320.
2021-06-04 02:00:02 +09:00
Pasi4K5
7a4fc9ffc8 Move seed to base class 2021-06-03 18:16:11 +02:00
Dean Herbert
daff4a1a00
Merge pull request #11182 from angelaz1/keyboard_shortcuts
Add browser-like tab management hotkeys to chat overlay
2021-06-03 22:48:55 +09:00
Gagah Pangeran Rosfatiputra
c5fc155cc0
Change text wording
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-03 20:37:27 +07:00
Gagah Pangeran Rosfatiputra
b36c406a83
add test scene for error page 2021-06-03 19:48:04 +07:00
Gagah Pangeran Rosfatiputra
490ce0bbc5
load placeholder page when failed 2021-06-03 19:40:54 +07:00
Bartłomiej Dach
e117f98bfa Rename test steps 2021-06-03 14:31:13 +02:00
Bartłomiej Dach
5f5f3a8c5c General comment cleanups 2021-06-03 14:20:52 +02:00
Bartłomiej Dach
b2cc2a51ec Rename method to be less misleading
Would rather avoid variations of Equals/Equal/IsEqual. There's not
really much equality involved as the types are different.
2021-06-03 14:13:01 +02:00
Bartłomiej Dach
e8c2483f19 Use standard list instead of bindable list
No reason to use a bindable list there, as `CollectionChanged` was never
subscribed to.
2021-06-03 14:09:52 +02:00
Bartłomiej Dach
8193691cbc Invert condition to reduce nesting 2021-06-03 14:09:52 +02:00
Bartłomiej Dach
acb4873157 Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:09:48 +02:00
Dean Herbert
d1110d00a0
Merge pull request #12204 from ilsubyeega/drawavatar-use-avatar-url
Use avatar_url from user first instead of a.ppy.sh in DrawableAvatar
2021-06-03 20:13:14 +09:00
Dean Herbert
33ab411e39 Merge branch 'master' into drawavatar-use-avatar-url 2021-06-03 19:36:32 +09:00
smoogipoo
e887807ae7 Apply review fixes 2021-06-03 18:32:05 +09:00
smoogipoo
be03a2d7d2 Fix multiple calls to seek method potentially not working 2021-06-03 17:47:22 +09:00
smoogipoo
c3280083a2 Merge branch 'master' into fix-spectator-frame-conversion 2021-06-03 17:42:01 +09:00
smoogipoo
662bbed5d1 Fix seeking to gameplay too soon 2021-06-03 17:38:51 +09:00
Dan Balasescu
15b43beef1
Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects
Refactor catch Movement skill to not require explicit clockrate usage
2021-06-03 17:29:27 +09:00
Dan Balasescu
d39eb7eac2
Merge pull request #12952 from peppy/autoplay-pause-support
Externalise autoplay generation from `Player` to allow use of replay playback functions
2021-06-03 17:29:17 +09:00
smoogipoo
3bc81fbb06 Fix spectator tests 2021-06-03 17:27:24 +09:00
smoogipoo
420df124b5 Add framestable-bypassing seek for spectator 2021-06-03 17:27:21 +09:00
Dean Herbert
8b43cfdd7d
Merge pull request #12568 from Pasi4K5/mod-osu-random
Add mod "Random" for osu! ruleset
2021-06-03 17:14:27 +09:00
Dan Balasescu
69009a36b7
Merge branch 'master' into autoplay-pause-support 2021-06-03 16:37:41 +09:00
Dan Balasescu
ccb2fce0fc
Merge pull request #13314 from peppy/test-platform-actions
Add nested `PlatformActionContainer` to allow testing of platform actions in visual tests
2021-06-03 16:33:43 +09:00
Dean Herbert
48687028a3 Merge branch 'test-platform-actions' into keyboard_shortcuts 2021-06-03 15:35:57 +09:00
Dean Herbert
be91203c92 Add nested PlatformActionContainer to allow testing of platform actions in visual tests 2021-06-03 15:35:32 +09:00
Dean Herbert
b917d6d80c Update tests to check for correct platform action keys 2021-06-03 15:34:06 +09:00
Samuel Cattini-Schultz
f51413ead9 Refactor to pass clockrate in constructor rather than deriving from mods 2021-06-03 16:09:42 +10:00
Dean Herbert
e74fe68c96 Use new platform actions instead of hardcoded keys 2021-06-03 15:04:07 +09:00
ekrctb
b321b20e9d Remove OnAdd/OnRemove of HitObjectContainer
Instead, override `AddDrawable`/`RemoveDrawable`.
2021-06-03 15:00:16 +09:00
ekrctb
0ce7baa3f3 Make HitObjectContainer.Clear non-virtual
It just call `Remove` for all entries.
2021-06-03 15:00:16 +09:00
ekrctb
2c9e5b6c7e Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property
It can be used for dynamically added entries.
2021-06-03 15:00:16 +09:00