RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-27 17:32:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Invert condition to reduce nesting

Browse Source
This commit is contained in:
Bartłomiej Dach 2021-06-03 13:58:19 +02:00
parent acb4873157
commit 8193691cbc
1 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
osu.Game/Online/Chat/ChannelManager.cs
View File

@ -471,29 +471,29 @@ namespace osu.Game.Online.Chat
ClosedChannel lastClosedChannel = closedChannels.Last();
closedChannels.RemoveAt(closedChannels.Count - 1);
// If the user hasn't already joined the channel, try to join it
if (joinedChannels.FirstOrDefault(lastClosedChannel.IsEqual) == null)
// If the user has already joined the channel, try the next one
if (joinedChannels.FirstOrDefault(lastClosedChannel.IsEqual) != null)
continue;
Channel lastChannel = AvailableChannels.FirstOrDefault(lastClosedChannel.IsEqual);
if (lastChannel != null)
{
Channel lastChannel = AvailableChannels.FirstOrDefault(lastClosedChannel.IsEqual);
if (lastChannel != null)
{
// Channel exists as an availaable channel, directly join it
CurrentChannel.Value = JoinChannel(lastChannel);
}
else if (lastClosedChannel.Type == ChannelType.PM)
{
// Try to get User to open PM chat
users.GetUserAsync((int)lastClosedChannel.Id).ContinueWith(u =>
{
if (u.Result == null) return;
Schedule(() => CurrentChannel.Value = JoinChannel(new Channel(u.Result)));
});
}
return;
// Channel exists as an availaable channel, directly join it
CurrentChannel.Value = JoinChannel(lastChannel);
}
else if (lastClosedChannel.Type == ChannelType.PM)
{
// Try to get User to open PM chat
users.GetUserAsync((int)lastClosedChannel.Id).ContinueWith(u =>
{
if (u.Result == null) return;
Schedule(() => CurrentChannel.Value = JoinChannel(new Channel(u.Result)));
});
}
return;
}
}