Commit Graph

67857 Commits

Author SHA1 Message Date
Dan Balasescu
537e3a1642
Merge pull request #28619 from bdach/fix-tail-volume-not-saving
Fix slider tail volume not saving
2024-07-03 16:13:18 +09:00
Dean Herbert
abfcac7466
Fix nullability 2024-07-03 15:31:46 +09:00
Dean Herbert
b6dc483fc1
Add missing change handler to ensure undo/redo works for break removal 2024-07-03 14:23:31 +09:00
Jamie Taylor
d29d114133
Match prior ducking behaviour 2024-07-03 13:52:20 +09:00
Jamie Taylor
b972632e4f
Change default easing to match prior behaviour 2024-07-03 13:50:35 +09:00
Jamie Taylor
153138cdac
Use null to disable audio filter instead 2024-07-03 13:47:59 +09:00
Salman Ahmed
92404dfbb0
Merge pull request #28712 from peppy/update-framework-has-flag
Update framework
2024-07-03 07:26:54 +03:00
Salman Ahmed
abfdf90b54 Remove unused using directive 2024-07-03 07:11:35 +03:00
Salman Ahmed
cb350470e5
Merge branch 'master' into update-framework-has-flag 2024-07-03 07:06:13 +03:00
Dean Herbert
4ac9d57705
Merge pull request #28711 from bdach/ternary-state-node-samples
Include node samples when changing additions and banks
2024-07-03 10:21:17 +09:00
Arthur Araujo
21829e7ef4 Fix test method names 2024-07-02 21:12:15 -03:00
Arthur Araujo
7143ff523f Make MarkerChecks and MarkerCheck class private 2024-07-02 21:09:49 -03:00
Arthur Araujo
7cdad20119 Fix explicit array type specification in MarkerChecks 2024-07-02 20:55:52 -03:00
Arthur Araujo
7cb3d7445c Add verify checks for title markers 2024-07-02 17:20:00 -03:00
Dean Herbert
5350945340
Update HasFlag usages 2024-07-03 00:19:04 +09:00
Dean Herbert
9034f6186b
Update framework 2024-07-03 00:15:34 +09:00
Bartłomiej Dach
a7b066f3ee
Include node samples when changing additions and banks 2024-07-02 16:22:15 +02:00
Bartłomiej Dach
6453522b34
Add failing test coverage for changing banks/samples not working on node samples 2024-07-02 16:21:56 +02:00
Bartłomiej Dach
3f08605277
Add test coverage 2024-07-02 15:02:09 +02:00
Bartłomiej Dach
9414aec8bf
Add capability to remove breaks via context menu 2024-07-02 14:55:04 +02:00
Bartłomiej Dach
3d61a217ec
Add test coverage 2024-07-02 14:34:36 +02:00
Bartłomiej Dach
d85c467856
Implement quick exit hotkeys for editor test play 2024-07-02 14:34:36 +02:00
Bartłomiej Dach
e28befb98d
Implement quick pause toggle for editor test play 2024-07-02 14:34:35 +02:00
Bartłomiej Dach
1e4db77925
Implement autoplay toggle for editor test play
Contains some hacks to fix weird behaviours like rewinding to the start
on enabling autoplay, or gameplay cursor hiding.
2024-07-02 14:34:31 +02:00
Bartłomiej Dach
d4a8f6c8b0
Do not add extra sample control point after end of IHasRepeats objects 2024-07-02 09:13:07 +02:00
Bartłomiej Dach
3bf3e9133b
Merge pull request #28689 from smoogipoo/fix-break-conversion
Fix `ManiaModInvert` permanently destroying the beatmap
2024-07-02 07:53:16 +02:00
Dan Balasescu
00462f6d56
Merge pull request #28660 from mcendu/no-release-mod
Add "No Release" mod
2024-07-02 12:46:27 +09:00
Dan Balasescu
31edca866c
Remove unused code 2024-07-02 12:21:24 +09:00
Dan Balasescu
04da1209f7
Revert "Change breaks list to IReadOnlyList"
This reverts commit 2c3b411bb5.
2024-07-02 12:16:11 +09:00
Dan Balasescu
db84711214
Revert "Move break cloning back to non-virtual method"
This reverts commit f69bc40a4b.
2024-07-02 12:16:10 +09:00
Dean Herbert
f69bc40a4b
Move break cloning back to non-virtual method 2024-07-02 12:07:13 +09:00
Dean Herbert
2c3b411bb5
Change breaks list to IReadOnlyList 2024-07-02 11:59:24 +09:00
Dean Herbert
f694ae416e
Fix typo in xmldoc 2024-07-02 11:47:40 +09:00
Dean Herbert
005af280f2
Isolate bindable breaks list to EditorBeatmap 2024-07-02 11:31:55 +09:00
Nathan Du
1eb10e029c Rewrite no release mod
Per the request of spaceman_atlas, the No Release mod is rewritten to
avoid modifications to DrawableHoldNoteTail. The approach is based
on that of the Strict Tracking mod for the osu!(standard) ruleset,
injecting the mod behavior by replacing the normal hold note with
the mod's variant. The variant inherits most bevaior from the normal
hold note, but when creating nested hitobjects, it creates its own
hold note tail variant instead, which in turn is used to instantiate
the mod's variant of DrawableHoldNoteTail with a new behavior.

The time a judgement is awarded is changed from the end of its
Perfect window to the time of the tail itself.
2024-07-01 20:29:30 +08:00
Dan Balasescu
f942595829
Fix ManiaModInvert permanently messing up the beatmap 2024-07-01 15:02:00 +09:00
Dan Balasescu
4cb58fbe47
Add failing test 2024-07-01 15:02:00 +09:00
Dean Herbert
9aec1de4c2
Merge branch 'master' into daily-challenge/integration 2024-07-01 10:37:33 +09:00
Dean Herbert
56f4f40334
Merge pull request #28657 from peppy/playfield-skin-components-respect-border
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
2024-07-01 10:35:15 +09:00
Dan Balasescu
2f9bce5274
Merge pull request #28686 from peppy/fix-summary-timeline-break-display
Fix summary timeline not correctly updating after changes to breaks
2024-07-01 10:03:16 +09:00
Dean Herbert
8bb51d5a4f
Fix summary timeline not correctly updating after changes to breaks
Closes https://github.com/ppy/osu/issues/28678.

Oops.
2024-06-30 20:32:16 +09:00
Nathan Du
463ab46fee formatting 2024-06-29 16:46:16 +08:00
Nathan Du
679f4735b3 add tests for No Release mod
The new test scene is essentially a copy of TestSceneHoldNoteInput,
modified to test the judgement changes applied by the new mod. A base
class might need to be abstracted out for them.
2024-06-29 16:20:07 +08:00
Nathan Du
960d552dc1 Initial implemention of the No Release mod
This commit adds a new osu!mania mod No Release that relaxes tail
judgements. The current implementation automatically awards Perfect
(or Meh if the hold note is broken midway) for a hold note tail at
the end of its Perfect window, as long as it is held by then.

Tests are pending for the next commit.
2024-06-28 22:21:08 +08:00
Bartłomiej Dach
18f4fac4c1
Merge pull request #25725 from smoogipoo/fix-juicestream-velocity
Fix JuiceStream velocity calculation
2024-06-28 13:42:44 +02:00
Bartłomiej Dach
df97215298
Use room watching functionality to receive realtime daily challenge updates 2024-06-28 13:35:16 +02:00
Bartłomiej Dach
81c6da98c2
Merge pull request #26465 from LeNitrous/fix/editor-test-exit
Fix editor test play not marking hit objects before its start time as judged.
2024-06-28 12:12:17 +02:00
Bartłomiej Dach
deeb2e99a2
Add test for correct juice stream tick counts in editor
cda9440a29 inadvertently fixes this in the
most frequent case by inverting the `TickDistanceMultiplier` from being
not-1 to 1 on beatmap versions above v8.

This can still potentially go wrong if a beatmap from a version below v8
is edited, because upon save it will be reencoded at the latest version,
meaning that the multiplier will change from not-1 to 1 - but this can
be handled separately.
2024-06-28 11:58:07 +02:00
Bartłomiej Dach
c70a72ece8
Merge branch 'master' into fix-juicestream-velocity 2024-06-28 11:47:39 +02:00
Dean Herbert
55b80f70f6
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset 2024-06-28 18:12:20 +09:00