Commit Graph

70 Commits

Author SHA1 Message Date
Joseph Madamba 7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Dean Herbert d69552fbcf Fix potential crash from cross-thread drawable mutation in collection management
As seen at https://github.com/peppy/osu/runs/4613800663?check_suite_focus=true.
2021-12-23 13:21:17 +09:00
Dean Herbert 1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert 7349e5521a Update `BeatmapCollection` to use `IBeatmapInfo` 2021-11-12 18:16:36 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
Bartłomiej Dach ef03787fe0
Split dropdown accent colour into hover and selection colours 2021-10-19 22:09:51 +02:00
Dean Herbert 9bf29503fb Rename remaining usage 2021-10-07 20:57:14 +09:00
Dean Herbert 310d7965b6 Merge branch 'master' into more-filter-effects 2021-10-07 20:52:38 +09:00
Jamie Taylor f6458aa26d
Add filter effect to collection management dialog 2021-10-07 17:56:11 +09:00
Dean Herbert 0a00bc7795 Split out `IPostNotifications` into an interface 2021-09-30 18:21:34 +09:00
smoogipoo 8a2026e305 Schedule callback instead 2021-06-23 21:26:52 +09:00
smoogipoo e7981eae9b Safeguard load procedure a bit more 2021-06-23 16:14:08 +09:00
smoogipoo 5828606c13 Prefer using the backup file if it exists 2021-06-23 15:09:42 +09:00
smoogipoo c9a203cc11 Move collections db in-place 2021-06-23 15:03:34 +09:00
smoogipoo 7341e474f1 Attempt to safeguard against collections database corruptions 2021-06-08 14:25:39 +09:00
Dean Herbert 37ef368738 Move async call out of `using` to better define the flow of data 2021-05-27 19:03:59 +09:00
Lucas A 41fafdf643 Remove now unreachable code paths. 2021-05-17 12:55:59 +02:00
Lucas A dabe8bd4c7 Fix code inspections and remove now unused code. 2021-05-17 12:55:58 +02:00
Lucas A 851e33fd15 Hook up StableImportManager. 2021-05-17 12:55:57 +02:00
Dean Herbert b1cd01ceb8 Apply ConfigureAwait changes to game side 2021-03-08 14:36:35 +09:00
Dean Herbert 90e8308716 Merge branch 'master' into localisation-refactor-framework 2021-02-25 17:28:55 +09:00
Dean Herbert 165da32044 Fix dropdown crash on collection name collisions 2021-02-24 18:41:42 +09:00
Dean Herbert c514233141 Fix importing collections twice from stable causing a hard crash
Somehow a bindable equality check failure got through review. Not sure
if there's some way to protect against this going forward, but we may
want to.
2021-02-23 15:57:43 +09:00
Dean Herbert 1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
Dan Balasescu 6240d3964c
Merge pull request #11817 from peppy/fix-collection-dropdown-cross-thread-manipulation
Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown
2021-02-19 10:06:42 +09:00
smoogipoo 8a1a4ea2d4 Set Current directly 2021-02-18 19:33:04 +09:00
smoogipoo 668cc144f6 Fix test failures + multiple filter operations firing 2021-02-18 17:39:01 +09:00
smoogipoo 46ba5de32c Fix collections being imported from BDL thread 2021-02-18 16:19:36 +09:00
Dean Herbert 90dce52042 Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown 2021-02-18 14:10:28 +09:00
S Stewart d2f498a268 remove unnec using 2020-09-19 15:13:52 -05:00
S Stewart c49dcca1ff spacing oops 2020-09-19 14:55:52 -05:00
S Stewart e0cef6686d Change collection deletion notif to be consistent 2020-09-19 14:54:14 -05:00
smoogipoo 6327f12fe4 Disable manage collections item in now playing overlay 2020-09-11 16:58:18 +09:00
smoogipoo a6a76de7a9 Re-expose sealed methods 2020-09-11 16:09:08 +09:00
smoogipoo 4061480419 Rename menu item 2020-09-11 16:02:46 +09:00
smoogipoo 5b80a7db5f Re-namespace collections dropdown 2020-09-11 16:01:01 +09:00
smoogipoo 2d7e85f622 Remove async load (now using loadComponentSingleFile) 2020-09-09 15:40:45 +09:00
smoogipoo 0360f7d845 Move CollectionManager to OsuGame 2020-09-09 15:39:15 +09:00
smoogipoo 4ddf5f054b Rename BeatmapCollectionManager -> CollectionManager 2020-09-09 15:31:08 +09:00
Dean Herbert 5d9ce0df98 Add remark about temporary nature of database format 2020-09-09 14:44:04 +09:00
Dean Herbert 8cd0bbe469 Make BeatmapCollectionManager a component 2020-09-09 14:31:23 +09:00
smoogipoo 8e2f5d4ea8 Fix test failures 2020-09-08 19:41:05 +09:00
smoogipoo b7ca003928 Remove unnecessary check 2020-09-08 19:14:48 +09:00
smoogipoo 070704cba7 Asyncify initial load 2020-09-08 17:59:38 +09:00
smoogipoo 06328e0000 Add import/deletion progress notifications 2020-09-08 17:59:27 +09:00
smoogipoo 4737add00b Add close button to dialog 2020-09-08 17:21:29 +09:00
smoogipoo d2650fc1a0 Add count to deletion dialog 2020-09-08 17:12:58 +09:00
smoogipoo bee450ae1e Fix tests/add placeholder item tests 2020-09-08 17:05:51 +09:00
smoogipoo 2e40ff25f7 Only pad textbox after collection is created 2020-09-08 17:05:31 +09:00
smoogipoo 38ade433a6 Add some xmldocs 2020-09-08 16:50:51 +09:00