Commit Graph

65801 Commits

Author SHA1 Message Date
Dean Herbert
520576a0fd
Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup
Fix a few issues in metadata hub's disconnection requested flow
2024-02-18 03:46:02 +08:00
Dean Herbert
62a7e315bf
Update framework 2024-02-18 03:11:29 +08:00
Dean Herbert
2adc8b15e7
Merge pull request #27205 from Joehuu/fix-star-counter-animation-above-10
Fix star counter decrease animation being delayed when current is over displayed star count
2024-02-17 18:16:48 +08:00
Joseph Madamba
7a74eaa2de Fix star counter decrease animation being delayed when current is over displayed star count 2024-02-16 22:47:38 -08:00
Joseph Madamba
6e8d8b977e Move ternary inside Math.Max() 2024-02-16 22:47:38 -08:00
Joseph Madamba
8169d1ac80 Add twenty star counter in visual test 2024-02-16 22:47:38 -08:00
Dean Herbert
5fda3a3091
Merge pull request #27200 from frenzibyte/fix-cursor-ripple-in-replay
Fix cursor ripples displaying on release positions in replays
2024-02-17 14:40:30 +08:00
Salman Ahmed
ce903987e7 Fix cursor ripples being added on release positions in replays 2024-02-17 00:53:53 +03:00
Salman Ahmed
4bbb1bc67e
Merge pull request #26951 from myQwil/mute_detection
Improve silence detection in `MutedNotification`
2024-02-16 23:49:54 +03:00
Salman Ahmed
bbd770687d
Merge branch 'master' into mute_detection 2024-02-16 23:22:57 +03:00
Bartłomiej Dach
1049be7d72
Add extended xmldoc to DisconnectRequested()
Just expounds on what the previous commit message said.
2024-02-16 13:09:36 +01:00
Bartłomiej Dach
b4aa247032
Do not attempt to stop watching user presence when requested to disconnect
First of all, this sort of cleanup isn't really the client's
responsibility, and secondly, at the point the client received this
request to disconnect, *none of its requests will be honored anymore*
(currently the only scenario of this if another client has connected
- the server-side concurrency filter will reject this request).

When disconnection is requested, the only valid thing to do with respect
to talking to the server is to stop doing it.

This will be moved server-side in a follow-up change, although I'm not
even strictly sure that's required - I'd like to think signalr would
know to clean up a disconnecting client from all groups they were in.
2024-02-16 13:08:39 +01:00
Bartłomiej Dach
9fa60b169e
Actually disconnect from metadata hub when requested to
Nothing in this override, on in the base implementation, would actually
attempt to disconnect.
2024-02-16 12:58:50 +01:00
Bartłomiej Dach
171270d99c
Fix missing RPC method mapping
Thanks, signalr.
2024-02-16 12:58:13 +01:00
Salman Ahmed
583e71634f Always bring master/music volume to 50% 2024-02-16 11:20:07 +03:00
Salman Ahmed
952c5b0d18 Use Precision.AlmostBigger 2024-02-16 11:13:41 +03:00
Salman Ahmed
6a1d118b21 Adjust tests again 2024-02-16 10:52:27 +03:00
Salman Ahmed
9f53185fa9 Revert changes to muted notification action 2024-02-16 10:47:56 +03:00
Dean Herbert
c7f80087e1
Merge pull request #27190 from Joehuu/readme-update-net-version
Update .NET version on readme
2024-02-16 15:42:01 +08:00
Joseph Madamba
27ce965dd2 Update unsupported windows startup blocker comment 2024-02-15 22:52:27 -08:00
Joseph Madamba
25fb73adbd Mention unsupported platforms can still run the release on readme 2024-02-15 22:50:03 -08:00
Joseph Madamba
29ed0969ca Update .NET version on readme 2024-02-15 22:29:03 -08:00
Dean Herbert
d07fd95a8b
Merge pull request #27186 from FamousPig/update-launch-json 2024-02-16 08:32:11 +08:00
Mike Will
22dafd8e9c fix typo 2024-02-15 18:56:09 -05:00
Salman Ahmed
22ffac1718 Update Rider configuration files 2024-02-16 01:45:38 +03:00
Salman Ahmed
ec85bf0ae6 Update other VS code configuration files 2024-02-16 01:45:30 +03:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection 2024-02-16 01:35:02 +03:00
Salman Ahmed
7530b1f362 Adjust comment again 2024-02-16 01:31:52 +03:00
Salman Ahmed
6751f95eb6 Adjust test cases and approximate equality 2024-02-16 01:28:53 +03:00
Salman Ahmed
5431781f80 Bring back target volume to 50% 2024-02-16 01:23:26 +03:00
Salman Ahmed
d81b148b09 Remove mention of decibel units in comment
Decibels are irrelevant in the volume bindables, as mentioned in PR already.
2024-02-16 01:23:18 +03:00
Salman Ahmed
a9eac5924d Remove seemingly unnecessary float casts 2024-02-16 01:18:13 +03:00
Leon Gebler
b4b41dcd8f Point launch.json to new build directory 2024-02-15 23:11:08 +01:00
Salman Ahmed
66b413619b
Merge pull request #27138 from bdach/legacy-body-piece-crash
Fix selected legacy skins crashing on zero-length hold notes
2024-02-16 01:02:32 +03:00
Salman Ahmed
3108842a1c
Merge branch 'master' into legacy-body-piece-crash 2024-02-16 00:30:36 +03:00
Salman Ahmed
7f59b0a6ac
Merge pull request #27185 from peppy/update-ios-icon-metrics
Update iOS icon metrics to match previous icon
2024-02-16 00:07:41 +03:00
Salman Ahmed
40d34a8308
Merge branch 'master' into update-ios-icon-metrics 2024-02-15 23:39:11 +03:00
Dean Herbert
c1d9f53ab4
Merge pull request #27068 from smoogipoo/mania-hd-fi-progression
Add progressive coverage for mania's Hidden and FadeIn mods
2024-02-16 01:00:53 +08:00
Dean Herbert
c4bcae86ec
Update iOS icon metrics to match previous icon 2024-02-16 00:43:20 +08:00
Bartłomiej Dach
df9ca9037a
Merge pull request #27184 from peppy/update-windows-icon-metrics
Update windows icon metrics to match previous icon
2024-02-15 17:07:35 +01:00
Bartłomiej Dach
4b2197039c
Make dropdown text nicer 2024-02-15 16:40:58 +01:00
Dean Herbert
e705190664
Update windows icon metrics to match previous icon 2024-02-15 23:23:49 +08:00
Dan Balasescu
878fb2d10d
Add break support 2024-02-15 22:05:25 +09:00
Dan Balasescu
d1a51b474c
Adjust tests 2024-02-15 21:25:40 +09:00
Dean Herbert
e55ab96cc5
Merge pull request #27179 from peppy/update-framework
Update framework
2024-02-15 20:14:18 +08:00
Bartłomiej Dach
9c22fa3a9f
Fix android test project compile failures 2024-02-15 12:22:14 +01:00
Dan Balasescu
755bc7c050
Fix resolution scaling 2024-02-15 20:07:55 +09:00
Dean Herbert
e91d38872d
Update framework 2024-02-15 18:28:59 +08:00
Dan Balasescu
a037dbf8de
Update test to set Child in more canonical manner 2024-02-15 18:33:48 +09:00
Bartłomiej Dach
e10c4c7079
Merge pull request #27176 from peppy/document-classic-mod-no-rank
Add inline documentation as to why classic mod is not ranked
2024-02-15 09:22:05 +01:00