Commit Graph

59753 Commits

Author SHA1 Message Date
Bartłomiej Dach 0cc92ce5f9
Add failing test case
Covering nested object reverts not firing the parent's `RevertResult`
event in accordance with what the xmldoc of the event states.
2023-04-11 18:24:34 +02:00
Joseph Madamba d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label 2023-04-10 23:37:29 -07:00
Joseph Madamba f0c8a3202b
Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology 2023-04-10 23:22:15 -07:00
Dean Herbert e58e1151f3
Merge pull request #23178 from Joehuu/fix-count-not-updating-when-deleting
Fix song select beatmap difficulty count not updating when deleting
2023-04-11 09:46:41 +09:00
Dean Herbert 52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting 2023-04-11 09:04:02 +09:00
Joseph Madamba f80de08f24
Adjust `BeatmapSetsChanged` xmldoc
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-04-10 11:28:23 -07:00
Joseph Madamba c7dea71793
Use existing `BeatmapSetsChanged` action 2023-04-10 11:26:18 -07:00
Dean Herbert 8757276c37
Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping
Add rotation snapping to editor selection
2023-04-11 00:45:44 +09:00
Dean Herbert 52c4703261
Merge pull request #23103 from Joehuu/normalise-overlay-padding
Normalise horizontal padding on overlays
2023-04-10 23:48:59 +09:00
Bartłomiej Dach 184f6d2dd4
Merge pull request #23087 from cdwcgt/gd-onlinesetoverlay
Show guest difficulty author in beatmap overlay
2023-04-10 16:30:10 +02:00
Bartłomiej Dach 1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay 2023-04-10 15:35:03 +02:00
Bartłomiej Dach 6e08105e2c
Remove usage of "diff" vernacular 2023-04-10 15:27:10 +02:00
Bartłomiej Dach 11fd93a2ba
Inline disturbing `getGuestMapper()` method
Disturbing because name suggests pure method, but it is in fact `void`
and also performs side effects by about the most confusing means
possible.
2023-04-10 15:20:43 +02:00
Bartłomiej Dach 1255d489fc
Merge pull request #23133 from peppy/editor-inspector
Add hit object inspector to editor
2023-04-10 15:13:33 +02:00
Bartłomiej Dach 73bd0feef5
Fix incorrectly implemented localisation 2023-04-10 15:03:33 +02:00
Bartłomiej Dach 6fec476147
Simplify snap implementation 2023-04-10 14:55:30 +02:00
Bartłomiej Dach ead5e9f027
Merge branch 'master' into editor-inspector 2023-04-10 14:29:05 +02:00
Dean Herbert 0d696f8938
Merge pull request #23177 from smoogipoo/progressive-dt-multiplier
Add progressive DT/HT mod multipliers
2023-04-10 21:27:48 +09:00
Bartłomiej Dach 60358c7203
Perform first inspector text update immediately
Provides better and more consistent initial state for the inspector.
2023-04-10 14:13:53 +02:00
Bartłomiej Dach 641415ca32
Unify displayed duration format for single/multiple selection 2023-04-10 14:05:32 +02:00
Dan Balasescu ad51f880e0 Remove overrides on DC/NC mods 2023-04-10 17:49:29 +09:00
Joseph Madamba 7f5b99c91b
Fix song select beatmap difficulty count not updating when deleting 2023-04-09 22:12:51 -07:00
Joseph Madamba bfb7ead689
Add failing text box beatmap difficulty count test 2023-04-09 22:12:50 -07:00
Dan Balasescu 15f6bc155e Add progressive score multiplier for HT 2023-04-10 13:35:48 +09:00
Dan Balasescu c923482976 Add progressive score multiplier for DT 2023-04-10 13:31:48 +09:00
Dean Herbert 8d2e852ffd Fix overbearing key down handling 2023-04-08 22:30:36 +09:00
Dean Herbert a1fc4def1d Remove redundant method override 2023-04-08 22:18:07 +09:00
Micha Lehmann 3c4a25e53f Fix tooltip text not resetting when ending an editor rotation 2023-04-08 14:28:52 +02:00
Micha Lehmann 580d5745c0 Add "(snapped)" to the tooltip when snap-rotating in the editor 2023-04-08 14:15:49 +02:00
Joseph Madamba a86a968fac
Use public `BeatmapSet` to match other usages 2023-04-07 21:16:36 -07:00
Joseph Madamba ed208ef127
Fix more typos and adjust font size to match web 2023-04-07 21:10:37 -07:00
Dean Herbert f72dd86b42 Fix code quality issues and avoid updating bindable twice per operation 2023-04-08 10:40:36 +09:00
Micha Lehmann c827c2810b Improve editor selection rotation value wrapping
This fixes two issues the previous algorithm had:
1.  A half-turn rotation used to show up as -180°.
2.  Rotating more than 180° in one drag event would overwhelm it
    and cause the value to go outside its range.

This comes at the cost of a negligible performance hit,
since a division (modulo) is performed instead of just addition/subtraction.
2023-04-08 01:30:29 +02:00
Micha Lehmann f1de560d57 Snap editor selection rotation when holding shift 2023-04-08 01:30:29 +02:00
Dean Herbert ad717d2368 Fix scheduled calls piling up during transactions 2023-04-06 23:39:36 +09:00
Dean Herbert 628c23afae
Merge pull request #23146 from EVAST9919/ruleset-samples-dispose
Fix `SampleStore` in `DrawableRulesetDependencies` isn't being disposed
2023-04-06 21:02:39 +09:00
Andrei Zavatski ed565b1e59 Fix SampleStore isn't being disposed 2023-04-06 11:40:04 +03:00
Dean Herbert e6872629f3
Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
Bartłomiej Dach 92b8a0eaf4
Merge pull request #22872 from Terochi/update-skinnable-sound-before-playing
Fix pause and fail screen samples not updating when skin is changed during gameplay
2023-04-05 23:39:10 +02:00
Bartłomiej Dach ba753a8aac
Merge branch 'master' into update-skinnable-sound-before-playing 2023-04-05 22:56:25 +02:00
Bartłomiej Dach 8a52658c1f
Merge pull request #22858 from peppy/fix-old-beatmap-crash-on-load
Fix crash on attempting to load some old beatmaps which specify background images incorrectly
2023-04-05 22:28:05 +02:00
Bartłomiej Dach 27055919a3
Merge branch 'master' into fix-old-beatmap-crash-on-load 2023-04-05 21:39:42 +02:00
Bartłomiej Dach a4e68e1845
Merge pull request #22654 from ItsShamed/gameplay/key-counter-abstraction
Introduce common structure for key counters
2023-04-05 21:07:30 +02:00
Bartłomiej Dach 6df7614b9d
Add tests for suppressing epilepsy warning when storyboard disabled 2023-04-05 20:56:50 +02:00
Bartłomiej Dach 02c6126be7
Ensure storyboards are enabled in existing epilepsy warning tests 2023-04-05 20:53:54 +02:00
Bartłomiej Dach e5d57a65c9
Fix incorrect indent 2023-04-05 19:47:25 +02:00
Bartłomiej Dach 432f698697
Merge branch 'master' into gameplay/key-counter-abstraction 2023-04-05 19:45:14 +02:00
Dean Herbert 9c8b25e034 Fix display not always updating when expected by updating on a schedule 2023-04-05 13:45:24 +09:00
Bartłomiej Dach ff593137de
Merge pull request #23112 from peppy/taiko-sample-based-plcaement
Remove left/right click based placement in taiko editor and respect sample selection
2023-04-04 19:32:43 +02:00
Bartłomiej Dach 7d9327f3e2
Only allow hit placement when left mouse is clicked 2023-04-04 18:40:10 +02:00