4532d0ecdf
Add logging & debug facility for touch input interceptor
2023-11-02 21:24:58 +01:00
c588f434e5
Fix song select touch handler causing crashes when song select is suspended
2023-11-02 21:24:58 +01:00
ef555ed0cf
Fix test failures
2023-11-02 21:24:58 +01:00
21a4da463b
Add failing test covering crash scenario
2023-11-02 21:24:58 +01:00
f2df02b60f
Automatically activate touch device mod in player
2023-11-02 21:24:58 +01:00
29d4d81eaa
Add test scene for basic touchscreen detection scenarios
2023-11-02 21:24:58 +01:00
2f6ff893b5
Automatically activate and deactivate touch device mod in song select
2023-11-02 19:45:48 +01:00
980c900f43
Add component for game-wide touch detection
2023-11-02 19:32:56 +01:00
68efb3c110
Mark `ModTouchDevice` as always valid for submission
2023-11-02 19:25:57 +01:00
9f11a04cc7
Generalise notion of 'touch device' mod
2023-11-02 19:14:05 +01:00
efb4458061
Merge pull request #25336 from peppy/mania-key-expand-mobile
...
Add support for "argon" default skin to expand columns when on mobile devices
2023-11-02 12:40:57 +01:00
998d709331
Merge branch 'master' into mania-key-expand-mobile
2023-11-02 11:59:01 +01:00
704f5a6de3
Adjust sizing slightly to ensure we stay within 1366 limits
2023-11-02 11:44:36 +01:00
e18d0b64de
Merge pull request #25338 from peppy/mania-mod-ordering
...
Change osu!mania conversion mod ordering to be more appeasing
2023-11-02 10:46:32 +01:00
64feea80db
Merge pull request #25334 from peppy/fix-bubble-crash-again
...
Fix another potential crash in bubbles mod
2023-11-02 09:32:09 +01:00
b7ab886848
Merge pull request #25333 from peppy/fix-spinner-performance
...
Fix all spinner ticks being alive and causing performance degradation
2023-11-02 09:07:44 +01:00
ad82ada030
Trim redundant comments
2023-11-02 08:18:37 +01:00
c83589cb74
Change osu!mania conversion mod ordering to be more appeasing
2023-11-02 15:49:10 +09:00
6dab5ee4cf
Add support for "argon" default skin to expand columns when on mobile device
...
Should ease those looking to play the game on mobile until we
(potentially) have a better solution in the future.
If this works out well, we can consider rolling it out to other skins.
Closes https://github.com/ppy/osu/issues/23377 .
2023-11-02 15:13:44 +09:00
48bdeaeff1
Fix another potential crash in bubbles mod
...
Storing `DrawableHitObject` for later use is not safe – especially
when accessing `HitObject` – as it's a pooled class. In the case here,
it's important to note that `PrepareForUse` can be called a frame or
more later in execution, which made this unsafe.
Closes https://github.com/ppy/osu/issues/24444 .
2023-11-02 02:43:51 +09:00
c2de03aa44
Fix all spinner ticks being alive and causing performance degradation
...
Regressed in https://github.com/ppy/osu/pull/25216 .
The new logic will ensure at least one tick is ready for judgement.
There shouldn't be a case where more than one is needed in a single
frame.
2023-11-01 18:28:07 +09:00
57d8b5ddc9
Merge pull request #25328 from bdach/mod-cleanups-docs
...
Clean up mod usability flags
2023-11-01 15:48:47 +09:00
a90f8dd4f6
Seal a few more multiplayer playability flags of rate-changing mods
...
Not really changing anything, just tightening things down to curb
possible funny business.
2023-10-31 16:20:33 +01:00
955e2ed051
Seal `UnknownMod`
...
Not a class for extension.
2023-10-31 16:18:09 +01:00
a644c75957
Mark `ModScoreV2` as invalid for multiplayer
...
Doesn't do much for the client; mostly a safety for osu-web's sake,
as without the change it could theoretically fail to validate the mod
properly in multiplayer contexts.
2023-10-31 16:16:59 +01:00
456f4ebba2
Seal `ModScoreV2`
...
Nobody should ever need to extend it.
2023-10-31 16:16:14 +01:00
3a2645efb1
Seal `ModAutoplay` playability flags
...
Can't do much more than that due to the unfortunate fact of Cinema
inheriting from Autoplay.
2023-10-31 16:15:10 +01:00
7ea298a1b6
Add xmldoc to `Mod` playability flags
2023-10-31 16:13:44 +01:00
95d8ee8e9b
Merge pull request #25323 from bdach/fix-key-binding-test-failures
...
Fix key binding row fire-and-forgetting writes
2023-10-31 22:13:42 +09:00
9f5a280bc2
Fix key binding row fire-and-forgetting writes
...
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129
This is what happens if you carelessly fire and forget.
The working theory (that I'm not sure I have the tools to conclusively
confirm) is that the async write from the key binding changing could
fire _after_ the section is reset.
I briefly considered having the test wait for the change, but given that
the entirety of the surrounding flow is using sync operations, this just
looks like a bug to me. And there's no real sane way to inject async
into that flow due to dependence on `OsuButton.Action`.
2023-10-31 12:25:09 +01:00
bc2acc3e93
Merge pull request #25318 from peppy/fix-follow-point-scrathces
...
Fix potential texture corruption when cropping gameplay textures of weird aspect ratios
2023-10-31 11:02:59 +01:00
850866e7f4
Merge pull request #25316 from peppy/metronome-always-play-tick
...
Decouple metronome tick playback from pendulum movement
2023-10-31 09:37:29 +01:00
0d44b5af90
Fix potential texture corruption when cropping gameplay textures of weird aspet ratios
...
Closes https://github.com/ppy/osu/issues/25273 .
2023-10-31 17:36:23 +09:00
84fb0c63e5
Merge pull request #23823 from peppy/beat-divisor-select-text-on-click
...
Select text in beat divisor popover automatically
2023-10-31 09:34:44 +01:00
144006fbe8
Update autoselect implementation to work correctly with framework changes
2023-10-31 08:38:22 +01:00
8a68333425
Merge branch 'master' into beat-divisor-select-text-on-click
2023-10-31 08:36:53 +01:00
af84704076
Merge pull request #25315 from peppy/fix-flaky-tests
...
Address some flaky tests from recent times
2023-10-31 08:30:19 +01:00
64efc3d251
Decouple metronome tick playback from pendulum movement
...
Not super happy about doing this, but it seems like it's in the best
interest of editor usability.
2023-10-31 15:33:46 +09:00
8c067dc584
Fix mod tests not waiting for presets to finish loading
...
See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850 .
2023-10-31 14:53:07 +09:00
7ceced7012
Scope `TestPauseWithLargeOffset` to focus on what matters
...
See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009
This test is to make sure we don't seek before the original
pause time, so I've exposed that value precisely to avoid
CI woes.
2023-10-31 14:47:04 +09:00
d379e553da
Fix back-to-front logging
2023-10-31 14:31:26 +09:00
bdd3f2847b
Add an extra storyboard sample to avoid intermittent failures in `TestStoryboardSamplesStopOnSkip`
...
Probably CI running slow timing balls.
The point of failure is `waitUntilStoryboardSamplesPlay()`
after already testing the important part of the test (that
the samples stop on skip) so let's give it another possible
point to recover.
See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701 .
2023-10-31 14:28:40 +09:00
66b84d02cb
Add note about `TestGameplayExitFlow` failure, and ignore for now
...
See:
https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641
https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419
2023-10-31 14:27:55 +09:00
89444d5544
Fix export test still occasionally failing due to file write in progress
...
https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074
Basically, `File.Move` may not be an atomic operation.
2023-10-31 14:00:49 +09:00
37ec10d4f5
Fix `TestSongSelectScrollHandling` not waiting for `VolumeOverlay` to load
...
See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721 .
2023-10-31 13:49:53 +09:00
fa220d34de
Merge pull request #25272 from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene
...
Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI
2023-10-31 13:36:30 +09:00
a3dc9a73b1
Revert behaviour changes of `MaxDimensions` test and ignore instead
2023-10-31 13:36:10 +09:00
0ffd5104ef
Merge pull request #25274 from frenzibyte/tournament-display-team-seed
...
Support displaying team seeds in tournament client
2023-10-31 13:34:13 +09:00
bb6555c901
Merge branch 'master' into tournament-display-team-seed
2023-10-31 12:45:21 +09:00
feeb95e4c3
Adjust `DrawableTeamTitleWithHeader` to match new layout
2023-10-31 12:44:43 +09:00
Bartłomiej Dach
Dean Herbert