Bartłomiej Dach
44a3f40188
Rename test step
2023-06-25 17:39:36 +02:00
Bartłomiej Dach
7d9d7066cd
Remove no-longer-needed BDL permitNulls spec
2023-06-25 17:39:15 +02:00
Bartłomiej Dach
9862992af0
Use alternative guard
...
Early-returning from ctors feels pretty bad. Also saves on some
nested accesses.
2023-06-25 17:37:05 +02:00
cdwcgt
e02a06e3e5
Revert "remove #nullable disable in LadderInfo"
...
This reverts commit 0dced46100
2023-06-25 22:47:36 +09:00
cdwcgt
a3cd0d14a3
null guard for Current Match in MatchMessage
2023-06-25 20:46:58 +09:00
cdwcgt
0dced46100
remove #nullable disable in LadderInfo
2023-06-25 20:46:55 +09:00
Bartłomiej Dach
25842105ce
Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness
...
Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object
2023-06-25 08:23:55 +02:00
Dean Herbert
922fe927ac
Update resources
2023-06-25 15:18:56 +09:00
Bartłomiej Dach
d43131ac88
Merge pull request #24019 from peppy/framework-update
...
Apply required nullability changes in line with framework update
2023-06-25 06:43:21 +02:00
Dean Herbert
5806153cfd
Update framework
2023-06-25 12:00:14 +09:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side
2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Bartłomiej Dach
511451770c
Merge pull request #24021 from peppy/mass-nrt
...
Apply NRT to all files where it can be easily applied
2023-06-24 18:31:32 +02:00
Dean Herbert
ca402c4d2f
Update framework
2023-06-25 00:38:19 +09:00
Bartłomiej Dach
e273c223a8
Fix some more missed CI inspections
2023-06-24 17:11:38 +02:00
Bartłomiej Dach
df2dcf85b4
Fix wrong disable
2023-06-24 17:07:42 +02:00
Bartłomiej Dach
34e2540331
Fix nullability-related warnings in Android project
2023-06-24 17:05:52 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections
2023-06-24 16:07:01 +02:00
Bartłomiej Dach
caf5673b68
Revert nullability enables in tournament client
...
Not trivial to fix right now and I'm not fixing in a 1k-line changeset.
2023-06-24 16:05:19 +02:00
Bartłomiej Dach
2c1a44da89
Revert nullability enable in BeatmapBackground
...
Due to varying expectations in handling of `Beatmap`. Some places allow
or expect null and some don't. Needs to be looked at closer separately.
2023-06-24 15:40:06 +02:00
Bartłomiej Dach
66ef199fa4
Revert nullability enable in Score (and related changes)
...
Causes several knock-on inspections in `OsuGame` et al. Probably best
addressed in a separate pass, because treatment is mixed at best (some
places nullcheck, some expect non-null).
2023-06-24 15:35:07 +02:00
Bartłomiej Dach
8fdd599b39
Match field NRT annotation in ctor argument
2023-06-24 15:17:14 +02:00
Bartłomiej Dach
1f2f522a1e
Mark override as null-accepting
...
`ModelBackedDrawable<T>.CreateDrawable()` is R#-annotated to accept
a potentially null model. Apply nullability there too for better reading
experience.
2023-06-24 15:07:04 +02:00
Bartłomiej Dach
354e85a2e1
Trim redundant BDL nullability spec
2023-06-24 14:35:23 +02:00
Dean Herbert
2bda63c2c8
Merge branch 'master' into mass-nrt
2023-06-24 09:59:15 +09:00
Dean Herbert
58e6b3782b
Fix a couple of remaining issues
2023-06-24 09:58:36 +09:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Bartłomiej Dach
23aa1752c3
Merge pull request #24009 from peppy/fix-touch-input-controls-floating-fruits
...
Change "floating fruits" mod to only apply adjustments to the playfield
2023-06-23 23:26:20 +02:00
Salman Ahmed
318260bbfd
Merge pull request #23890 from cdwcgt/tournament-chatcolor
...
Tint username of team members in tournament chat according to the team colour
2023-06-23 23:22:40 +03:00
Salman Ahmed
c5771912db
Merge branch 'master' into tournament-chatcolor
2023-06-23 22:23:33 +03:00
Salman Ahmed
7a771609f9
Reword and fix typo
2023-06-23 22:20:25 +03:00
Salman Ahmed
4a2f259f7e
Add test coverage for tournament players with profile colours
2023-06-23 22:04:29 +03:00
Dean Herbert
ad6650cbfa
Add automated commit to blame ignore revs
2023-06-24 01:56:38 +09:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
d86424467e
Merge pull request #23971 from tybug/comment-logged-out
...
Disable posting comments when logged out
2023-06-23 15:15:27 +09:00
Dean Herbert
08b3c0cce0
Change "floating fruits" mod to only apply adjustments to the playfield
...
Avoids things like touch screen inputs also being flipped.
Note that these adjustments can't be applied directly to the playfield
due to how playfields are used in various rulesets (basically relying on
the `PlayfieldAdjustContainer` to get things in the right place).
Closes #24000 .
2023-06-23 14:18:43 +09:00
Dean Herbert
343271751a
Add Schedule to ensure correct thread for UI code
2023-06-23 14:07:33 +09:00
Dean Herbert
ce1579f2fe
Bind to API.State instead of API.User
2023-06-23 14:05:02 +09:00
Dean Herbert
d53996336c
Add note about swells and their ticks
2023-06-23 14:01:10 +09:00
Dean Herbert
64b726d5ec
Fix nested logic not being completely correct (favouring already-passed rather than near-future)
2023-06-23 13:48:13 +09:00
Bartłomiej Dach
c06b825d9b
Merge branch 'master' into comment-logged-out
2023-06-22 23:19:00 +02:00
Bartłomiej Dach
2c1c20e0a7
Rename test helpers
2023-06-22 23:10:16 +02:00
Bartłomiej Dach
1672608a87
Document why things were done in DummyAPIAccess
2023-06-22 23:08:30 +02:00
Bartłomiej Dach
786deec296
Rename and xmldoc members
2023-06-22 23:00:52 +02:00
Bartłomiej Dach
361ae15824
Merge pull request #23999 from peppy/fix-catch-legacy-combo-floating
...
Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active
2023-06-22 22:49:31 +02:00
Bartłomiej Dach
0ce4d17e30
Merge pull request #23888 from peppy/fix-intro-playing-twice
...
Fix music sometimes restarting twice if exiting song select with no beatmap selected
2023-06-22 22:49:15 +02:00
Bartłomiej Dach
a753c89dea
Merge pull request #23974 from peppy/fix-multiplayer-present-beatmap
...
Fix presenting beatmaps while in a multiplayer room not working
2023-06-22 22:48:48 +02:00
Bartłomiej Dach
bede12a3e8
Merge pull request #23975 from peppy/skin-editor-beatmap-skin-disable
...
Disable beatmap skinning support when entering the skin editor
2023-06-22 22:45:44 +02:00
Liam DeVoe
21bed336c6
adjust DummyAPIAccess to more closely match APIAccess
...
wrt logging in and out
2023-06-22 16:01:12 -04:00
