RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
22,780 Commits 3 Branches 651 Tags 355 MiB
Commit Graph

629 Commits

Author SHA1 Message Date
Dean Herbert 51bf600ea7 Use empty hitwindows instead of null 2019-10-09 19:08:31 +09:00
Bartłomiej Dach 8efab559c8 Remove unused using directives 2019-09-25 01:13:42 +02:00
Bartłomiej Dach 9323df26a1 Decouple bar line hitobjects from generator 
Introduce an IBarLine interface, which together with generic constraints
helps decouple BarLineGenerator from the actual hitobject types it
creates. Thanks to this, all rulesets that want bar lines can provide
an implementation of IBarLine that also derives from the base hitobject
class.

This allows DrawableBarLines in taiko and mania to be migrated back to
DrawableTaikoHitObject and DrawableManiaHitObject base classes
respectively. This in turn resolves #6215 without code duplication,
since the missing anchoring application is now done in mania's
DrawableBarLine through deriving from DrawableManiaHitObject.
 2019-09-25 00:36:27 +02:00
Bartłomiej Dach a407e267a2 Fix PF/SD legacy mod conversion 
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
 2019-09-15 22:55:25 +02:00
Dean Herbert 624e5644a4 Change osu!catch key trigger to occur on frame before positional change 2019-09-13 23:06:35 +09:00
Dan Balasescu 125b3fda6c
Merge branch 'master' into improve-catch-replay-frames 2019-09-13 19:23:15 +09:00
Dean Herbert 9fc60aeefc Merge branch 'master' into reset-dho-lifetimes 2019-09-12 19:29:14 +09:00
Dean Herbert f21e47d6d2 Move expire to DrawableHitObject 2019-09-12 19:29:08 +09:00
Dean Herbert acdfeef1dc Improve how osu!catch stores and replays key actions 2019-09-12 18:33:46 +09:00
Dean Herbert af3bb5a2cd Centralise and share bar line generation code between rulesets 2019-09-10 13:30:54 +09:00
Dean Herbert 6cdc87bd29 Fix allowed results omissions 2019-09-06 15:37:20 +09:00
Dean Herbert f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
smoogipoo 5efd455ce4 Fix taiko sample namespace 2019-09-04 12:47:10 +09:00
Dean Herbert 40c61894ef Update some case sensitive resources lookups in-line with resources 2019-09-04 10:44:24 +09:00
Dean Herbert 05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
Dean Herbert 0261456d5a
Merge branch 'master' into play-to-gameplay 2019-09-03 11:42:15 +09:00
smoogipoo 8302658186 Fix other potential nullref cases that rider missed 2019-09-02 18:31:33 +09:00
smoogipoo 4c150839c0 Fix potential diffcalc hitwindow nullref 2019-09-02 17:38:58 +09:00
smoogipoo f3656475de Return null hitwindows for non-time-based objects 2019-09-02 16:10:30 +09:00
Dean Herbert f9fcf1562f Merge remote-tracking branch 'upstream/master' into iskincomponent 2019-09-02 14:21:02 +09:00
Dean Herbert 13bb0676b1
Merge branch 'master' into fix-taiko-swell-tick-display 2019-09-02 13:47:04 +09:00
smoogipoo 1df422e591 Hide taiko swell ticks 2019-09-02 13:30:55 +09:00
smoogipoo 5b685c4cd2 Fix swell ticks having non-zero time offsets 2019-09-02 13:25:39 +09:00
Dean Herbert 70e417533f Update naming 2019-08-30 15:13:29 +09:00
Dean Herbert a15828ab25 Introduce the concept of SkinComponents 
Removes reliance on string lookups and better defines elements for introduction into database
 2019-08-30 14:55:52 +09:00
smoogipoo 6ab2b20c70 Add an interface for working beatmaps 2019-08-29 19:38:44 +09:00
Dean Herbert 720908ba22
Merge pull request #5865 from peppy/fix-osu-hitobject-fade-in 
Fix osu! approach circles fading in too late
 2019-08-28 20:25:49 +09:00
Dean Herbert 9a98f39f06 Share logic with other rulesets (and make default) 2019-08-28 18:12:47 +09:00
smoogipoo 7cc92e2fad Make taiko proxy containers use LifetimeManagementContainer 2019-08-28 13:20:28 +09:00
smoogipoo 3723c441d2 Merge remote-tracking branch 'origin/master' into fix-taiko-proxy-rewind 
# Conflicts:
#	osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs
 2019-08-27 17:42:45 +09:00
smoogipoo 2b22fd799d Use constant value for offset 2019-08-27 15:33:53 +09:00
smoogipoo bc7a81e733 Add initial fade transform 2019-08-27 15:33:53 +09:00
smoogipoo dba3679817 Fix DrawableSwell not proxying its content in time/correctly 2019-08-27 15:33:28 +09:00
smoogipoo b85e62a6e2 Fix taiko proxies being removed on rewind 2019-08-27 15:24:49 +09:00
iiSaLMaN 0eef398ca7 Remove redundant using directive 2019-08-27 05:19:21 +03:00
iiSaLMaN cd68d030bd Remove unnecessary UpdateState overrides 2019-08-27 05:04:34 +03:00
iiSaLMaN 843da26dba Use transform management for taiko hit objects 2019-08-27 05:03:56 +03:00
smoogipoo d4a296f911 Slight refactoring 2019-08-26 17:45:12 +09:00
smoogipoo fd4c6e08ca Merge remote-tracking branch 'origin/master' 2019-08-26 17:37:06 +09:00
Dean Herbert 48716f8f2b Update framework 2019-08-21 13:29:50 +09:00
Desconocidosmh 77e9e89fec Refactoring 2019-08-19 20:45:23 +02:00
Desconocidosmh 9bd844bf4d Make comment more informative 2019-08-19 19:54:22 +02:00
Desconocidosmh 9732f5d622 Add Swell to GetNextObject() check 2019-08-19 17:28:32 +02:00
Desconocidosmh eb83e36e0f Make TaikoAutoGenerator unpress sooner 2019-08-19 17:15:08 +02:00
Desconocidosmh b3556403aa Make GetNextObject() a virtual method 2019-08-19 16:18:25 +02:00
Desconocidosmh aa3651f65e Change the logic so the last button gets unpressed instead of staying pressed forever 2019-08-15 19:45:10 +02:00
Desconocidosmh 386d788813 Change if-else to ternary if 2019-08-15 18:32:45 +02:00
Desconocidosmh ba539abac7 Refactoring 2019-08-14 21:05:24 +02:00
Desconocidosmh e567e81981 Refactoring 2019-08-14 20:10:52 +02:00
Desconocidosmh f849b4ce54 Make autoplay unpress sooner, if needed 2019-08-14 19:49:32 +02:00