Commit Graph

69152 Commits

Author SHA1 Message Date
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.

Not completely happy with how this feels but I think it's a start?

I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
98faa07590
Apply NRT to BreakOverlay 2024-08-27 15:01:51 +09:00
Dean Herbert
797b020747
Add shadow around break overlay middle content to make sure it remains visible 2024-08-27 15:01:50 +09:00
Dean Herbert
abdbe510b8
Move break overlay (and cursor) further forward in depth
I didn't really want to move the cursor in front of the HUD, but we face
a bit of an impossible scenario otherwise (it should definitely be in
front of the break overlay for visibility).

So I'll deal with it for now.
2024-08-27 14:52:11 +09:00
Dean Herbert
c2c83fe73d
Fix TestSceneBreakTracker not removing old drawables
Also adds a bright background for testing overlay display.
2024-08-27 14:33:36 +09:00
Dean Herbert
dce32a7983
Ban Vortice.* imports
They have colours and boxes and other classes that conflict with our
naming. We never use them.
2024-08-27 14:30:07 +09:00
Dean Herbert
75f2ad1e51
Merge pull request #25953 from OliBomby/free-sliders
Add ability to change slider length by dragging slider tail
2024-08-27 14:12:02 +09:00
Dean Herbert
9840a07eaf
Fix osu!mania hold notes playing a sound at their tail in the editor
Closes #29584.
2024-08-27 14:06:02 +09:00
Dean Herbert
1b26e1c126
Merge branch 'master' into free-sliders 2024-08-27 13:32:24 +09:00
Dean Herbert
50a8348bf9
Apply NRT to remaining classes in slider blueprint namespace 2024-08-27 13:18:55 +09:00
Dean Herbert
4fc96ebfde
Tidy some thing up 2024-08-27 13:13:22 +09:00
Dean Herbert
84bceca778
Assume we can always fetch the ruleset 2024-08-26 15:38:58 +09:00
Dean Herbert
e6c0056199
Merge pull request #29604 from cl8n/mod-icon-misc
Improve mod icon contrast and mod aconym readability
2024-08-26 14:05:43 +09:00
clayton
70d08b9e97
Increase mod icon acronym font weight 2024-08-25 20:42:57 -07:00
clayton
2bb72762ad
Use more contrasting color for mod icon foreground 2024-08-25 20:42:34 -07:00
Dean Herbert
d93ca3de23
Merge pull request #29585 from 424ever/daily-play-count-colours
Fix Daily Challenge play count using a different colour than osu-web
2024-08-24 23:08:29 +09:00
Salman Ahmed
b54487031a Add DailyChallengeButton for intro played flag reset logic 2024-08-24 22:19:17 +09:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web 2024-08-24 11:21:28 +02:00
Salman Ahmed
f5e195a7ee Remove existing test asserts 2024-08-24 06:40:30 +09:00
Dean Herbert
a30fe9daff
Merge pull request #29577 from peppy/skin-deserialise-fix
Fix some older lazer skins failing to load properly
2024-08-23 23:17:01 +09:00
Dean Herbert
885d832e98
Fix deserialise failing with some old skins 2024-08-23 20:44:45 +09:00
Dean Herbert
3943fe96f4
Add failing test showing deserialise failing with some skins 2024-08-23 20:44:35 +09:00
Dean Herbert
1e39af8ac5
Add a bit of logging around medal awarding
Might help with https://github.com/ppy/osu/issues/29119.
2024-08-23 19:49:24 +09:00
Dean Herbert
2a479a84dc
Remove conditional inhibiting seek when beatmap change is not allowed
In testing I can't find a reason for this to exist. Blaming back shows
that it existed before we had `AllowTrackControl` and was likely being
used as a stop-gap measure to achieve the same thing. It's existed since
over 6 years ago.

Let's give removing it a try to fix some usability concerns?

Closes https://github.com/ppy/osu/issues/29563.
2024-08-23 18:21:31 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup 2024-08-23 14:48:50 +09:00
OliBomby
2de5ecceb8 Merge remote-tracking branch 'upstream/master' into scroll-speed-std 2024-08-22 20:17:14 +02:00
OliBomby
ad8e7f1897 Fix scroll speed visualisation missing on start kiai effect points
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
2024-08-22 20:17:09 +02:00
OliBomby
998b5fdc12 Add property EditorShowScrollSpeed to Ruleset 2024-08-22 19:53:34 +02:00
OliBomby
adbdb39e9f move public member to top of file 2024-08-22 19:18:38 +02:00
OliBomby
0db068e423 allow repeating on seek actions 2024-08-22 19:15:53 +02:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed 2024-08-22 20:13:28 +09:00
Bartłomiej Dach
b3e961f6c5
Merge pull request #29562 from peppy/remove-migration-leftover-message
Remove "leftover files" notification when migration partly fails
2024-08-22 12:32:44 +02:00
Dean Herbert
58552e9768
Add missing user ruleset to link copying for beatmap panels 2024-08-22 19:18:41 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base calls to ensure user skin container layouts are retrieved 2024-08-22 19:14:30 +09:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component 2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope 2024-08-22 18:46:07 +09:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup 2024-08-22 18:46:03 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup 2024-08-22 18:39:36 +09:00
Bartłomiej Dach
1859e173f2
Fix EVEN MORE code quality inspections! 2024-08-22 11:16:24 +02:00
Bartłomiej Dach
9997271a6a
Fix more code quality inspections 2024-08-22 10:49:24 +02:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer 2024-08-22 17:42:50 +09:00
Bartłomiej Dach
9020739f36
Remove unused using directives 2024-08-22 10:05:45 +02:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected 2024-08-22 16:22:00 +09:00
Dean Herbert
b3be04aff1
Remove "leftover files" notification when migration partly fails
People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.

For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.

Closes https://github.com/ppy/osu/issues/29505.
2024-08-22 16:09:11 +09:00
Bartłomiej Dach
df94c22a29
Merge pull request #29545 from peppy/timeline-redesign-in-circles
Further timeline usability tweaks
2024-08-22 08:39:34 +02:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
Redesign timing table tracking
2024-08-22 08:21:39 +02:00