Commit Graph

414 Commits

Author SHA1 Message Date
Dan Balasescu 3fff7f4b7e Require ScoreProcessor to receive ruleset 2022-03-14 15:51:10 +09:00
Shivam 1a7a160f0a Update vscode launch.json files for all other projects 2022-02-25 14:28:54 +01:00
Dean Herbert d79845fb1d Revert `NUnit3TestAdaptor` (again)
Console output is still broken. See
https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true.
2022-02-15 17:06:34 +09:00
Dean Herbert 60153bb69d Update nuget packages to highest usable versions
EF packages are intentionally pinned to 5.0.14 as higher versions no
longer support `netstandard2.1`, which we require for xamarin projects.
2022-02-15 15:19:23 +09:00
Dean Herbert 176bb4a4e2 Update desktop projects to target .NET 6 2022-02-10 17:42:09 +09:00
Dan Balasescu 3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00
Dan Balasescu f6f44029e8
Merge pull request #16507 from peppy/more-ingore-rules
Add some missing `IgnoredAttributes` to reduce automapper overhead
2022-01-19 12:26:37 +09:00
Dean Herbert 96d07e20ed Revert nunit test adaptor version bump until console output bug is resolved
Tests have started to output too much log content, causing viewing CI
failures to be painfully impossible. Roll back for now.

Fix may be related to
https://github.com/nunit/nunit3-vs-adapter/issues/941, although we don't
use filter.
2022-01-19 02:18:58 +09:00
Dean Herbert 67bf95bc91 Remove all usage of `AuthorString` 2022-01-18 23:30:40 +09:00
Dean Herbert 7f65f3a47f Remove all usage of `BaseDifficulty` (and access `Difficulty` instead) 2022-01-18 22:57:39 +09:00
Dean Herbert 1b62a685f3 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-18 15:07:59 +09:00
Dean Herbert 125439d177 Update all (non-NET6) nuget packages 2022-01-18 11:09:26 +09:00
Dean Herbert b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
Dean Herbert f9713b8895 Replace usage of `TimeoutAttribute` to fix beatmap conversion test failures 2022-01-04 11:51:41 +09:00
Joseph Madamba 7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Dan Balasescu 8a81392d2b Fix use of incorrect variable, add test 2021-12-16 19:26:36 +09:00
Dan Balasescu 5ea081e899 Test hyperdash generation in catch conversion tests 2021-12-16 19:04:42 +09:00
Dean Herbert f6a3709060 Store default skins to database 2021-11-29 18:28:25 +09:00
Dean Herbert e0629ba81c Update all dependencies 2021-11-20 13:31:10 +09:00
Dan Balasescu 33294ffda6
Merge branch 'master' into fix-plate-clearing-missing-last-banana 2021-11-19 11:42:57 +09:00
Darius Wattimena 9685892b94 Added an extra unit test when actually catching the last banana to also clear the plate 2021-11-18 20:23:42 +01:00
Darius Wattimena cfedbb92c1 Added a unit test to cover clearing of the plate when missing the last banana 2021-11-18 20:07:03 +01:00
Dean Herbert 7c2e79f911 Update all simple cases of switching to `IWorkingBeatmap` 2021-11-17 20:56:57 +09:00
Dean Herbert fabf253381 Update difficulty calculator tests to also use `IWorkingBeatmap` 2021-11-15 19:16:49 +09:00
Dean Herbert 369b4ba789 Update `DifficultyCalculator` to take an `IRulesetInfo` 2021-11-15 19:16:48 +09:00
ekrctb dca2cd6c44
Merge branch 'master' into catch-spinner-checks 2021-11-11 11:32:58 +09:00
Bartłomiej Dach 5e3ac5ac9f
Reset combo in test in a less weird way 2021-11-10 12:05:14 +01:00
Semyon Rozhkov 577bdade5b Hide catcher during banana shower 2021-11-10 04:10:05 +03:00
Darius Wattimena 5d8f35f3c9 Code cleanup and added tests for the spinner check 2021-11-10 00:16:29 +01:00
Semyon Rozhkov 64bc8da14c Add "No Scope" mod implementation for Catch 2021-11-09 17:11:19 +03:00
dependabot[bot] 7747fd5810
Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:01:54 +00:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
ekrctb 60df0151c0 Add very basic distance snap grid for catch editor 2021-10-25 15:25:59 +09:00
Dan Balasescu 8884091422
Merge pull request #15014 from joseph-ireland/remove-initial-strain
Change initial strain value in skills from 1 to 0
2021-10-10 15:56:20 +09:00
Joseph Ireland 185bb9c122 change initial strain from 1 to 0 to allow simpler implementations 2021-10-07 09:30:18 +01:00
smoogipoo ca9c79b758 Use object initialiser (fixes CI inspection) 2021-10-07 16:51:42 +09:00
Dean Herbert b339c149d8 Copy `BaseDifficulty` to `Beatmap<T>` and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert a92d499d7a Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo` 2021-10-01 16:55:50 +09:00
dependabot[bot] 5a1eccd8e3
Bump Microsoft.NET.Test.Sdk from 16.10.0 to 16.11.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.10.0 to 16.11.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-09-01 18:17:37 +00:00
Dean Herbert 17f6efc6fe Fix missed cases of incorrect `.Value` usage
Changing from `Bindable` to `Nullable` comes with its issues...
2021-08-26 14:02:57 +09:00
Dean Herbert 6dcd9427ac Remove bindable usage in `PathControlPoint`
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Bartłomiej Dach a1f50e39aa
Add basic structure for skinning catch explosions 2021-08-11 21:23:32 +02:00
Bartłomiej Dach 637e5cb6b7
Fix offsets not being mirrored 2021-08-10 22:33:28 +02:00
Bartłomiej Dach 30cb4280a4
Add test for catch beatmap mirroring 2021-08-10 22:33:28 +02:00
ekrctb a960a28d06 Replace "end glow" terminology with "hyper-dash after-image"
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
ekrctb 0bf04ece34 Avoid `internal` property by using `ChildrenOfType` 2021-07-28 18:13:43 +09:00
ekrctb da69867fd4 Move catcher trail generation logic to `CatcherArea` 2021-07-27 19:07:37 +09:00
ekrctb d9d9db6f62 Revert "Modify catcher autoplay test pattern to see more variety movement"
I found `TestSceneHyperDash` is useful for visual inspection of hyper dash trails.
This reverts commit 0fbe950a
2021-07-27 19:07:37 +09:00
ekrctb 0fbe950a3c Modify catcher autoplay test pattern to see more variety movement 2021-07-26 18:06:30 +09:00
ekrctb bb046fa3b8 Move catcher trail generation logic to `Catcher`
It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
Trail generation logic is moved to `Catcher`.
The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
Instead, the last time a trail is generated is calculated and used.
The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.
2021-07-26 17:51:59 +09:00